2016-04-25 03:13:33

by Minfei Huang

Subject: [PATCH] Use MICRO UINT_MAX instead of actual value

It's more elegant to use MICRO UINT_MAX to represent the max value of
type unsigned int. So replace the actual value by using this MICRO.

Signed-off-by: Minfei Huang <[email protected]>
---
drivers/nvme/host/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index 643f457..2c0bb13 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -597,7 +597,7 @@ static void nvme_config_discard(struct nvme_ns *ns)

ns->queue->limits.discard_alignment = logical_block_size;
ns->queue->limits.discard_granularity = logical_block_size;
- blk_queue_max_discard_sectors(ns->queue, 0xffffffff);
+ blk_queue_max_discard_sectors(ns->queue, UINT_MAX);
queue_flag_set_unlocked(QUEUE_FLAG_DISCARD, ns->queue);
}

--
2.6.3

2016-04-25 09:45:05

by Sagi Grimberg

Subject: Re: [PATCH] Use MICRO UINT_MAX instead of actual value

> It's more elegant to use MICRO UINT_MAX to represent the max value of
> type unsigned int. So replace the actual value by using this MICRO.

You mean macro right?

2016-04-25 10:08:12

by Minfei Huang

Subject: Re: [PATCH] Use MICRO UINT_MAX instead of actual value

On 04/25/16 at 12:44P, Sagi Grimberg wrote:
>
> >It's more elegant to use MICRO UINT_MAX to represent the max value of
> >type unsigned int. So replace the actual value by using this MICRO.
>
> You mean macro right?

Yep. Sorry for the typo error.

Thanks
Minfei

2016-04-30 10:13:10

by Minfei Huang

Subject: Re: [PATCH] Use MICRO UINT_MAX instead of actual value

Ping.

Any comment is appreciate.

Thanks
Minfei

On 04/25/16 at 11:13P, Minfei Huang wrote:
> It's more elegant to use MICRO UINT_MAX to represent the max value of
> type unsigned int. So replace the actual value by using this MICRO.
>
> Signed-off-by: Minfei Huang <[email protected]>
> ---
> drivers/nvme/host/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
> index 643f457..2c0bb13 100644
> --- a/drivers/nvme/host/core.c
> +++ b/drivers/nvme/host/core.c
> @@ -597,7 +597,7 @@ static void nvme_config_discard(struct nvme_ns *ns)
>
> ns->queue->limits.discard_alignment = logical_block_size;
> ns->queue->limits.discard_granularity = logical_block_size;
> - blk_queue_max_discard_sectors(ns->queue, 0xffffffff);
> + blk_queue_max_discard_sectors(ns->queue, UINT_MAX);
> queue_flag_set_unlocked(QUEUE_FLAG_DISCARD, ns->queue);
> }
>
> --
> 2.6.3
>