2016-04-28 12:43:58

by Peter Ujfalusi

[permalink] [raw]

Subject: [PATCH] Revert "drm/omap: no need to select OMAP2_DSS"

---

This reverts commit 1c278e5e3718d15475ec08ee2135f37a6b13361c.

If DRM_OMAP does not select OMAP2_DSS it is possible to build a kernel with
DRM_OMAP only and not selecting OMAP2_DSS. Since omapdrm depends on
OMAP2_DSS this will result on broken kernel build.

Signed-off-by: Peter Ujfalusi <[email protected]>
---
drivers/gpu/drm/omapdrm/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/omapdrm/Kconfig b/drivers/gpu/drm/omapdrm/Kconfig
index 73241c4eb7aa..336ad4de9981 100644
--- a/drivers/gpu/drm/omapdrm/Kconfig
+++ b/drivers/gpu/drm/omapdrm/Kconfig
@@ -2,6 +2,7 @@ config DRM_OMAP
tristate "OMAP DRM"
depends on DRM
depends on ARCH_OMAP2PLUS || ARCH_MULTIPLATFORM
+ select OMAP2_DSS
select DRM_KMS_HELPER
select DRM_KMS_FB_HELPER
select FB_SYS_FILLRECT
--
2.8.1

2016-04-29 12:18:11

by Tomi Valkeinen

[permalink] [raw]

Subject: Re: [PATCH] Revert "drm/omap: no need to select OMAP2_DSS"

---

On 28/04/16 15:42, Peter Ujfalusi wrote:
> This reverts commit 1c278e5e3718d15475ec08ee2135f37a6b13361c.
>
> If DRM_OMAP does not select OMAP2_DSS it is possible to build a kernel with
> DRM_OMAP only and not selecting OMAP2_DSS. Since omapdrm depends on
> OMAP2_DSS this will result on broken kernel build.
>
> Signed-off-by: Peter Ujfalusi <[email protected]>
> ---
> drivers/gpu/drm/omapdrm/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/omapdrm/Kconfig b/drivers/gpu/drm/omapdrm/Kconfig
> index 73241c4eb7aa..336ad4de9981 100644
> --- a/drivers/gpu/drm/omapdrm/Kconfig
> +++ b/drivers/gpu/drm/omapdrm/Kconfig
> @@ -2,6 +2,7 @@ config DRM_OMAP
> tristate "OMAP DRM"
> depends on DRM
> depends on ARCH_OMAP2PLUS || ARCH_MULTIPLATFORM
> + select OMAP2_DSS
> select DRM_KMS_HELPER
> select DRM_KMS_FB_HELPER
> select FB_SYS_FILLRECT
>

Thanks, queued for 4.7.

Tomi

---

Attachments:

signature.asc (819.00 B)
OpenPGP digital signature