2023-02-22 07:58:17

by Thorsten Leemhuis

[permalink] [raw]
Subject: [regression] Bug 217069 - Wake on Lan is broken on r8169 since 6.2

Hi, this is your Linux kernel regression tracker.

I noticed a regression report in bugzilla.kernel.org. As many (most?)
kernel developer don't keep an eye on it, I decided to forward it by
mail. Quoting from https://bugzilla.kernel.org/show_bug.cgi?id=217069 :

> Ivan Ivanich 2023-02-22 00:51:52 UTC
>
> After upgrade to 6.2 having issues with wake on lan on 2 systems: -
> first is an old lenovo laptop from 2012(Ivy Bridge) with realtek
> network adapter - second is a PC(Haswell refresh) with PCIE realtek
> network adapter
>
> Both uses r8169 driver for network.
>
> On laptop it's not possible to wake on lan after poweroff On PC it's
> not possible to wake on lan up after hibernate but works after
> poweroff
>
> In both cases downgrade to 6.1.x kernel fixes the issue.

See the ticket for more details.

@Ivan: maybe someone that sees this mail might have an idea what's
wrong. But if not, you likely need to run a bisection to find what's
causing this.

[TLDR for the rest of this mail: I'm adding this report to the list of
tracked Linux kernel regressions; the text you find below is based on a
few templates paragraphs you might have encountered already in similar
form.]

BTW, let me use this mail to also add the report to the list of tracked
regressions to ensure it's doesn't fall through the cracks:

#regzbot introduced: v6.1..v6.2
https://bugzilla.kernel.org/show_bug.cgi?id=217069
#regzbot title: net/r8169: Wake/power on Lan is broken on two machines
#regzbot ignore-activity

This isn't a regression? This issue or a fix for it are already
discussed somewhere else? It was fixed already? You want to clarify when
the regression started to happen? Or point out I got the title or
something else totally wrong? Then just reply and tell me -- ideally
while also telling regzbot about it, as explained by the page listed in
the footer of this mail.

Developers: When fixing the issue, remember to add 'Link:' tags pointing
to the report (e.g. the buzgzilla ticket and maybe this mail as well, if
this thread sees some discussion). See page linked in footer for details.

Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
--
Everything you wanna know about Linux kernel regression tracking:
https://linux-regtracking.leemhuis.info/about/#tldr
If I did something stupid, please tell me, as explained on that page.


2023-03-16 13:22:03

by Thorsten Leemhuis

[permalink] [raw]
Subject: Re: [regression] Bug 217069 - Wake on Lan is broken on r8169 since 6.2

[Quick inquiry with different recipients]

> I noticed a regression report in bugzilla.kernel.org. As many (most?)
> kernel developer don't keep an eye on it, I decided to forward it by
> mail. Quoting from https://bugzilla.kernel.org/show_bug.cgi?id=217069 :

To Rafael and the ACPI & PM folks as well as to Bjorn and the PCI folks:

Three users reported that WOL/Wake on Lan broke for them with 6.2; two
of them have Realtek chips, one an Intel NIC. For details see the bug
linked above.

Did something in ACPI/PM/PCI land change for 6.2 that might cause
something like this? Or is such a problem even known already?

Just fishing for ideas here. If nobody has any, one of the reports will
have to bisect this.

Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
--
Everything you wanna know about Linux kernel regression tracking:
https://linux-regtracking.leemhuis.info/about/#tldr
If I did something stupid, please tell me, as explained on that page.


2023-03-19 07:16:33

by Thorsten Leemhuis

[permalink] [raw]
Subject: Re: [regression] Bug 217069 - Wake on Lan is broken on r8169 since 6.2

On 22.02.23 08:57, Thorsten Leemhuis wrote:
> Hi, this is your Linux kernel regression tracker.
>
> I noticed a regression report in bugzilla.kernel.org. As many (most?)
> kernel developer don't keep an eye on it, I decided to forward it by
> mail. Quoting from https://bugzilla.kernel.org/show_bug.cgi?id=217069 :
>
>> Ivan Ivanich 2023-02-22 00:51:52 UTC
>>
>> After upgrade to 6.2 having issues with wake on lan on 2 systems: -
>> first is an old lenovo laptop from 2012(Ivy Bridge) with realtek
>> network adapter - second is a PC(Haswell refresh) with PCIE realtek
>> network adapter
>>
>> Both uses r8169 driver for network.
>>
>> On laptop it's not possible to wake on lan after poweroff On PC it's
>> not possible to wake on lan up after hibernate but works after
>> poweroff
>>
>> In both cases downgrade to 6.1.x kernel fixes the issue.
>
> See the ticket for more details.

JFYI: turns out this is not a network bug, as the issue was bisected to
5c62d5aab875 ("ACPICA: Events: Support fixed PCIe wake event"). The
ticket linked above has the details.

#regzbot introduced: 5c62d5aab875
#regzbot ignore-activity

Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
--
Everything you wanna know about Linux kernel regression tracking:
https://linux-regtracking.leemhuis.info/about/#tldr
If I did something stupid, please tell me, as explained on that page.

2023-03-19 07:21:17

by Thorsten Leemhuis

[permalink] [raw]
Subject: Re: [regression] Bug 217069 - Wake on Lan is broken on r8169 since 6.2

Hi, Thorsten here, the Linux kernel's regression tracker.

On 22.02.23 08:57, Thorsten Leemhuis wrote:
>
> I noticed a regression report in bugzilla.kernel.org. As many (most?)
> kernel developer don't keep an eye on it, I decided to forward it by
> mail. Quoting from https://bugzilla.kernel.org/show_bug.cgi?id=217069 :

An issue that looked like a network bug was now bisected and it turns
out it's cause by 5c62d5aab875 ("ACPICA: Events: Support fixed PCIe wake
event") which Huacai Chen provided. Could you take a look at the ticket
linked above?

FWIW, the whole story started like this:

>> Ivan Ivanich 2023-02-22 00:51:52 UTC
>>
>> After upgrade to 6.2 having issues with wake on lan on 2 systems: -
>> first is an old lenovo laptop from 2012(Ivy Bridge) with realtek
>> network adapter - second is a PC(Haswell refresh) with PCIE realtek
>> network adapter
>>
>> Both uses r8169 driver for network.
>>
>> On laptop it's not possible to wake on lan after poweroff On PC it's
>> not possible to wake on lan up after hibernate but works after
>> poweroff
>>
>> In both cases downgrade to 6.1.x kernel fixes the issue.

Meanwhile a few others that ran into the same problem with NICs from
different vendors joined the ticket

Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
--
Everything you wanna know about Linux kernel regression tracking:
https://linux-regtracking.leemhuis.info/about/#tldr
If I did something stupid, please tell me, as explained on that page.

2023-03-24 09:49:21

by Thorsten Leemhuis

[permalink] [raw]
Subject: Re: [regression] Bug 217069 - Wake on Lan is broken on r8169 since 6.2

On 19.03.23 08:20, Linux regression tracking (Thorsten Leemhuis) wrote:
> Hi, Thorsten here, the Linux kernel's regression tracker.
>
> On 22.02.23 08:57, Thorsten Leemhuis wrote:
>>
>> I noticed a regression report in bugzilla.kernel.org. As many (most?)
>> kernel developer don't keep an eye on it, I decided to forward it by
>> mail. Quoting from https://bugzilla.kernel.org/show_bug.cgi?id=217069 :
>
> An issue that looked like a network bug was now bisected and it turns
> out it's cause by 5c62d5aab875 ("ACPICA: Events: Support fixed PCIe wake
> event") which Huacai Chen provided. Could you take a look at the ticket
> linked above?

Huacai Chen, did you look into this? Would be good to have this
regression fixed rather sooner than later, as it seems to annoy quite a
few people.

Should we maybe simply revert the problematic change for now and reapply
it later once the root-issue was found and fixed?

Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
--
Everything you wanna know about Linux kernel regression tracking:
https://linux-regtracking.leemhuis.info/about/#tldr
If I did something stupid, please tell me, as explained on that page.

#regzbot poke

> FWIW, the whole story started like this:
>
>>> Ivan Ivanich 2023-02-22 00:51:52 UTC
>>>
>>> After upgrade to 6.2 having issues with wake on lan on 2 systems: -
>>> first is an old lenovo laptop from 2012(Ivy Bridge) with realtek
>>> network adapter - second is a PC(Haswell refresh) with PCIE realtek
>>> network adapter
>>>
>>> Both uses r8169 driver for network.
>>>
>>> On laptop it's not possible to wake on lan after poweroff On PC it's
>>> not possible to wake on lan up after hibernate but works after
>>> poweroff
>>>
>>> In both cases downgrade to 6.1.x kernel fixes the issue.
>
> Meanwhile a few others that ran into the same problem with NICs from
> different vendors joined the ticket
>
> Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
> --
> Everything you wanna know about Linux kernel regression tracking:
> https://linux-regtracking.leemhuis.info/about/#tldr
> If I did something stupid, please tell me, as explained on that page.

2023-03-24 09:50:56

by Huacai Chen

[permalink] [raw]
Subject: Re: [regression] Bug 217069 - Wake on Lan is broken on r8169 since 6.2

Hi, Thorsten,

I'm sorry I ignored this email, and Jianmin, could you please
investigate this problem? Thank you.

Huacai

On Fri, Mar 24, 2023 at 5:46 PM Thorsten Leemhuis
<[email protected]> wrote:
>
> On 19.03.23 08:20, Linux regression tracking (Thorsten Leemhuis) wrote:
> > Hi, Thorsten here, the Linux kernel's regression tracker.
> >
> > On 22.02.23 08:57, Thorsten Leemhuis wrote:
> >>
> >> I noticed a regression report in bugzilla.kernel.org. As many (most?)
> >> kernel developer don't keep an eye on it, I decided to forward it by
> >> mail. Quoting from https://bugzilla.kernel.org/show_bug.cgi?id=217069 :
> >
> > An issue that looked like a network bug was now bisected and it turns
> > out it's cause by 5c62d5aab875 ("ACPICA: Events: Support fixed PCIe wake
> > event") which Huacai Chen provided. Could you take a look at the ticket
> > linked above?
>
> Huacai Chen, did you look into this? Would be good to have this
> regression fixed rather sooner than later, as it seems to annoy quite a
> few people.
>
> Should we maybe simply revert the problematic change for now and reapply
> it later once the root-issue was found and fixed?
>
> Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
> --
> Everything you wanna know about Linux kernel regression tracking:
> https://linux-regtracking.leemhuis.info/about/#tldr
> If I did something stupid, please tell me, as explained on that page.
>
> #regzbot poke
>
> > FWIW, the whole story started like this:
> >
> >>> Ivan Ivanich 2023-02-22 00:51:52 UTC
> >>>
> >>> After upgrade to 6.2 having issues with wake on lan on 2 systems: -
> >>> first is an old lenovo laptop from 2012(Ivy Bridge) with realtek
> >>> network adapter - second is a PC(Haswell refresh) with PCIE realtek
> >>> network adapter
> >>>
> >>> Both uses r8169 driver for network.
> >>>
> >>> On laptop it's not possible to wake on lan after poweroff On PC it's
> >>> not possible to wake on lan up after hibernate but works after
> >>> poweroff
> >>>
> >>> In both cases downgrade to 6.1.x kernel fixes the issue.
> >
> > Meanwhile a few others that ran into the same problem with NICs from
> > different vendors joined the ticket
> >
> > Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
> > --
> > Everything you wanna know about Linux kernel regression tracking:
> > https://linux-regtracking.leemhuis.info/about/#tldr
> > If I did something stupid, please tell me, as explained on that page.

2023-03-24 10:11:22

by 吕建民

[permalink] [raw]
Subject: Re: [regression] Bug 217069 - Wake on Lan is broken on r8169 since 6.2

Please try the following patch:

https://github.com/acpica/acpica/pull/784/commits/0e66e6aae972dac3833bdcbd223aa6a8b1733176


On 2023/3/24 下午5:50, Huacai Chen wrote:
> Hi, Thorsten,
>
> I'm sorry I ignored this email, and Jianmin, could you please
> investigate this problem? Thank you.
>
> Huacai
>
> On Fri, Mar 24, 2023 at 5:46 PM Thorsten Leemhuis
> <[email protected]> wrote:
>>
>> On 19.03.23 08:20, Linux regression tracking (Thorsten Leemhuis) wrote:
>>> Hi, Thorsten here, the Linux kernel's regression tracker.
>>>
>>> On 22.02.23 08:57, Thorsten Leemhuis wrote:
>>>>
>>>> I noticed a regression report in bugzilla.kernel.org. As many (most?)
>>>> kernel developer don't keep an eye on it, I decided to forward it by
>>>> mail. Quoting from https://bugzilla.kernel.org/show_bug.cgi?id=217069 :
>>>
>>> An issue that looked like a network bug was now bisected and it turns
>>> out it's cause by 5c62d5aab875 ("ACPICA: Events: Support fixed PCIe wake
>>> event") which Huacai Chen provided. Could you take a look at the ticket
>>> linked above?
>>
>> Huacai Chen, did you look into this? Would be good to have this
>> regression fixed rather sooner than later, as it seems to annoy quite a
>> few people.
>>
>> Should we maybe simply revert the problematic change for now and reapply
>> it later once the root-issue was found and fixed?
>>
>> Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
>> --
>> Everything you wanna know about Linux kernel regression tracking:
>> https://linux-regtracking.leemhuis.info/about/#tldr
>> If I did something stupid, please tell me, as explained on that page.
>>
>> #regzbot poke
>>
>>> FWIW, the whole story started like this:
>>>
>>>>> Ivan Ivanich 2023-02-22 00:51:52 UTC
>>>>>
>>>>> After upgrade to 6.2 having issues with wake on lan on 2 systems: -
>>>>> first is an old lenovo laptop from 2012(Ivy Bridge) with realtek
>>>>> network adapter - second is a PC(Haswell refresh) with PCIE realtek
>>>>> network adapter
>>>>>
>>>>> Both uses r8169 driver for network.
>>>>>
>>>>> On laptop it's not possible to wake on lan after poweroff On PC it's
>>>>> not possible to wake on lan up after hibernate but works after
>>>>> poweroff
>>>>>
>>>>> In both cases downgrade to 6.1.x kernel fixes the issue.
>>>
>>> Meanwhile a few others that ran into the same problem with NICs from
>>> different vendors joined the ticket
>>>
>>> Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
>>> --
>>> Everything you wanna know about Linux kernel regression tracking:
>>> https://linux-regtracking.leemhuis.info/about/#tldr
>>> If I did something stupid, please tell me, as explained on that page.

2023-03-25 13:46:32

by Thorsten Leemhuis

[permalink] [raw]
Subject: Re: [regression] Bug 217069 - Wake on Lan is broken on r8169 since 6.2

On 24.03.23 11:09, Jianmin Lv wrote:
> Please try the following patch:
> https://github.com/acpica/acpica/pull/784/commits/0e66e6aae972dac3833bdcbd223aa6a8b1733176

To interact with the reporters, please comment here:
https://bugzilla.kernel.org/show_bug.cgi?id=217069

Sorry, I wish it was different, but I can't CC the reporters here
without their permission, because bugzilla.kernel.org tells users upon
registration their "email address will never be displayed to logged out
users".

FWIW, I forwarded your request yesterday and one reporter commented that
it didn't help. But having me as a man-in-the-middle is not a good idea.

Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
--
Everything you wanna know about Linux kernel regression tracking:
https://linux-regtracking.leemhuis.info/about/#tldr
If I did something stupid, please tell me, as explained on that page.

> On 2023/3/24 下午5:50, Huacai Chen wrote:
>> Hi, Thorsten,
>>
>> I'm sorry I ignored this email, and Jianmin, could you please
>> investigate this problem? Thank you.
>>
>> Huacai
>>
>> On Fri, Mar 24, 2023 at 5:46 PM Thorsten Leemhuis
>> <[email protected]> wrote:
>>>
>>> On 19.03.23 08:20, Linux regression tracking (Thorsten Leemhuis) wrote:
>>>> Hi, Thorsten here, the Linux kernel's regression tracker.
>>>>
>>>> On 22.02.23 08:57, Thorsten Leemhuis wrote:
>>>>>
>>>>> I noticed a regression report in bugzilla.kernel.org. As many (most?)
>>>>> kernel developer don't keep an eye on it, I decided to forward it by
>>>>> mail. Quoting from
>>>>> https://bugzilla.kernel.org/show_bug.cgi?id=217069 :
>>>>
>>>> An issue that looked like a network bug was now bisected and it turns
>>>> out it's cause by 5c62d5aab875 ("ACPICA: Events: Support fixed PCIe
>>>> wake
>>>> event") which Huacai Chen provided. Could you take a look at the ticket
>>>> linked above?
>>>
>>> Huacai Chen, did you look into this? Would be good to have this
>>> regression fixed rather sooner than later, as it seems to annoy quite a
>>> few people.
>>>
>>> Should we maybe simply revert the problematic change for now and reapply
>>> it later once the root-issue was found and fixed?
>>>
>>> Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
>>> --
>>> Everything you wanna know about Linux kernel regression tracking:
>>> https://linux-regtracking.leemhuis.info/about/#tldr
>>> If I did something stupid, please tell me, as explained on that page.
>>>
>>> #regzbot poke
>>>
>>>> FWIW, the whole story started like this:
>>>>
>>>>>> Ivan Ivanich 2023-02-22 00:51:52 UTC
>>>>>>
>>>>>> After upgrade to 6.2 having issues with wake on lan on 2 systems: -
>>>>>> first is an old lenovo laptop from 2012(Ivy Bridge) with realtek
>>>>>> network adapter - second is a PC(Haswell refresh) with PCIE realtek
>>>>>> network adapter
>>>>>>
>>>>>> Both uses r8169 driver for network.
>>>>>>
>>>>>> On laptop it's not possible to wake on lan after poweroff On PC it's
>>>>>> not possible to wake on lan up after hibernate but works after
>>>>>> poweroff
>>>>>>
>>>>>> In both cases downgrade to 6.1.x kernel fixes the issue.
>>>>
>>>> Meanwhile a few others that ran into the same problem with NICs from
>>>> different vendors joined the ticket
>>>>
>>>> Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker'
>>>> hat)
>>>> --
>>>> Everything you wanna know about Linux kernel regression tracking:
>>>> https://linux-regtracking.leemhuis.info/about/#tldr
>>>> If I did something stupid, please tell me, as explained on that page.
>
>
>

2023-03-27 08:08:50

by 吕建民

[permalink] [raw]
Subject: Re: [regression] Bug 217069 - Wake on Lan is broken on r8169 since 6.2



On 2023/3/25 下午9:31, Linux regression tracking (Thorsten Leemhuis) wrote:
> On 24.03.23 11:09, Jianmin Lv wrote:
>> Please try the following patch:
>> https://github.com/acpica/acpica/pull/784/commits/0e66e6aae972dac3833bdcbd223aa6a8b1733176
>
> To interact with the reporters, please comment here:
> https://bugzilla.kernel.org/show_bug.cgi?id=217069
>
> Sorry, I wish it was different, but I can't CC the reporters here
> without their permission, because bugzilla.kernel.org tells users upon
> registration their "email address will never be displayed to logged out
> users".
>
> FWIW, I forwarded your request yesterday and one reporter commented that
> it didn't help. But having me as a man-in-the-middle is not a good idea.
>

Ok, I has transformed and adjusted the patch from ACPICA and post it
into https://bugzilla.kernel.org/show_bug.cgi?id=217069.

Thanks!

> Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
> --
> Everything you wanna know about Linux kernel regression tracking:
> https://linux-regtracking.leemhuis.info/about/#tldr
> If I did something stupid, please tell me, as explained on that page.
>
>> On 2023/3/24 下午5:50, Huacai Chen wrote:
>>> Hi, Thorsten,
>>>
>>> I'm sorry I ignored this email, and Jianmin, could you please
>>> investigate this problem? Thank you.
>>>
>>> Huacai
>>>
>>> On Fri, Mar 24, 2023 at 5:46 PM Thorsten Leemhuis
>>> <[email protected]> wrote:
>>>>
>>>> On 19.03.23 08:20, Linux regression tracking (Thorsten Leemhuis) wrote:
>>>>> Hi, Thorsten here, the Linux kernel's regression tracker.
>>>>>
>>>>> On 22.02.23 08:57, Thorsten Leemhuis wrote:
>>>>>>
>>>>>> I noticed a regression report in bugzilla.kernel.org. As many (most?)
>>>>>> kernel developer don't keep an eye on it, I decided to forward it by
>>>>>> mail. Quoting from
>>>>>> https://bugzilla.kernel.org/show_bug.cgi?id=217069 :
>>>>>
>>>>> An issue that looked like a network bug was now bisected and it turns
>>>>> out it's cause by 5c62d5aab875 ("ACPICA: Events: Support fixed PCIe
>>>>> wake
>>>>> event") which Huacai Chen provided. Could you take a look at the ticket
>>>>> linked above?
>>>>
>>>> Huacai Chen, did you look into this? Would be good to have this
>>>> regression fixed rather sooner than later, as it seems to annoy quite a
>>>> few people.
>>>>
>>>> Should we maybe simply revert the problematic change for now and reapply
>>>> it later once the root-issue was found and fixed?
>>>>
>>>> Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
>>>> --
>>>> Everything you wanna know about Linux kernel regression tracking:
>>>> https://linux-regtracking.leemhuis.info/about/#tldr
>>>> If I did something stupid, please tell me, as explained on that page.
>>>>
>>>> #regzbot poke
>>>>
>>>>> FWIW, the whole story started like this:
>>>>>
>>>>>>> Ivan Ivanich 2023-02-22 00:51:52 UTC
>>>>>>>
>>>>>>> After upgrade to 6.2 having issues with wake on lan on 2 systems: -
>>>>>>> first is an old lenovo laptop from 2012(Ivy Bridge) with realtek
>>>>>>> network adapter - second is a PC(Haswell refresh) with PCIE realtek
>>>>>>> network adapter
>>>>>>>
>>>>>>> Both uses r8169 driver for network.
>>>>>>>
>>>>>>> On laptop it's not possible to wake on lan after poweroff On PC it's
>>>>>>> not possible to wake on lan up after hibernate but works after
>>>>>>> poweroff
>>>>>>>
>>>>>>> In both cases downgrade to 6.1.x kernel fixes the issue.
>>>>>
>>>>> Meanwhile a few others that ran into the same problem with NICs from
>>>>> different vendors joined the ticket
>>>>>
>>>>> Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker'
>>>>> hat)
>>>>> --
>>>>> Everything you wanna know about Linux kernel regression tracking:
>>>>> https://linux-regtracking.leemhuis.info/about/#tldr
>>>>> If I did something stupid, please tell me, as explained on that page.
>>
>>
>>

2023-04-14 12:57:25

by Thorsten Leemhuis

[permalink] [raw]
Subject: Re: [regression] Bug 217069 - Wake on Lan is broken on r8169 since 6.2

On 19.03.23 08:20, Linux regression tracking (Thorsten Leemhuis) wrote:
> On 22.02.23 08:57, Thorsten Leemhuis wrote:
>>
>> I noticed a regression report in bugzilla.kernel.org. As many (most?)
>> kernel developer don't keep an eye on it, I decided to forward it by
>> mail. Quoting from https://bugzilla.kernel.org/show_bug.cgi?id=217069 :
>
> An issue that looked like a network bug was now bisected and it turns
> out it's cause by 5c62d5aab875 ("ACPICA: Events: Support fixed PCIe wake
> event") which Huacai Chen provided. Could you take a look at the ticket
> linked above?

Jianmin did get close to a proper fix a while ago
(https://bugzilla.kernel.org/show_bug.cgi?id=217069#c46 ), but it
appears there wasn't any progress to fix this during the last week. Or
did I miss it?

This is kinda unsatisfying, as the culprit is now known for nearly four
weeks; especially as this is a issue that is present in 6.2 since it was
released and would have been possible to fix there and in mainline with
a simple revert. We even got close to one two weeks ago already
(https://bugzilla.kernel.org/show_bug.cgi?id=217069#c49 ).

#sigh

I'd say we should revert this. Rafael, what's your opinion here?

Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
--
Everything you wanna know about Linux kernel regression tracking:
https://linux-regtracking.leemhuis.info/about/#tldr
If I did something stupid, please tell me, as explained on that page.

#regzbot poke

2023-04-16 12:37:31

by 吕建民

[permalink] [raw]
Subject: Re: [regression] Bug 217069 - Wake on Lan is broken on r8169 since 6.2

From the feedbacks, the WOL issue has been fixed, and I have submitted
a fixed patch to ACPICA, which has been reviewing in last week (Rafael
also looked into the fixed patch).

There are two kinds of issues in the bug, one is WOL failed in kexec
reboot, another is WOL failed in cold reboot. The former one still exist
after reverted patch(5c62d5aab8752e5ee7bfbe75ed6060db1c787f98),
so this issue is not caused by the reverted patch. The second is caused
by the reverted patch, and has been fixed with my provided patch.

Please see:
https://bugzilla.kernel.org/show_bug.cgi?id=217069#c54
https://bugzilla.kernel.org/show_bug.cgi?id=217069#c59

Thanks.


On 2023/4/14 下午8:48, Thorsten Leemhuis wrote:
> On 19.03.23 08:20, Linux regression tracking (Thorsten Leemhuis) wrote:
>> On 22.02.23 08:57, Thorsten Leemhuis wrote:
>>>
>>> I noticed a regression report in bugzilla.kernel.org. As many (most?)
>>> kernel developer don't keep an eye on it, I decided to forward it by
>>> mail. Quoting from https://bugzilla.kernel.org/show_bug.cgi?id=217069 :
>>
>> An issue that looked like a network bug was now bisected and it turns
>> out it's cause by 5c62d5aab875 ("ACPICA: Events: Support fixed PCIe wake
>> event") which Huacai Chen provided. Could you take a look at the ticket
>> linked above?
>
> Jianmin did get close to a proper fix a while ago
> (https://bugzilla.kernel.org/show_bug.cgi?id=217069#c46 ), but it
> appears there wasn't any progress to fix this during the last week. Or
> did I miss it?
>
> This is kinda unsatisfying, as the culprit is now known for nearly four
> weeks; especially as this is a issue that is present in 6.2 since it was
> released and would have been possible to fix there and in mainline with
> a simple revert. We even got close to one two weeks ago already
> (https://bugzilla.kernel.org/show_bug.cgi?id=217069#c49 ).
>
> #sigh
>
> I'd say we should revert this. Rafael, what's your opinion here?
>
> Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
> --
> Everything you wanna know about Linux kernel regression tracking:
> https://linux-regtracking.leemhuis.info/about/#tldr
> If I did something stupid, please tell me, as explained on that page.
>
> #regzbot poke
>

2023-04-16 13:08:35

by Thorsten Leemhuis

[permalink] [raw]
Subject: Re: [regression] Bug 217069 - Wake on Lan is broken on r8169 since 6.2

On 16.04.23 14:35, Jianmin Lv wrote:
> From the feedbacks, the WOL issue has been fixed, and I have submitted a
> fixed patch to ACPICA, which has been reviewing in last week (Rafael
> also looked into the fixed patch).

Great, many thx. I looked for something like that, but failed to find it.

FWIW, a link to the patch submission would have been nice. I tried to
find it just now, but maybe it's not on lore.kernel.org or I did
something stupid. And
https://lists.linuxfoundation.org/pipermail/acpica-devel/ seems to lack
behind or might not be the list you submitted the patch to. Whatever.

> There are two kinds of issues in the bug, one is WOL failed in kexec
> reboot, another is WOL failed in cold reboot. The former one still exist
> after reverted patch(5c62d5aab8752e5ee7bfbe75ed6060db1c787f98),
> so this issue is not caused by the reverted patch. The second is caused
> by the reverted patch, and has been fixed with my provided patch.
>
> Please see:
> https://bugzilla.kernel.org/show_bug.cgi?id=217069#c54
> https://bugzilla.kernel.org/show_bug.cgi?id=217069#c59

I'll post a quick update there.

Thx again.

Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
--
Everything you wanna know about Linux kernel regression tracking:
https://linux-regtracking.leemhuis.info/about/#tldr
If I did something stupid, please tell me, as explained on that page.

> On 2023/4/14 下午8:48, Thorsten Leemhuis wrote:
>> On 19.03.23 08:20, Linux regression tracking (Thorsten Leemhuis) wrote:
>>> On 22.02.23 08:57, Thorsten Leemhuis wrote:
>>>>
>>>> I noticed a regression report in bugzilla.kernel.org. As many (most?)
>>>> kernel developer don't keep an eye on it, I decided to forward it by
>>>> mail. Quoting from https://bugzilla.kernel.org/show_bug.cgi?id=217069 :
>>>
>>> An issue that looked like a network bug was now bisected and it turns
>>> out it's cause by 5c62d5aab875 ("ACPICA: Events: Support fixed PCIe wake
>>> event") which Huacai Chen provided. Could you take a look at the ticket
>>> linked above?
>>
>> Jianmin did get close to a proper fix a while ago
>> (https://bugzilla.kernel.org/show_bug.cgi?id=217069#c46 ), but it
>> appears there wasn't any progress to fix this during the last week. Or
>> did I miss it?
>>
>> This is kinda unsatisfying, as the culprit is now known for nearly four
>> weeks; especially as this is a issue that is present in 6.2 since it was
>> released and would have been possible to fix there and in mainline with
>> a simple revert. We even got close to one two weeks ago already
>> (https://bugzilla.kernel.org/show_bug.cgi?id=217069#c49 ).
>>
>> #sigh
>>
>> I'd say we should revert this. Rafael, what's your opinion here?
>>
>> Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
>> --
>> Everything you wanna know about Linux kernel regression tracking:
>> https://linux-regtracking.leemhuis.info/about/#tldr
>> If I did something stupid, please tell me, as explained on that page.
>>
>> #regzbot poke
>>
>
>
>

2023-04-17 00:57:01

by 吕建民

[permalink] [raw]
Subject: Re: [regression] Bug 217069 - Wake on Lan is broken on r8169 since 6.2



On 2023/4/16 下午8:52, Linux regression tracking (Thorsten Leemhuis) wrote:
> On 16.04.23 14:35, Jianmin Lv wrote:
>> From the feedbacks, the WOL issue has been fixed, and I have submitted a
>> fixed patch to ACPICA, which has been reviewing in last week (Rafael
>> also looked into the fixed patch).
>
> Great, many thx. I looked for something like that, but failed to find it.
>
> FWIW, a link to the patch submission would have been nice. I tried to
> find it just now, but maybe it's not on lore.kernel.org or I did
> something stupid. And
> https://lists.linuxfoundation.org/pipermail/acpica-devel/ seems to lack
> behind or might not be the list you submitted the patch to. Whatever.
>
The link is here: https://github.com/acpica/acpica/pull/866

>> There are two kinds of issues in the bug, one is WOL failed in kexec
>> reboot, another is WOL failed in cold reboot. The former one still exist
>> after reverted patch(5c62d5aab8752e5ee7bfbe75ed6060db1c787f98),
>> so this issue is not caused by the reverted patch. The second is caused
>> by the reverted patch, and has been fixed with my provided patch.
>>
>> Please see:
>> https://bugzilla.kernel.org/show_bug.cgi?id=217069#c54
>> https://bugzilla.kernel.org/show_bug.cgi?id=217069#c59
>
> I'll post a quick update there.
>
> Thx again.
>
> Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
> --
> Everything you wanna know about Linux kernel regression tracking:
> https://linux-regtracking.leemhuis.info/about/#tldr
> If I did something stupid, please tell me, as explained on that page.
>
>> On 2023/4/14 下午8:48, Thorsten Leemhuis wrote:
>>> On 19.03.23 08:20, Linux regression tracking (Thorsten Leemhuis) wrote:
>>>> On 22.02.23 08:57, Thorsten Leemhuis wrote:
>>>>>
>>>>> I noticed a regression report in bugzilla.kernel.org. As many (most?)
>>>>> kernel developer don't keep an eye on it, I decided to forward it by
>>>>> mail. Quoting from https://bugzilla.kernel.org/show_bug.cgi?id=217069 :
>>>>
>>>> An issue that looked like a network bug was now bisected and it turns
>>>> out it's cause by 5c62d5aab875 ("ACPICA: Events: Support fixed PCIe wake
>>>> event") which Huacai Chen provided. Could you take a look at the ticket
>>>> linked above?
>>>
>>> Jianmin did get close to a proper fix a while ago
>>> (https://bugzilla.kernel.org/show_bug.cgi?id=217069#c46 ), but it
>>> appears there wasn't any progress to fix this during the last week. Or
>>> did I miss it?
>>>
>>> This is kinda unsatisfying, as the culprit is now known for nearly four
>>> weeks; especially as this is a issue that is present in 6.2 since it was
>>> released and would have been possible to fix there and in mainline with
>>> a simple revert. We even got close to one two weeks ago already
>>> (https://bugzilla.kernel.org/show_bug.cgi?id=217069#c49 ).
>>>
>>> #sigh
>>>
>>> I'd say we should revert this. Rafael, what's your opinion here?
>>>
>>> Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
>>> --
>>> Everything you wanna know about Linux kernel regression tracking:
>>> https://linux-regtracking.leemhuis.info/about/#tldr
>>> If I did something stupid, please tell me, as explained on that page.
>>>
>>> #regzbot poke
>>>
>>
>>
>>