2017-06-20 13:24:02

by Christoph Hellwig

Subject: Re: [PATCH v5 1/7] dma: Take into account dma_pfn_offset

> - sg_dma_address(sg) = (dma_addr_t)virt_to_phys(va);
> + sg_dma_address(sg) = (dma_addr_t)(virt_to_phys(va) - PFN_PHYS(dev->dma_pfn_offset));

Needs a line break instead of the overly long line.

Otherwise this looks fine to me.

2017-06-22 12:47:07

by Vladimir Murzin

Subject: Re: [PATCH v5 1/7] dma: Take into account dma_pfn_offset

On 20/06/17 14:24, Christoph Hellwig wrote:
>> - sg_dma_address(sg) = (dma_addr_t)virt_to_phys(va);
>> + sg_dma_address(sg) = (dma_addr_t)(virt_to_phys(va) - PFN_PHYS(dev->dma_pfn_offset));
>
> Needs a line break instead of the overly long line.

Will do.

>
> Otherwise this looks fine to me.
>

Thanks
Vladimir