2017-11-13 13:17:20

by Andrew Lunn

[permalink] [raw]
Subject: Re: [PATCH net-next 2/2] net: dsa: lan9303: Clear offload_fwd_mark for IGMP

> RTFM, my bad. The lan9303 has both STP and IGMP bits in the receive tag. It
> is as simple as:
>
> u16 lan9303_tag1 = ntohs(lan9303_tag[1]);
> skb->offload_fwd_mark = !(lan9303_tag1 & 0x18);

Hi Egil

That is much nicer. But please add a couple of #defines for the 0x18
bits.

Andrew

From 1583956334517218411@xxx Mon Nov 13 13:07:54 +0000 2017
X-GM-THRID: 1583680264397303225
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread


2017-11-13 13:07:55

by Egil Hjelmeland

[permalink] [raw]
Subject: Re: [PATCH net-next 2/2] net: dsa: lan9303: Clear offload_fwd_mark for IGMP

On 13. nov. 2017 14:02, Andrew Lunn wrote:
>> RTFM, my bad. The lan9303 has both STP and IGMP bits in the receive tag. It
>> is as simple as:
>>
>> u16 lan9303_tag1 = ntohs(lan9303_tag[1]);
>> skb->offload_fwd_mark = !(lan9303_tag1 & 0x18);
>
> Hi Egil
>
> That is much nicer. But please add a couple of #defines for the 0x18
> bits.
>
Of course!

> Andrew
>

Egil


From 1583948403104345238@xxx Mon Nov 13 11:01:50 +0000 2017
X-GM-THRID: 1583680264397303225
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread