2022-06-14 04:09:44

by Yuan, Perry

Subject: [PATCH] cpufreq: amd_pstate: fix the highest perf query for new AMD processors

In order to get the corrent highest perf for some new AMD processors,
the amd_get_highest_perf() call will check the CPU model and
return correct highest perf value.

Signed-off-by: Perry Yuan <[email protected]>
---
arch/x86/kernel/cpu/amd.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/x86/kernel/cpu/amd.c b/arch/x86/kernel/cpu/amd.c
index 0c0b09796ced..ff2075f26ef4 100644
--- a/arch/x86/kernel/cpu/amd.c
+++ b/arch/x86/kernel/cpu/amd.c
@@ -1152,7 +1152,8 @@ u32 amd_get_highest_perf(void)
struct cpuinfo_x86 *c = &boot_cpu_data;

if (c->x86 == 0x17 && ((c->x86_model >= 0x30 && c->x86_model < 0x40) ||
- (c->x86_model >= 0x70 && c->x86_model < 0x80)))
+ (c->x86_model >= 0x70 && c->x86_model < 0x80) ||
+ (c->x86_model >= 0xa0 && c->x86_model < 0xb0)))
return 166;

if (c->x86 == 0x19 && ((c->x86_model >= 0x20 && c->x86_model < 0x30) ||
--
2.25.1

2022-06-14 04:39:56

by Mario Limonciello

Subject: Re: [PATCH] cpufreq: amd_pstate: fix the highest perf query for new AMD processors

On 6/13/22 22:52, Perry Yuan wrote:
> In order to get the corrent highest perf for some new AMD processors,
> the amd_get_highest_perf() call will check the CPU model and
> return correct highest perf value.
>
> Signed-off-by: Perry Yuan <[email protected]>

Reviewed-by: Mario Limonciello <[email protected]>

> ---
> arch/x86/kernel/cpu/amd.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/x86/kernel/cpu/amd.c b/arch/x86/kernel/cpu/amd.c
> index 0c0b09796ced..ff2075f26ef4 100644
> --- a/arch/x86/kernel/cpu/amd.c
> +++ b/arch/x86/kernel/cpu/amd.c
> @@ -1152,7 +1152,8 @@ u32 amd_get_highest_perf(void)
> struct cpuinfo_x86 *c = &boot_cpu_data;
>
> if (c->x86 == 0x17 && ((c->x86_model >= 0x30 && c->x86_model < 0x40) ||
> - (c->x86_model >= 0x70 && c->x86_model < 0x80)))
> + (c->x86_model >= 0x70 && c->x86_model < 0x80) ||
> + (c->x86_model >= 0xa0 && c->x86_model < 0xb0)))
> return 166;
>
> if (c->x86 == 0x19 && ((c->x86_model >= 0x20 && c->x86_model < 0x30) ||

2022-06-14 09:02:00

by Yuan, Perry

Subject: RE: [PATCH] cpufreq: amd_pstate: fix the highest perf query for new AMD processors

[AMD Official Use Only - General]

Hi Ray.

> -----Original Message-----
> From: Huang, Ray <[email protected]>
> Sent: Tuesday, June 14, 2022 4:42 PM
> To: Yuan, Perry <[email protected]>
> Cc: Thomas Gleixner <[email protected]>; Ingo Molnar <[email protected]>;
> Borislav Petkov <[email protected]>; Dave Hansen <[email protected]>;
> [email protected]; H. Peter Anvin <[email protected]>; Lendacky, Thomas
> <[email protected]>; Limonciello, Mario
> <[email protected]>; Jane Malalane <[email protected]>;
> Phillips, Kim <[email protected]>; Tony Luck <[email protected]>; linux-
> [email protected]; Su, Jinzhou (Joe) <[email protected]>; Meng, Li
> (Jassmine) <[email protected]>; [email protected]
> Subject: Re: [PATCH] cpufreq: amd_pstate: fix the highest perf query for new
> AMD processors
>
> On Tue, Jun 14, 2022 at 11:52:28AM +0800, Yuan, Perry wrote:
> > In order to get the corrent highest perf for some new AMD processors,
> > the amd_get_highest_perf() call will check the CPU model and return
> > correct highest perf value.
> >
>
> You needs to change the prefix of the subject, because it's not the amd-pstate
> driver.
>
> x86/amd: Fix the highest perf query for new AMD processors
>
> Thanks,
> Ray

Thanks for reminding me that.
Will update the title as below. Sending V2.

x86/cpu/amd: fix the highest perf query for new AMD processors

Perry.

>
> > Signed-off-by: Perry Yuan <[email protected]>
> > ---
> > arch/x86/kernel/cpu/amd.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/arch/x86/kernel/cpu/amd.c b/arch/x86/kernel/cpu/amd.c
> > index 0c0b09796ced..ff2075f26ef4 100644
> > --- a/arch/x86/kernel/cpu/amd.c
> > +++ b/arch/x86/kernel/cpu/amd.c
> > @@ -1152,7 +1152,8 @@ u32 amd_get_highest_perf(void)
> > struct cpuinfo_x86 *c = &boot_cpu_data;
> >
> > if (c->x86 == 0x17 && ((c->x86_model >= 0x30 && c->x86_model < 0x40)
> ||
> > - (c->x86_model >= 0x70 && c->x86_model < 0x80)))
> > + (c->x86_model >= 0x70 && c->x86_model < 0x80)
> ||
> > + (c->x86_model >= 0xa0 && c->x86_model < 0xb0)))
> > return 166;
> >
> > if (c->x86 == 0x19 && ((c->x86_model >= 0x20 && c->x86_model < 0x30)
> > ||
> > --
> > 2.25.1
> >

2022-06-14 09:27:01

by Huang Rui

Subject: Re: [PATCH] cpufreq: amd_pstate: fix the highest perf query for new AMD processors

On Tue, Jun 14, 2022 at 11:52:28AM +0800, Yuan, Perry wrote:
> In order to get the corrent highest perf for some new AMD processors,
> the amd_get_highest_perf() call will check the CPU model and
> return correct highest perf value.
>

You needs to change the prefix of the subject, because it's not the
amd-pstate driver.

x86/amd: Fix the highest perf query for new AMD processors

Thanks,
Ray

> Signed-off-by: Perry Yuan <[email protected]>
> ---
> arch/x86/kernel/cpu/amd.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/x86/kernel/cpu/amd.c b/arch/x86/kernel/cpu/amd.c
> index 0c0b09796ced..ff2075f26ef4 100644
> --- a/arch/x86/kernel/cpu/amd.c
> +++ b/arch/x86/kernel/cpu/amd.c
> @@ -1152,7 +1152,8 @@ u32 amd_get_highest_perf(void)
> struct cpuinfo_x86 *c = &boot_cpu_data;
>
> if (c->x86 == 0x17 && ((c->x86_model >= 0x30 && c->x86_model < 0x40) ||
> - (c->x86_model >= 0x70 && c->x86_model < 0x80)))
> + (c->x86_model >= 0x70 && c->x86_model < 0x80) ||
> + (c->x86_model >= 0xa0 && c->x86_model < 0xb0)))
> return 166;
>
> if (c->x86 == 0x19 && ((c->x86_model >= 0x20 && c->x86_model < 0x30) ||
> --
> 2.25.1
>