2019-09-16 10:51:20

by Baolin Wang

Subject: [PATCH] gpio: eic: sprd: Fix the incorrect EIC offset when toggling

From: Bruce Chen <[email protected]>

When toggling the level trigger to emulate the edge trigger, the
EIC offset is incorrect without adding the corresponding bank index,
thus fix it.

Fixes: 7bf0d7f62282 ("gpio: eic: Add edge trigger emulation for EIC")
Signed-off-by: Bruce Chen <[email protected]>
Signed-off-by: Baolin Wang <[email protected]>
---
drivers/gpio/gpio-eic-sprd.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/gpio/gpio-eic-sprd.c b/drivers/gpio/gpio-eic-sprd.c
index 7b9ac4a..090539f 100644
--- a/drivers/gpio/gpio-eic-sprd.c
+++ b/drivers/gpio/gpio-eic-sprd.c
@@ -530,11 +530,12 @@ static void sprd_eic_handle_one_type(struct gpio_chip *chip)
}

for_each_set_bit(n, &reg, SPRD_EIC_PER_BANK_NR) {
- girq = irq_find_mapping(chip->irq.domain,
- bank * SPRD_EIC_PER_BANK_NR + n);
+ u32 offset = bank * SPRD_EIC_PER_BANK_NR + n;
+
+ girq = irq_find_mapping(chip->irq.domain, offset);

generic_handle_irq(girq);
- sprd_eic_toggle_trigger(chip, girq, n);
+ sprd_eic_toggle_trigger(chip, girq, offset);
}
}
}
--
1.7.9.5

2019-09-17 09:47:12

by Bartosz Golaszewski

Subject: Re: [PATCH] gpio: eic: sprd: Fix the incorrect EIC offset when toggling

pon., 16 wrz 2019 o 11:57 Baolin Wang <[email protected]> napisał(a):
>
> From: Bruce Chen <[email protected]>
>
> When toggling the level trigger to emulate the edge trigger, the
> EIC offset is incorrect without adding the corresponding bank index,
> thus fix it.
>
> Fixes: 7bf0d7f62282 ("gpio: eic: Add edge trigger emulation for EIC")
> Signed-off-by: Bruce Chen <[email protected]>
> Signed-off-by: Baolin Wang <[email protected]>
> ---
> drivers/gpio/gpio-eic-sprd.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpio/gpio-eic-sprd.c b/drivers/gpio/gpio-eic-sprd.c
> index 7b9ac4a..090539f 100644
> --- a/drivers/gpio/gpio-eic-sprd.c
> +++ b/drivers/gpio/gpio-eic-sprd.c
> @@ -530,11 +530,12 @@ static void sprd_eic_handle_one_type(struct gpio_chip *chip)
> }
>
> for_each_set_bit(n, &reg, SPRD_EIC_PER_BANK_NR) {
> - girq = irq_find_mapping(chip->irq.domain,
> - bank * SPRD_EIC_PER_BANK_NR + n);
> + u32 offset = bank * SPRD_EIC_PER_BANK_NR + n;
> +
> + girq = irq_find_mapping(chip->irq.domain, offset);
>
> generic_handle_irq(girq);
> - sprd_eic_toggle_trigger(chip, girq, n);
> + sprd_eic_toggle_trigger(chip, girq, offset);
> }
> }
> }
> --
> 1.7.9.5
>

Queued for fixes.

Bart