2007-06-27 11:54:58

by Trilok Soni

Subject: checkpatch: need space before that '*' (ctx:BxB)

Andy,

In the following case we may not need space before that "(*)". It
looks like false positive. Please check.

need space before that '*' (ctx:BxB)
#1034: FILE: drivers/video/omap/omapfb.c:968:
+ omapfb_nb->nb.notifier_call = (int (*)(struct notifier_block *,
^

--
--Trilok Soni

2007-06-27 12:49:56

by Jan Engelhardt

Subject: Re: checkpatch: need space before that '*' (ctx:BxB)

On Jun 27 2007 17:24, Trilok Soni wrote:
>
> In the following case we may not need space before that "(*)". It
> looks like false positive. Please check.
>
> need space before that '*' (ctx:BxB)
> #1034: FILE: drivers/video/omap/omapfb.c:968:
> + omapfb_nb->nb.notifier_call = (int (*)(struct notifier_block *,
> ^

The line, as presented in your mail, is already correct
Keep the space between "int" and "(*)" :-)
[follows how you'd declare a normal variable]


Jan
--