Hi all,
After merging the mm tree, today's linux-next build (htmldocs) produced
these warnings:
include/linux/slab.h:545: warning: expecting prototype for kmem_cache_alloc(). Prototype was for kmem_cache_alloc_noprof() instead
include/linux/slab.h:652: warning: expecting prototype for kmalloc(). Prototype was for kmalloc_noprof() instead
include/linux/slab.h:692: warning: expecting prototype for kmalloc_array(). Prototype was for kmalloc_array_noprof() instead
include/linux/slab.h:714: warning: expecting prototype for krealloc_array() Prototype was for krealloc_array_noprof() instead
include/linux/slab.h:730: warning: Function parameter or struct member '_n' not described in 'kcalloc'
include/linux/slab.h:730: warning: Function parameter or struct member '_size' not described in 'kcalloc'
include/linux/slab.h:730: warning: Function parameter or struct member '_flags' not described in 'kcalloc'
include/linux/slab.h:730: warning: Excess function parameter 'n' description in 'kcalloc'
include/linux/slab.h:730: warning: Excess function parameter 'size' description in 'kcalloc'
include/linux/slab.h:730: warning: Excess function parameter 'flags' description in 'kcalloc'
include/linux/slab.h:774: warning: expecting prototype for kzalloc(). Prototype was for kzalloc_noprof() instead
mm/slab_common.c:1217: warning: expecting prototype for krealloc(). Prototype was for krealloc_noprof() instead
mm/util.c:751: warning: expecting prototype for __vcalloc(). Prototype was for __vcalloc_noprof() instead
mm/vmalloc.c:3897: warning: expecting prototype for vmalloc(). Prototype was for vmalloc_noprof() instead
mm/vmalloc.c:3916: warning: expecting prototype for vmalloc_huge(). Prototype was for vmalloc_huge_noprof() instead
mm/vmalloc.c:3953: warning: expecting prototype for vmalloc_user(). Prototype was for vmalloc_user_noprof() instead
mm/mempool.c:245: warning: expecting prototype for mempool_init(). Prototype was for mempool_init_noprof() instead
mm/mempool.c:271: warning: Function parameter or struct member 'gfp_mask' not described in 'mempool_create_node_noprof'
mm/mempool.c:271: warning: Function parameter or struct member 'node_id' not described in 'mempool_create_node_noprof'
mm/mempool.c:271: warning: expecting prototype for mempool_create_node(). Prototype was for mempool_create_node_noprof() instead
Introduced by commits
c64e38ed88d1 ("mm/slab: enable slab allocation tagging for kmalloc and friends")
ea7b8933f21b ("mempool: hook up to memory allocation profiling")
576477564ede ("mm: vmalloc: enable memory allocation profiling")
from the mm-unstable branch of the mm tree.
--
Cheers,
Stephen Rothwell
On 3/25/24 19:19, Suren Baghdasaryan wrote:
> On Sun, Mar 24, 2024 at 6:36 PM Stephen Rothwell <[email protected]> wrote:
>>
>> Hi all,
>>
>> After merging the mm tree, today's linux-next build (htmldocs) produced
>> these warnings:
>>
>> include/linux/slab.h:545: warning: expecting prototype for kmem_cache_alloc(). Prototype was for kmem_cache_alloc_noprof() instead
>> include/linux/slab.h:652: warning: expecting prototype for kmalloc(). Prototype was for kmalloc_noprof() instead
>> include/linux/slab.h:692: warning: expecting prototype for kmalloc_array(). Prototype was for kmalloc_array_noprof() instead
>> include/linux/slab.h:714: warning: expecting prototype for krealloc_array(). Prototype was for krealloc_array_noprof() instead
>> include/linux/slab.h:730: warning: Function parameter or struct member '_n' not described in 'kcalloc'
>> include/linux/slab.h:730: warning: Function parameter or struct member '_size' not described in 'kcalloc'
>> include/linux/slab.h:730: warning: Function parameter or struct member '_flags' not described in 'kcalloc'
>> include/linux/slab.h:730: warning: Excess function parameter 'n' description in 'kcalloc'
>> include/linux/slab.h:730: warning: Excess function parameter 'size' description in 'kcalloc'
>> include/linux/slab.h:730: warning: Excess function parameter 'flags' description in 'kcalloc'
>> include/linux/slab.h:774: warning: expecting prototype for kzalloc(). Prototype was for kzalloc_noprof() instead
>> mm/slab_common.c:1217: warning: expecting prototype for krealloc(). Prototype was for krealloc_noprof() instead
>> mm/util.c:751: warning: expecting prototype for __vcalloc(). Prototype was for __vcalloc_noprof() instead
>> mm/vmalloc.c:3897: warning: expecting prototype for vmalloc(). Prototype was for vmalloc_noprof() instead
>> mm/vmalloc.c:3916: warning: expecting prototype for vmalloc_huge(). Prototype was for vmalloc_huge_noprof() instead
>> mm/vmalloc.c:3953: warning: expecting prototype for vmalloc_user(). Prototype was for vmalloc_user_noprof() instead
>> mm/mempool.c:245: warning: expecting prototype for mempool_init(). Prototype was for mempool_init_noprof() instead
>> mm/mempool.c:271: warning: Function parameter or struct member 'gfp_mask' not described in 'mempool_create_node_noprof'
>> mm/mempool.c:271: warning: Function parameter or struct member 'node_id' not described in 'mempool_create_node_noprof'
>> mm/mempool.c:271: warning: expecting prototype for mempool_create_node(). Prototype was for mempool_create_node_noprof() instead
>>
>> Introduced by commits
>>
>> c64e38ed88d1 ("mm/slab: enable slab allocation tagging for kmalloc and friends")
>> ea7b8933f21b ("mempool: hook up to memory allocation profiling")
>> 576477564ede ("mm: vmalloc: enable memory allocation profiling")
>>
>> from the mm-unstable branch of the mm tree.
>
> Thanks for the report, Stephen!
> Let us check with Randy Dunlap how we should handle these. I assume we
> still want documentation to document kmalloc(), not kmalloc_noprof().
> Maybe there is a way to mute these warnings.
A proposed patch is here:
https://lore.kernel.org/lkml/[email protected]/T/#u
--
#Randy
Hi all,
On Mon, 25 Mar 2024 23:16:55 -0700 Suren Baghdasaryan <[email protected]> wrote:
>
> Thanks! I'll change back all the instances in the documentation where
> we replaced original names with _noprof versions.
I now have the following:
mm/util.c:128: warning: expecting prototype for kmemdup_noprof(). Prototype was for kmemdup() instead
mm/util.c:613: warning: expecting prototype for kvmalloc_node_noprof(). Prototype was for kvmalloc_node() instead
mm/util.c:724: warning: expecting prototype for __vmalloc_array_noprof(). Prototype was for __vmalloc_array() instead
mm/util.c:739: warning: expecting prototype for vmalloc_array_noprof(). Prototype was for vmalloc_array() instead
mm/util.c:762: warning: expecting prototype for vcalloc_noprof(). Prototype was for vcalloc() instead
drivers/gpu/drm/amd/display/dc/inc/hw/hubp.h:1: warning: no structured comments found
drivers/gpu/drm/amd/display/dc/inc/hw/hubp.h:1: warning: no structured comments found
drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h:1: warning: no structured comments found
drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h:547: warning: Function parameter or struct member 'read_mpcc_state' not described in 'mpc_funcs'
drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h:547: warning: Function parameter or struct member 'mpc_init_single_inst' not described in 'mpc_funcs'
drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h:547: warning: Function parameter or struct member 'get_mpcc_for_dpp_from_secondary' not described in 'mpc_funcs'
drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h:547: warning: Function parameter or struct member 'get_mpcc_for_dpp' not described in 'mpc_funcs'
drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h:547: warning: Function parameter or struct member 'wait_for_idle' not described in 'mpc_funcs'
drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h:547: warning: Function parameter or struct member 'assert_mpcc_idle_before_connect' not described in 'mpc_funcs'
drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h:547: warning: Function parameter or struct member 'init_mpcc_list_from_hw' not described in 'mpc_funcs'
drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h:547: warning: Function parameter or struct member 'set_denorm' not described in 'mpc_funcs'
drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h:547: warning: Function parameter or struct member 'set_denorm_clamp' not described in 'mpc_funcs'
drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h:547: warning: Function parameter or struct member 'set_output_csc' not described in 'mpc_funcs'
drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h:547: warning: Function parameter or struct member 'set_ocsc_default' not described in 'mpc_funcs'
drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h:547: warning: Function parameter or struct member 'set_output_gamma' not described in 'mpc_funcs'
drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h:547: warning: Function parameter or struct member 'power_on_mpc_mem_pwr' not described in 'mpc_funcs'
drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h:547: warning: Function parameter or struct member 'set_dwb_mux' not described in 'mpc_funcs'
drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h:547: warning: Function parameter or struct member 'disable_dwb_mux' not described in 'mpc_funcs'
drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h:547: warning: Function parameter or struct member 'is_dwb_idle' not described in 'mpc_funcs'
drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h:547: warning: Function parameter or struct member 'set_out_rate_control' not described in 'mpc_funcs'
drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h:547: warning: Function parameter or struct member 'set_gamut_remap' not described in 'mpc_funcs'
drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h:547: warning: Function parameter or struct member 'program_1dlut' not described in 'mpc_funcs'
drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h:547: warning: Function parameter or struct member 'program_shaper' not described in 'mpc_funcs'
drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h:547: warning: Function parameter or struct member 'acquire_rmu' not described in 'mpc_funcs'
drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h:547: warning: Function parameter or struct member 'program_3dlut' not described in 'mpc_funcs'
drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h:547: warning: Function parameter or struct member 'release_rmu' not described in 'mpc_funcs'
drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h:547: warning: Function parameter or struct member 'get_mpc_out_mux' not described in 'mpc_funcs'
drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h:547: warning: Function parameter or struct member 'set_bg_color' not described in 'mpc_funcs'
drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h:547: warning: Function parameter or struct member 'set_mpc_mem_lp_mode' not described in 'mpc_funcs'
drivers/gpu/drm/amd/display/dc/inc/hw/opp.h:1: warning: no structured comments found
drivers/gpu/drm/amd/display/dc/inc/hw/opp.h:1: warning: no structured comments found
drivers/gpu/drm/amd/display/dc/link/hwss/link_hwss_dio.h:1: warning: no structured comments found
drivers/gpu/drm/amd/display/dc/link/hwss/link_hwss_dio.h:1: warning: no structured comments found
drivers/slimbus/stream.c:49: warning: Excess struct member 'segdist_codes' description in 'segdist_code'
include/linux/slab.h:730: warning: Function parameter or struct member '_n' not described in 'kcalloc'
include/linux/slab.h:730: warning: Function parameter or struct member '_size' not described in 'kcalloc'
include/linux/slab.h:730: warning: Function parameter or struct member '_flags' not described in 'kcalloc'
include/linux/slab.h:730: warning: Excess function parameter 'n' description in 'kcalloc'
include/linux/slab.h:730: warning: Excess function parameter 'size' description in 'kcalloc'
include/linux/slab.h:730: warning: Excess function parameter 'flags' description in 'kcalloc'
mm/slub.c:3969: warning: expecting prototype for kmem_cache_alloc_node_noprof(). Prototype was for kmem_cache_alloc_node() instead
mm/util.c:128: warning: expecting prototype for kmemdup_noprof(). Prototype was for kmemdup() instead
mm/util.c:613: warning: expecting prototype for kvmalloc_node_noprof(). Prototype was for kvmalloc_node() instead
mm/util.c:724: warning: expecting prototype for __vmalloc_array_noprof(). Prototype was for __vmalloc_array() instead
mm/util.c:739: warning: expecting prototype for vmalloc_array_noprof(). Prototype was for vmalloc_array() instead
mm/util.c:762: warning: expecting prototype for vcalloc_noprof(). Prototype was for vcalloc() instead
mm/vmalloc.c:3722: warning: expecting prototype for __vmalloc_node_range_noprof(). Prototype was for __vmalloc_node_range() instead
mm/vmalloc.c:3867: warning: expecting prototype for __vmalloc_node_noprof() Prototype was for __vmalloc_node() instead
mm/vmalloc.c:3940: warning: expecting prototype for vzalloc_noprof(). Prototype was for vzalloc() instead
mm/vmalloc.c:3978: warning: expecting prototype for vmalloc_node_noprof(). Prototype was for vmalloc_node() instead
mm/vmalloc.c:3996: warning: expecting prototype for vzalloc_node_noprof(). Prototype was for vzalloc_node() instead
mm/vmalloc.c:4024: warning: expecting prototype for vmalloc_32_noprof(). Prototype was for vmalloc_32() instead
mm/vmalloc.c:4040: warning: expecting prototype for vmalloc_32_user_noprof(). Prototype was for vmalloc_32_user() instead
mm/mempool.c:383: warning: expecting prototype for mempool_alloc_noprof(). Prototype was for mempool_alloc() instead
mm/page_alloc.c:4991: warning: expecting prototype for alloc_pages_exact_noprof(). Prototype was for alloc_pages_exact() instead
mm/page_alloc.c:5016: warning: expecting prototype for alloc_pages_exact_nid_noprof(). Prototype was for alloc_pages_exact_nid() instead
mm/page_alloc.c:6463: warning: expecting prototype for alloc_contig_range_noprof(). Prototype was for alloc_contig_range() instead
mm/page_alloc.c:6627: warning: expecting prototype for alloc_contig_pages_noprof(). Prototype was for alloc_contig_pages() instead
mm/mempolicy.c:2223: warning: expecting prototype for alloc_pages_mpol_noprof(). Prototype was for alloc_pages_mpol() instead
mm/mempolicy.c:2298: warning: expecting prototype for vma_alloc_folio_noprof(). Prototype was for vma_alloc_folio() instead
mm/mempolicy.c:2326: warning: expecting prototype for alloc_pages_noprof(). Prototype was for alloc_pages() instead
mm/util.c:128: warning: expecting prototype for kmemdup_noprof(). Prototype was for kmemdup() instead
mm/util.c:613: warning: expecting prototype for kvmalloc_node_noprof(). Prototype was for kvmalloc_node() instead
mm/util.c:724: warning: expecting prototype for __vmalloc_array_noprof(). Prototype was for __vmalloc_array() instead
mm/util.c:739: warning: expecting prototype for vmalloc_array_noprof(). Prototype was for vmalloc_array() instead
mm/util.c:762: warning: expecting prototype for vcalloc_noprof(). Prototype was for vcalloc() instead
mm/percpu.c:1745: warning: expecting prototype for pcpu_alloc_noprof(). Prototype was for pcpu_alloc() instead
--
Cheers,
Stephen Rothwell
Hi all,
On Thu, 28 Mar 2024 15:39:47 +1100 Stephen Rothwell <[email protected]> wrote:
>
> On Mon, 25 Mar 2024 23:16:55 -0700 Suren Baghdasaryan <[email protected]> wrote:
> >
> > Thanks! I'll change back all the instances in the documentation where
> > we replaced original names with _noprof versions.
>
> I now have the following:
Sorry, some of those are not relevant here, just the _noprof stuff.
--
Cheers,
Stephen Rothwell
Hi Suren,
On Wed, 27 Mar 2024 22:35:56 -0700 Suren Baghdasaryan <[email protected]> wrote:
>
> https://lore.kernel.org/all/[email protected]/
> which seems to not yet been pulled into mm-unstable should fix the
> following warnings:
>
> include/linux/slab.h:730: warning: Function parameter or struct member
> '_n' not described in 'kcalloc'
> include/linux/slab.h:730: warning: Function parameter or struct member
> '_size' not described in 'kcalloc'
> include/linux/slab.h:730: warning: Function parameter or struct member
> '_flags' not described in 'kcalloc'
> include/linux/slab.h:730: warning: Excess function parameter 'n'
> description in 'kcalloc'
> include/linux/slab.h:730: warning: Excess function parameter 'size'
> description in 'kcalloc'
> include/linux/slab.h:730: warning: Excess function parameter 'flags'
> description in 'kcalloc'
>
> And https://lore.kernel.org/all/[email protected]/
> should handle the _noprof warnings. I can see this patch in
> mm-unstable and running "make htmldocs" in mm-unstable does not show
> the _noprof warnings anymore. Please let me know if I should try some
> other command to reproduce these.
Those patches entered the mm tree after I had merge it on Thursday. It
should all be good on Tuesday.
--
Cheers,
Stephen Rothwell
On Fri, Mar 29, 2024 at 3:49 PM Stephen Rothwell <[email protected]> wrote:
>
> Hi Suren,
>
> On Wed, 27 Mar 2024 22:35:56 -0700 Suren Baghdasaryan <[email protected]> wrote:
> >
> > https://lore.kernel.org/all/[email protected]/
> > which seems to not yet been pulled into mm-unstable should fix the
> > following warnings:
> >
> > include/linux/slab.h:730: warning: Function parameter or struct member
> > '_n' not described in 'kcalloc'
> > include/linux/slab.h:730: warning: Function parameter or struct member
> > '_size' not described in 'kcalloc'
> > include/linux/slab.h:730: warning: Function parameter or struct member
> > '_flags' not described in 'kcalloc'
> > include/linux/slab.h:730: warning: Excess function parameter 'n'
> > description in 'kcalloc'
> > include/linux/slab.h:730: warning: Excess function parameter 'size'
> > description in 'kcalloc'
> > include/linux/slab.h:730: warning: Excess function parameter 'flags'
> > description in 'kcalloc'
> >
> > And https://lore.kernel.org/all/20240326054149.2121-1-rdunlap@infradeadorg/
> > should handle the _noprof warnings. I can see this patch in
> > mm-unstable and running "make htmldocs" in mm-unstable does not show
> > the _noprof warnings anymore. Please let me know if I should try some
> > other command to reproduce these.
>
> Those patches entered the mm tree after I had merge it on Thursday. It
> should all be good on Tuesday.
Perfect. I'll ignore similar reports with _noprof prototype warnings until then.
Thank you!
>
> --
> Cheers,
> Stephen Rothwell
On Wed, Mar 27, 2024 at 9:44 PM Stephen Rothwell <[email protected]> wrote:
>
> Hi all,
>
> On Thu, 28 Mar 2024 15:39:47 +1100 Stephen Rothwell <[email protected]> wrote:
> >
> > On Mon, 25 Mar 2024 23:16:55 -0700 Suren Baghdasaryan <[email protected]> wrote:
> > >
> > > Thanks! I'll change back all the instances in the documentation where
> > > we replaced original names with _noprof versions.
> >
> > I now have the following:
>
> Sorry, some of those are not relevant here, just the _noprof stuff.
https://lore.kernel.org/all/[email protected]/
which seems to not yet been pulled into mm-unstable should fix the
following warnings:
include/linux/slab.h:730: warning: Function parameter or struct member
'_n' not described in 'kcalloc'
include/linux/slab.h:730: warning: Function parameter or struct member
'_size' not described in 'kcalloc'
include/linux/slab.h:730: warning: Function parameter or struct member
'_flags' not described in 'kcalloc'
include/linux/slab.h:730: warning: Excess function parameter 'n'
description in 'kcalloc'
include/linux/slab.h:730: warning: Excess function parameter 'size'
description in 'kcalloc'
include/linux/slab.h:730: warning: Excess function parameter 'flags'
description in 'kcalloc'
And https://lore.kernel.org/all/[email protected]/
should handle the _noprof warnings. I can see this patch in
mm-unstable and running "make htmldocs" in mm-unstable does not show
the _noprof warnings anymore. Please let me know if I should try some
other command to reproduce these.
Thanks,
Suren.
>
> --
> Cheers,
> Stephen Rothwell
On Mon, Mar 25, 2024 at 10:44 PM Randy Dunlap <[email protected]> wrote:
>
>
>
> On 3/25/24 19:19, Suren Baghdasaryan wrote:
> > On Sun, Mar 24, 2024 at 6:36 PM Stephen Rothwell <[email protected]> wrote:
> >>
> >> Hi all,
> >>
> >> After merging the mm tree, today's linux-next build (htmldocs) produced
> >> these warnings:
> >>
> >> include/linux/slab.h:545: warning: expecting prototype for kmem_cache_alloc(). Prototype was for kmem_cache_alloc_noprof() instead
> >> include/linux/slab.h:652: warning: expecting prototype for kmalloc(). Prototype was for kmalloc_noprof() instead
> >> include/linux/slab.h:692: warning: expecting prototype for kmalloc_array(). Prototype was for kmalloc_array_noprof() instead
> >> include/linux/slab.h:714: warning: expecting prototype for krealloc_array(). Prototype was for krealloc_array_noprof() instead
> >> include/linux/slab.h:730: warning: Function parameter or struct member '_n' not described in 'kcalloc'
> >> include/linux/slab.h:730: warning: Function parameter or struct member '_size' not described in 'kcalloc'
> >> include/linux/slab.h:730: warning: Function parameter or struct member '_flags' not described in 'kcalloc'
> >> include/linux/slab.h:730: warning: Excess function parameter 'n' description in 'kcalloc'
> >> include/linux/slab.h:730: warning: Excess function parameter 'size' description in 'kcalloc'
> >> include/linux/slab.h:730: warning: Excess function parameter 'flags' description in 'kcalloc'
> >> include/linux/slab.h:774: warning: expecting prototype for kzalloc(). Prototype was for kzalloc_noprof() instead
> >> mm/slab_common.c:1217: warning: expecting prototype for krealloc(). Prototype was for krealloc_noprof() instead
> >> mm/util.c:751: warning: expecting prototype for __vcalloc(). Prototype was for __vcalloc_noprof() instead
> >> mm/vmalloc.c:3897: warning: expecting prototype for vmalloc(). Prototype was for vmalloc_noprof() instead
> >> mm/vmalloc.c:3916: warning: expecting prototype for vmalloc_huge(). Prototype was for vmalloc_huge_noprof() instead
> >> mm/vmalloc.c:3953: warning: expecting prototype for vmalloc_user(). Prototype was for vmalloc_user_noprof() instead
> >> mm/mempool.c:245: warning: expecting prototype for mempool_init(). Prototype was for mempool_init_noprof() instead
> >> mm/mempool.c:271: warning: Function parameter or struct member 'gfp_mask' not described in 'mempool_create_node_noprof'
> >> mm/mempool.c:271: warning: Function parameter or struct member 'node_id' not described in 'mempool_create_node_noprof'
> >> mm/mempool.c:271: warning: expecting prototype for mempool_create_node(). Prototype was for mempool_create_node_noprof() instead
> >>
> >> Introduced by commits
> >>
> >> c64e38ed88d1 ("mm/slab: enable slab allocation tagging for kmalloc and friends")
> >> ea7b8933f21b ("mempool: hook up to memory allocation profiling")
> >> 576477564ede ("mm: vmalloc: enable memory allocation profiling")
> >>
> >> from the mm-unstable branch of the mm tree.
> >
> > Thanks for the report, Stephen!
> > Let us check with Randy Dunlap how we should handle these. I assume we
> > still want documentation to document kmalloc(), not kmalloc_noprof().
> > Maybe there is a way to mute these warnings.
>
> A proposed patch is here:
> https://lore.kernel.org/lkml/[email protected]/T/#u
Thanks! I'll change back all the instances in the documentation where
we replaced original names with _noprof versions.
>
>
> --
> #Randy
On Sun, Mar 24, 2024 at 6:36 PM Stephen Rothwell <[email protected]> wrote:
>
> Hi all,
>
> After merging the mm tree, today's linux-next build (htmldocs) produced
> these warnings:
>
> include/linux/slab.h:545: warning: expecting prototype for kmem_cache_alloc(). Prototype was for kmem_cache_alloc_noprof() instead
> include/linux/slab.h:652: warning: expecting prototype for kmalloc(). Prototype was for kmalloc_noprof() instead
> include/linux/slab.h:692: warning: expecting prototype for kmalloc_array(). Prototype was for kmalloc_array_noprof() instead
> include/linux/slab.h:714: warning: expecting prototype for krealloc_array(). Prototype was for krealloc_array_noprof() instead
> include/linux/slab.h:730: warning: Function parameter or struct member '_n' not described in 'kcalloc'
> include/linux/slab.h:730: warning: Function parameter or struct member '_size' not described in 'kcalloc'
> include/linux/slab.h:730: warning: Function parameter or struct member '_flags' not described in 'kcalloc'
> include/linux/slab.h:730: warning: Excess function parameter 'n' description in 'kcalloc'
> include/linux/slab.h:730: warning: Excess function parameter 'size' description in 'kcalloc'
> include/linux/slab.h:730: warning: Excess function parameter 'flags' description in 'kcalloc'
> include/linux/slab.h:774: warning: expecting prototype for kzalloc(). Prototype was for kzalloc_noprof() instead
> mm/slab_common.c:1217: warning: expecting prototype for krealloc(). Prototype was for krealloc_noprof() instead
> mm/util.c:751: warning: expecting prototype for __vcalloc(). Prototype was for __vcalloc_noprof() instead
> mm/vmalloc.c:3897: warning: expecting prototype for vmalloc(). Prototype was for vmalloc_noprof() instead
> mm/vmalloc.c:3916: warning: expecting prototype for vmalloc_huge(). Prototype was for vmalloc_huge_noprof() instead
> mm/vmalloc.c:3953: warning: expecting prototype for vmalloc_user(). Prototype was for vmalloc_user_noprof() instead
> mm/mempool.c:245: warning: expecting prototype for mempool_init(). Prototype was for mempool_init_noprof() instead
> mm/mempool.c:271: warning: Function parameter or struct member 'gfp_mask' not described in 'mempool_create_node_noprof'
> mm/mempool.c:271: warning: Function parameter or struct member 'node_id' not described in 'mempool_create_node_noprof'
> mm/mempool.c:271: warning: expecting prototype for mempool_create_node(). Prototype was for mempool_create_node_noprof() instead
>
> Introduced by commits
>
> c64e38ed88d1 ("mm/slab: enable slab allocation tagging for kmalloc and friends")
> ea7b8933f21b ("mempool: hook up to memory allocation profiling")
> 576477564ede ("mm: vmalloc: enable memory allocation profiling")
>
> from the mm-unstable branch of the mm tree.
Thanks for the report, Stephen!
Let us check with Randy Dunlap how we should handle these. I assume we
still want documentation to document kmalloc(), not kmalloc_noprof().
Maybe there is a way to mute these warnings.
>
> --
> Cheers,
> Stephen Rothwell