2020-03-18 16:12:28

by Rohit Sarkar

Subject: [PATCH] iio: core: Make mlock internal to the iio core

"mlock" should ideally only be used by the iio core. The mlock
implementation may change in the future which means that no driver
should be explicitly using mlock.

Signed-off-by: Rohit Sarkar <[email protected]>
---
include/linux/iio/iio.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/iio/iio.h b/include/linux/iio/iio.h
index eed58ed2f368..e975020abaa6 100644
--- a/include/linux/iio/iio.h
+++ b/include/linux/iio/iio.h
@@ -492,7 +492,7 @@ struct iio_buffer_setup_ops {
* @buffer: [DRIVER] any buffer present
* @buffer_list: [INTERN] list of all buffers currently attached
* @scan_bytes: [INTERN] num bytes captured to be fed to buffer demux
- * @mlock: [DRIVER] lock used to prevent simultaneous device state
+ * @mlock: [INTERN] lock used to prevent simultaneous device state
* changes
* @available_scan_masks: [DRIVER] optional array of allowed bitmasks
* @masklength: [INTERN] the length of the mask established from
--
2.23.0.385.gbc12974a89

2020-03-21 11:03:41

by Jonathan Cameron

Subject: Re: [PATCH] iio: core: Make mlock internal to the iio core

On Wed, 18 Mar 2020 21:41:51 +0530
Rohit Sarkar <[email protected]> wrote:

> "mlock" should ideally only be used by the iio core. The mlock
> implementation may change in the future which means that no driver
> should be explicitly using mlock.
>
> Signed-off-by: Rohit Sarkar <[email protected]>
Good idea.

Applied to the togreg branch of iio.git and pushed out as testing for
the autobuilders to play with it.

Thanks,

Jonathan

> ---
> include/linux/iio/iio.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/iio/iio.h b/include/linux/iio/iio.h
> index eed58ed2f368..e975020abaa6 100644
> --- a/include/linux/iio/iio.h
> +++ b/include/linux/iio/iio.h
> @@ -492,7 +492,7 @@ struct iio_buffer_setup_ops {
> * @buffer: [DRIVER] any buffer present
> * @buffer_list: [INTERN] list of all buffers currently attached
> * @scan_bytes: [INTERN] num bytes captured to be fed to buffer demux
> - * @mlock: [DRIVER] lock used to prevent simultaneous device state
> + * @mlock: [INTERN] lock used to prevent simultaneous device state
> * changes
> * @available_scan_masks: [DRIVER] optional array of allowed bitmasks
> * @masklength: [INTERN] the length of the mask established from