2020-03-19 06:09:29

by Rohit Sarkar

Subject: [PATCH] iio: imu: inv_mpu6050: add debugfs register r/w interface

The iio debugfs interface provides direct access to read and write device
registers if debugfs is enabled.

Signed-off-by: Rohit Sarkar <[email protected]>
---
drivers/iio/imu/inv_mpu6050/inv_mpu_core.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)

diff --git a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c b/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c
index 7cb9ff3d3e94..3f40db8ea9e2 100644
--- a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c
+++ b/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c
@@ -1248,12 +1248,26 @@ static const struct attribute_group inv_attribute_group = {
.attrs = inv_attributes
};

+static int inv_mpu6050_reg_access(struct iio_dev *indio_dev,
+ unsigned int reg,
+ unsigned int writeval,
+ unsigned int *readval)
+{
+ struct inv_mpu6050_state *st = iio_priv(indio_dev);
+
+ if (readval)
+ return regmap_read(st->map, reg, readval);
+ else
+ return regmap_write(st->map, reg, writeval);
+}
+
static const struct iio_info mpu_info = {
.read_raw = &inv_mpu6050_read_raw,
.write_raw = &inv_mpu6050_write_raw,
.write_raw_get_fmt = &inv_write_raw_get_fmt,
.attrs = &inv_attribute_group,
.validate_trigger = inv_mpu6050_validate_trigger,
+ .debugfs_reg_access = &inv_mpu6050_reg_access
};

/**
--
2.23.0.385.gbc12974a89

2020-03-19 10:24:45

by Andy Shevchenko

Subject: Re: [PATCH] iio: imu: inv_mpu6050: add debugfs register r/w interface

On Thu, Mar 19, 2020 at 8:10 AM Rohit Sarkar <[email protected]> wrote:
>
> The iio debugfs interface provides direct access to read and write device
> registers if debugfs is enabled.

But regmap API provides at least reading facility. Isn't it enough?

...

> static const struct iio_info mpu_info = {
> .read_raw = &inv_mpu6050_read_raw,
> .write_raw = &inv_mpu6050_write_raw,
> .write_raw_get_fmt = &inv_write_raw_get_fmt,
> .attrs = &inv_attribute_group,
> .validate_trigger = inv_mpu6050_validate_trigger,

> + .debugfs_reg_access = &inv_mpu6050_reg_access

Leaving comma is helpful for future development.

> };


--
With Best Regards,
Andy Shevchenko