2020-05-07 06:45:29

by Zou Wei

Subject: [PATCH -next] ALSA: portman2x4: Use bitwise instead of arithmetic operator for flags

Fix the following coccinelle warning:

sound/drivers/portman2x4.c:460:34-35: WARNING: sum of probable bitmasks, consider |

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Samuel Zou <[email protected]>
---
sound/drivers/portman2x4.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/drivers/portman2x4.c b/sound/drivers/portman2x4.c
index ecefa7c..38603cb 100644
--- a/sound/drivers/portman2x4.c
+++ b/sound/drivers/portman2x4.c
@@ -457,7 +457,7 @@ static int portman_probe(struct parport *p)

/* Set for RXDATA0 where no damage will be done. */
/* 5 */
- parport_write_control(p, RXDATA0 + STROBE); /* Write Strobe=1 to command reg. */
+ parport_write_control(p, RXDATA0 | STROBE); /* Write Strobe=1 to command reg. */

/* 6 */
if ((parport_read_status(p) & ESTB) != ESTB)
--
2.6.2

2020-05-07 06:53:42

by Joe Perches

Subject: Re: [PATCH -next] ALSA: portman2x4: Use bitwise instead of arithmetic operator for flags

On Thu, 2020-05-07 at 14:48 +0800, Samuel Zou wrote:
> Fix the following coccinelle warning:
>
> sound/drivers/portman2x4.c:460:34-35: WARNING: sum of probable bitmasks, consider |

This one is reasonable.

> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Samuel Zou <[email protected]>
> ---
> sound/drivers/portman2x4.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/drivers/portman2x4.c b/sound/drivers/portman2x4.c
> index ecefa7c..38603cb 100644
> --- a/sound/drivers/portman2x4.c
> +++ b/sound/drivers/portman2x4.c
> @@ -457,7 +457,7 @@ static int portman_probe(struct parport *p)
>
> /* Set for RXDATA0 where no damage will be done. */
> /* 5 */
> - parport_write_control(p, RXDATA0 + STROBE); /* Write Strobe=1 to command reg. */
> + parport_write_control(p, RXDATA0 | STROBE); /* Write Strobe=1 to command reg. */
>
> /* 6 */
> if ((parport_read_status(p) & ESTB) != ESTB)

2020-05-07 07:09:30

by Takashi Iwai

Subject: Re: [PATCH -next] ALSA: portman2x4: Use bitwise instead of arithmetic operator for flags

On Thu, 07 May 2020 08:48:55 +0200,
Samuel Zou wrote:
>
> Fix the following coccinelle warning:
>
> sound/drivers/portman2x4.c:460:34-35: WARNING: sum of probable bitmasks, consider |
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Samuel Zou <[email protected]>

Applied now. Thanks.


Takashi