2023-07-10 07:42:02

by ye.xingchen

Subject: [PATCH] signal: remove duplicate include header in signal.c

From: Ye Xingchen <[email protected]>

linux/file.h is included more than once.

Signed-off-by: Ye Xingchen <[email protected]>
---
kernel/signal.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/kernel/signal.c b/kernel/signal.c
index 9a3ff8157ceb..b1da4e81bde6 100644
--- a/kernel/signal.c
+++ b/kernel/signal.c
@@ -25,7 +25,6 @@
#include <linux/mm.h>
#include <linux/proc_fs.h>
#include <linux/tty.h>
-#include <linux/file.h>
#include <linux/binfmts.h>
#include <linux/coredump.h>
#include <linux/security.h>
--
2.25.1

2023-07-10 10:22:37

by Haifeng Xu

Subject: Re: [PATCH] signal: remove duplicate include header in signal.c

On 2023/7/10 15:23, [email protected] wrote:
> From: Ye Xingchen <[email protected]>
>
> linux/file.h is included more than once.

Can you point out which files have contained file.h?
Though file.h is included more than once, but it has used the macro "#ifndef / #define" to avoid redefinition.
So what’s your concern about this?

Thanks, Haifeng.

>
> Signed-off-by: Ye Xingchen <[email protected]>
> ---
> kernel/signal.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/kernel/signal.c b/kernel/signal.c
> index 9a3ff8157ceb..b1da4e81bde6 100644
> --- a/kernel/signal.c
> +++ b/kernel/signal.c
> @@ -25,7 +25,6 @@
> #include <linux/mm.h>
> #include <linux/proc_fs.h>
> #include <linux/tty.h>
> -#include <linux/file.h>
> #include <linux/binfmts.h>
> #include <linux/coredump.h>
> #include <linux/security.h>