2019-05-11 13:51:00

by Colin King

Subject: [PATCH] staging: vc04_services: bcm2835-camera: remove redundant assignment to variable ret

From: Colin Ian King <[email protected]>

The variable ret is being initialized however this is never read and later
it is being reassigned to a new value. The initialization is redundant and
hence can be removed.

Addresses-Coverity: ("Unused Value")
Signed-off-by: Colin Ian King <[email protected]>
---
drivers/staging/vc04_services/bcm2835-camera/controls.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/vc04_services/bcm2835-camera/controls.c b/drivers/staging/vc04_services/bcm2835-camera/controls.c
index 9841c30450ce..74410fedffad 100644
--- a/drivers/staging/vc04_services/bcm2835-camera/controls.c
+++ b/drivers/staging/vc04_services/bcm2835-camera/controls.c
@@ -579,7 +579,7 @@ static int ctrl_set_colfx(struct bm2835_mmal_dev *dev,
struct v4l2_ctrl *ctrl,
const struct bm2835_mmal_v4l2_ctrl *mmal_ctrl)
{
- int ret = -EINVAL;
+ int ret;
struct vchiq_mmal_port *control;

control = &dev->component[MMAL_COMPONENT_CAMERA]->control;
--
2.20.1

2019-05-13 07:03:58

by Stefan Wahren

Subject: Re: [PATCH] staging: vc04_services: bcm2835-camera: remove redundant assignment to variable ret

On 11.05.19 15:48, Colin King wrote:
> From: Colin Ian King <[email protected]>
>
> The variable ret is being initialized however this is never read and later
> it is being reassigned to a new value. The initialization is redundant and
> hence can be removed.
>
> Addresses-Coverity: ("Unused Value")
> Signed-off-by: Colin Ian King <[email protected]>
Acked-by: Stefan Wahren <[email protected]>