2021-05-28 06:05:19

by Hangbin Liu

Subject: [PATCH bpf-next] bpf/devmap: remove drops variable from bq_xmit_all()

As Colin pointed out, the first drops assignment after declaration will
be overwritten by the second drops assignment before using, which makes
it useless.

Since the drops variable will be used only once. Just remove it and
use "cnt - sent" in trace_xdp_devmap_xmit()

Reported-by: Colin Ian King <[email protected]>
Fixes: cb261b594b41 ("bpf: Run devmap xdp_prog on flush instead of bulk enqueue")
Signed-off-by: Hangbin Liu <[email protected]>
---
kernel/bpf/devmap.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/kernel/bpf/devmap.c b/kernel/bpf/devmap.c
index f9148daab0e3..2a75e6c2d27d 100644
--- a/kernel/bpf/devmap.c
+++ b/kernel/bpf/devmap.c
@@ -370,8 +370,8 @@ static int dev_map_bpf_prog_run(struct bpf_prog *xdp_prog,
static void bq_xmit_all(struct xdp_dev_bulk_queue *bq, u32 flags)
{
struct net_device *dev = bq->dev;
- int sent = 0, drops = 0, err = 0;
unsigned int cnt = bq->count;
+ int sent = 0, err = 0;
int to_send = cnt;
int i;

@@ -388,8 +388,6 @@ static void bq_xmit_all(struct xdp_dev_bulk_queue *bq, u32 flags)
to_send = dev_map_bpf_prog_run(bq->xdp_prog, bq->q, cnt, dev);
if (!to_send)
goto out;
-
- drops = cnt - to_send;
}

sent = dev->netdev_ops->ndo_xdp_xmit(dev, to_send, bq->q, flags);
@@ -408,9 +406,8 @@ static void bq_xmit_all(struct xdp_dev_bulk_queue *bq, u32 flags)
xdp_return_frame_rx_napi(bq->q[i]);

out:
- drops = cnt - sent;
bq->count = 0;
- trace_xdp_devmap_xmit(bq->dev_rx, dev, sent, drops, err);
+ trace_xdp_devmap_xmit(bq->dev_rx, dev, sent, cnt - sent, err);
}

/* __dev_flush is called from xdp_do_flush() which _must_ be signaled
--
2.26.3

2021-05-28 08:52:23

by John Fastabend

Subject: RE: [PATCH bpf-next] bpf/devmap: remove drops variable from bq_xmit_all()

Hangbin Liu wrote:
> As Colin pointed out, the first drops assignment after declaration will
> be overwritten by the second drops assignment before using, which makes
> it useless.
>
> Since the drops variable will be used only once. Just remove it and
> use "cnt - sent" in trace_xdp_devmap_xmit()
>
> Reported-by: Colin Ian King <[email protected]>
> Fixes: cb261b594b41 ("bpf: Run devmap xdp_prog on flush instead of bulk enqueue")
> Signed-off-by: Hangbin Liu <[email protected]>
> ---
> kernel/bpf/devmap.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>

Thanks

Acked-by: John Fastabend <[email protected]>

2021-05-28 20:21:25

by patchwork-bot+netdevbpf

Subject: Re: [PATCH bpf-next] bpf/devmap: remove drops variable from bq_xmit_all()

Hello:

This patch was applied to bpf/bpf-next.git (refs/heads/master):

On Thu, 27 May 2021 22:43:56 -0400 you wrote:
> As Colin pointed out, the first drops assignment after declaration will
> be overwritten by the second drops assignment before using, which makes
> it useless.
>
> Since the drops variable will be used only once. Just remove it and
> use "cnt - sent" in trace_xdp_devmap_xmit()
>
> [...]

Here is the summary with links:
- [bpf-next] bpf/devmap: remove drops variable from bq_xmit_all()
https://git.kernel.org/bpf/bpf-next/c/e8e0f0f48478

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html