2021-10-18 16:09:31

by John Fastabend

Subject: RE: [PATCH] [v2] selftests: bpf: Remove duplicated include in cgroup_helpers

Wan Jiabing wrote:
> Fix following checkincludes.pl warning:
> ./scripts/checkincludes.pl tools/testing/selftests/bpf/cgroup_helpers.c
> tools/testing/selftests/bpf/cgroup_helpers.c: unistd.h is included more
> than once.
>
> Signed-off-by: Wan Jiabing <[email protected]>
> ---
> Changelog:
> v2:
> - Fix the commit description.
> ---

The Subject is a bit unusual. Typically it would be something like,

"[PATCH bpf-next] selftests, remove duplicated include in cgroup_helpers"

For the actual patch though LGTM.

Acked-by: John Fastabend <[email protected]>

2021-10-20 17:48:13

by Andrii Nakryiko

Subject: Re: [PATCH] [v2] selftests: bpf: Remove duplicated include in cgroup_helpers

On Mon, Oct 18, 2021 at 9:07 AM John Fastabend <[email protected]> wrote:
>
> Wan Jiabing wrote:
> > Fix following checkincludes.pl warning:
> > ./scripts/checkincludes.pl tools/testing/selftests/bpf/cgroup_helpers.c
> > tools/testing/selftests/bpf/cgroup_helpers.c: unistd.h is included more
> > than once.
> >
> > Signed-off-by: Wan Jiabing <[email protected]>
> > ---
> > Changelog:
> > v2:
> > - Fix the commit description.
> > ---
>
> The Subject is a bit unusual. Typically it would be something like,
>
> "[PATCH bpf-next] selftests, remove duplicated include in cgroup_helpers"

Also for selftests we use "selftests/bpf: " prefix (at least we
generally try, for consistency). Fixed up, applied to bpf-next.
Thanks.

>
> For the actual patch though LGTM.
>
> Acked-by: John Fastabend <[email protected]>