> -----Original Message-----
> From: Bartosz Golaszewski <[email protected]>
> Sent: Monday, June 29, 2020 05:04
> To: Kirsher, Jeffrey T <[email protected]>; David S . Miller
> <[email protected]>; Jakub Kicinski <[email protected]>; John Crispin
> <[email protected]>; Sean Wang <[email protected]>; Mark Lee
> <[email protected]>; Matthias Brugger
> <[email protected]>; Heiner Kallweit <[email protected]>; Andrew
> Lunn <[email protected]>; Florian Fainelli <[email protected]>; Russell King
> <[email protected]>; Rob Herring <[email protected]>; Frank Rowand
> <[email protected]>
> Cc: [email protected]; [email protected]; linux-arm-
> [email protected]; [email protected];
> [email protected]; Bartosz Golaszewski
> <[email protected]>
> Subject: [PATCH v2 02/10] net: ethernet: ixgbe: don't call
> devm_mdiobus_free()
>
> From: Bartosz Golaszewski <[email protected]>
>
> The idea behind devres is that the release callbacks are called if probe fails. As
> we now check the return value of ixgbe_mii_bus_init(), we can drop the call
> devm_mdiobus_free() in error path as the release callback will be called
> automatically.
>
> Signed-off-by: Bartosz Golaszewski <[email protected]>
Acked-by: Jeff Kirsher <[email protected]>
> ---
> drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c | 14 +++-----------
> 1 file changed, 3 insertions(+), 11 deletions(-)