2017-09-14 14:04:40

by Bhumika Goyal

Subject: [PATCH] ALSA: oxygen: Xonar DG(X): make model_xonar_dg const

Make this const as it not modified anywhere. It is only used during a
copy operation. Also, add const to the declaration in header.

Signed-off-by: Bhumika Goyal <[email protected]>
---
sound/pci/oxygen/xonar_dg.h | 2 +-
sound/pci/oxygen/xonar_dg_mixer.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/sound/pci/oxygen/xonar_dg.h b/sound/pci/oxygen/xonar_dg.h
index d461df3..5a07cda 100644
--- a/sound/pci/oxygen/xonar_dg.h
+++ b/sound/pci/oxygen/xonar_dg.h
@@ -51,6 +51,6 @@ void dump_cs4245_registers(struct oxygen *chip,
void dg_resume(struct oxygen *chip);
void dg_cleanup(struct oxygen *chip);

-extern struct oxygen_model model_xonar_dg;
+extern const struct oxygen_model model_xonar_dg;

#endif
diff --git a/sound/pci/oxygen/xonar_dg_mixer.c b/sound/pci/oxygen/xonar_dg_mixer.c
index b885dac..d22fbe8 100644
--- a/sound/pci/oxygen/xonar_dg_mixer.c
+++ b/sound/pci/oxygen/xonar_dg_mixer.c
@@ -449,7 +449,7 @@ static int dg_mixer_init(struct oxygen *chip)
return 0;
}

-struct oxygen_model model_xonar_dg = {
+const struct oxygen_model model_xonar_dg = {
.longname = "C-Media Oxygen HD Audio",
.chip = "CMI8786",
.init = dg_init,
--
1.9.1

2017-09-14 18:40:48

by Clemens Ladisch

Subject: Re: [alsa-devel] [PATCH] ALSA: oxygen: Xonar DG(X): make model_xonar_dg const

Bhumika Goyal wrote:
> Make this const as it not modified anywhere. It is only used during a
> copy operation. Also, add const to the declaration in header.
>
> Signed-off-by: Bhumika Goyal <[email protected]>

Acked-by: Clemens Ladisch <[email protected]>

> ---
> sound/pci/oxygen/xonar_dg.h | 2 +-
> sound/pci/oxygen/xonar_dg_mixer.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/sound/pci/oxygen/xonar_dg.h b/sound/pci/oxygen/xonar_dg.h
> index d461df3..5a07cda 100644
> --- a/sound/pci/oxygen/xonar_dg.h
> +++ b/sound/pci/oxygen/xonar_dg.h
> @@ -51,6 +51,6 @@ void dump_cs4245_registers(struct oxygen *chip,
> void dg_resume(struct oxygen *chip);
> void dg_cleanup(struct oxygen *chip);
>
> -extern struct oxygen_model model_xonar_dg;
> +extern const struct oxygen_model model_xonar_dg;
>
> #endif
> diff --git a/sound/pci/oxygen/xonar_dg_mixer.c b/sound/pci/oxygen/xonar_dg_mixer.c
> index b885dac..d22fbe8 100644
> --- a/sound/pci/oxygen/xonar_dg_mixer.c
> +++ b/sound/pci/oxygen/xonar_dg_mixer.c
> @@ -449,7 +449,7 @@ static int dg_mixer_init(struct oxygen *chip)
> return 0;
> }
>
> -struct oxygen_model model_xonar_dg = {
> +const struct oxygen_model model_xonar_dg = {
> .longname = "C-Media Oxygen HD Audio",
> .chip = "CMI8786",
> .init = dg_init,

2017-09-18 13:48:40

by Takashi Iwai

Subject: Re: [PATCH] ALSA: oxygen: Xonar DG(X): make model_xonar_dg const

On Thu, 14 Sep 2017 16:04:15 +0200,
Bhumika Goyal wrote:
>
> Make this const as it not modified anywhere. It is only used during a
> copy operation. Also, add const to the declaration in header.
>
> Signed-off-by: Bhumika Goyal <[email protected]>

Applied, thanks.


Takashi