2020-04-16 11:38:18

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH 2/2] spi: dw: remove cs_control and poll_mode members from chip_data

On Thu, Apr 16, 2020 at 01:09:16PM +0200, Clement Leger wrote:
> Since these members were initialized only with previous dw_spi_chip
> struct members and that there is no user anymore, remove them. Along
> this removal, remove code path which were using these members.

This means that your first patch will break the build, to keep things
bisectable please do some combination of moving this before the first
patch and squashing it into the first patch.


Attachments:
(No filename) (463.00 B)
signature.asc (499.00 B)
Download all attachments

2020-04-16 19:01:32

by Clément Leger

[permalink] [raw]
Subject: Re: [PATCH 2/2] spi: dw: remove cs_control and poll_mode members from chip_data

Hi Mark,

Sorry, maybe the commit message was not clear enough but actually
these fields were not initialized so it does not break anything
(ie, the default values were always used).

Clément

----- On 16 Apr, 2020, at 13:35, Mark Brown [email protected] wrote:

> On Thu, Apr 16, 2020 at 01:09:16PM +0200, Clement Leger wrote:
>> Since these members were initialized only with previous dw_spi_chip
>> struct members and that there is no user anymore, remove them. Along
>> this removal, remove code path which were using these members.
>
> This means that your first patch will break the build, to keep things
> bisectable please do some combination of moving this before the first
> patch and squashing it into the first patch.