2020-10-11 18:26:33

by Rayagonda Kokatanur

[permalink] [raw]
Subject: [PATCH v1 4/6] i2c: iproc: fix typo in slave_isr function

Attachments:
(No filename) (960.00 B)
 smime.p7s (4.09 kB)
S/MIME Cryptographic Signature Download all attachments

2020-10-23 18:59:09

by Ray Jui

[permalink] [raw]
Subject: Re: [PATCH v1 4/6] i2c: iproc: fix typo in slave_isr function



On 10/11/2020 11:22 AM, Rayagonda Kokatanur wrote:
> Fix typo in bcm_iproc_i2c_slave_isr().
>
> Fixes: c245d94ed106 ("i2c: iproc: Add multi byte read-write support for slave mode")

This is merely a fix of typo in code comment and there's no functional
impact. Why do we need a Fixes tag on this (which indicates the fix
needs to be backported to LTS kernels)?

> Signed-off-by: Rayagonda Kokatanur <[email protected]>
> ---
> drivers/i2c/busses/i2c-bcm-iproc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-bcm-iproc.c b/drivers/i2c/busses/i2c-bcm-iproc.c
> index cd687696bf0b..7a235f9f5884 100644
> --- a/drivers/i2c/busses/i2c-bcm-iproc.c
> +++ b/drivers/i2c/busses/i2c-bcm-iproc.c
> @@ -382,7 +382,7 @@ static bool bcm_iproc_i2c_slave_isr(struct bcm_iproc_i2c_dev *iproc_i2c,
> if (status & BIT(IS_S_START_BUSY_SHIFT)) {
> i2c_slave_event(iproc_i2c->slave, I2C_SLAVE_STOP, &value);
> /*
> - * Enable interrupt for TX FIFO becomes empty and
> + * Disable interrupt for TX FIFO becomes empty and
> * less than PKT_LENGTH bytes were output on the SMBUS
> */
> val = iproc_i2c_rd_reg(iproc_i2c, IE_OFFSET);
>

Attachments:
smime.p7s (4.05 kB)
S/MIME Cryptographic Signature

2020-10-26 14:20:43

by Rayagonda Kokatanur

[permalink] [raw]
Subject: Re: [PATCH v1 4/6] i2c: iproc: fix typo in slave_isr function

On Fri, Oct 23, 2020 at 10:51 PM Ray Jui <[email protected]> wrote:
>
>
>
> On 10/11/2020 11:22 AM, Rayagonda Kokatanur wrote:
> > Fix typo in bcm_iproc_i2c_slave_isr().
> >
> > Fixes: c245d94ed106 ("i2c: iproc: Add multi byte read-write support for slave mode")
>
> This is merely a fix of typo in code comment and there's no functional
> impact. Why do we need a Fixes tag on this (which indicates the fix
> needs to be backported to LTS kernels)?

Thank you Ray.
I will remove Fixes tag and push patch v2.

Best regards,
Rayagonda

>
> > Signed-off-by: Rayagonda Kokatanur <[email protected]>
> > ---
> > drivers/i2c/busses/i2c-bcm-iproc.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/i2c/busses/i2c-bcm-iproc.c b/drivers/i2c/busses/i2c-bcm-iproc.c
> > index cd687696bf0b..7a235f9f5884 100644
> > --- a/drivers/i2c/busses/i2c-bcm-iproc.c
> > +++ b/drivers/i2c/busses/i2c-bcm-iproc.c
> > @@ -382,7 +382,7 @@ static bool bcm_iproc_i2c_slave_isr(struct bcm_iproc_i2c_dev *iproc_i2c,
> > if (status & BIT(IS_S_START_BUSY_SHIFT)) {
> > i2c_slave_event(iproc_i2c->slave, I2C_SLAVE_STOP, &value);
> > /*
> > - * Enable interrupt for TX FIFO becomes empty and
> > + * Disable interrupt for TX FIFO becomes empty and
> > * less than PKT_LENGTH bytes were output on the SMBUS
> > */
> > val = iproc_i2c_rd_reg(iproc_i2c, IE_OFFSET);
> >

Attachments:
smime.p7s (4.09 kB)
S/MIME Cryptographic Signature