2009-11-23 18:54:03

by Daniel J Blueman

[permalink] [raw]
Subject: [patch] twl4030: fix ELF section mismatch...

Since twl4030_probe is only called from functions in the init ELF
section, annotate it so.

Signed-off-by: Daniel J Blueman <[email protected]>

---
diff --git a/drivers/mfd/twl4030-core.c b/drivers/mfd/twl4030-core.c
index a1c47ee..2fe514d 100644
--- a/drivers/mfd/twl4030-core.c
+++ b/drivers/mfd/twl4030-core.c
@@ -763,7 +763,7 @@ static int twl4030_remove(struct i2c_client *client)
}

/* NOTE: this driver only handles a single twl4030/tps659x0 chip */
-static int
+static int __init
twl4030_probe(struct i2c_client *client, const struct i2c_device_id *id)
{
int status;
--
Daniel J Blueman


2009-11-24 23:36:21

by Samuel Ortiz

[permalink] [raw]
Subject: Re: [patch] twl4030: fix ELF section mismatch...

On Mon, Nov 23, 2009 at 06:54:06PM +0000, Daniel J Blueman wrote:
> Since twl4030_probe is only called from functions in the init ELF
> section, annotate it so.
>
> Signed-off-by: Daniel J Blueman <[email protected]>
Acked-by: Samuel Ortiz <[email protected]>

Mark, thanks for carrying this one with your twl4030 branch.

Cheers,
Samuel.

> ---
> diff --git a/drivers/mfd/twl4030-core.c b/drivers/mfd/twl4030-core.c
> index a1c47ee..2fe514d 100644
> --- a/drivers/mfd/twl4030-core.c
> +++ b/drivers/mfd/twl4030-core.c
> @@ -763,7 +763,7 @@ static int twl4030_remove(struct i2c_client *client)
> }
>
> /* NOTE: this driver only handles a single twl4030/tps659x0 chip */
> -static int
> +static int __init
> twl4030_probe(struct i2c_client *client, const struct i2c_device_id *id)
> {
> int status;
> --
> Daniel J Blueman

--
Intel Open Source Technology Centre
http://oss.intel.com/

2009-11-25 10:10:08

by Mark Brown

[permalink] [raw]
Subject: Re: [patch] twl4030: fix ELF section mismatch...

On Wed, Nov 25, 2009 at 12:37:55AM +0100, Samuel Ortiz wrote:
> On Mon, Nov 23, 2009 at 06:54:06PM +0000, Daniel J Blueman wrote:
> > Since twl4030_probe is only called from functions in the init ELF
> > section, annotate it so.
> >
> > Signed-off-by: Daniel J Blueman <[email protected]>

> Acked-by: Samuel Ortiz <[email protected]>

> Mark, thanks for carrying this one with your twl4030 branch.

Sure. Daniel, could you please resend the patch to me - I've deleted
the original.