2023-06-15 03:53:01

by 李扬韬

Subject: [PATCH] erofs: remove unnecessary goto

It's redundant, let's remove it.

Signed-off-by: Yangtao Li <[email protected]>
---
fs/erofs/super.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/fs/erofs/super.c b/fs/erofs/super.c
index 811ab66d805e..f48ce692094d 100644
--- a/fs/erofs/super.c
+++ b/fs/erofs/super.c
@@ -1016,10 +1016,8 @@ static int __init erofs_module_init(void)
sizeof(struct erofs_inode), 0,
SLAB_RECLAIM_ACCOUNT,
erofs_inode_init_once);
- if (!erofs_inode_cachep) {
- err = -ENOMEM;
- goto icache_err;
- }
+ if (!erofs_inode_cachep)
+ return -ENOMEM;

err = erofs_init_shrinker();
if (err)
@@ -1054,7 +1052,6 @@ static int __init erofs_module_init(void)
erofs_exit_shrinker();
shrinker_err:
kmem_cache_destroy(erofs_inode_cachep);
-icache_err:
return err;
}

--
2.39.0

2023-06-15 04:07:15

by Gao Xiang

Subject: Re: [PATCH] erofs: remove unnecessary goto

On 2023/6/15 11:45, Yangtao Li wrote:
> It's redundant, let's remove it.
>
> Signed-off-by: Yangtao Li <[email protected]>

Reviewed-by: Gao Xiang <[email protected]>

Thanks,
Gao Xiang

2023-06-15 04:46:20

by Jingbo Xu

Subject: Re: [PATCH] erofs: remove unnecessary goto

On 6/15/23 11:45 AM, Yangtao Li wrote:
> It's redundant, let's remove it.
>
> Signed-off-by: Yangtao Li <[email protected]>

Reviewed-by: Jingbo Xu <[email protected]>


> ---
> fs/erofs/super.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/fs/erofs/super.c b/fs/erofs/super.c
> index 811ab66d805e..f48ce692094d 100644
> --- a/fs/erofs/super.c
> +++ b/fs/erofs/super.c
> @@ -1016,10 +1016,8 @@ static int __init erofs_module_init(void)
> sizeof(struct erofs_inode), 0,
> SLAB_RECLAIM_ACCOUNT,
> erofs_inode_init_once);
> - if (!erofs_inode_cachep) {
> - err = -ENOMEM;
> - goto icache_err;
> - }
> + if (!erofs_inode_cachep)
> + return -ENOMEM;
>
> err = erofs_init_shrinker();
> if (err)
> @@ -1054,7 +1052,6 @@ static int __init erofs_module_init(void)
> erofs_exit_shrinker();
> shrinker_err:
> kmem_cache_destroy(erofs_inode_cachep);
> -icache_err:
> return err;
> }
>

--
Thanks,
Jingbo