2023-08-08 17:25:57

by Meng, Li (Jassmine)

Subject: [PATCH V1 6/6] Documentation: introduce AMD Pstate Preferrd Core mode kernel command line options

AMD Pstate driver support enable/disable Preferred core.
Default disabled on platforms supporting AMD Preferred Core.
Enable AMD Pstate Preferred Core with
"amd_prefcore=enable" added to the kernel command line.

Signed-off-by: Meng Li <[email protected]>
---
Documentation/admin-guide/kernel-parameters.txt | 5 +++++
1 file changed, 5 insertions(+)

diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
index 2de235d52fac..bc92e178431b 100644
--- a/Documentation/admin-guide/kernel-parameters.txt
+++ b/Documentation/admin-guide/kernel-parameters.txt
@@ -363,6 +363,11 @@
selects a performance level in this range and appropriate
to the current workload.

+ amd_prefcore=
+ [X86]
+ enable
+ Enable AMD Pstate Preferred Core.
+
amijoy.map= [HW,JOY] Amiga joystick support
Map of devices attached to JOY0DAT and JOY1DAT
Format: <a>,<b>
--
2.34.1

2023-08-08 18:50:38

by Mario Limonciello

Subject: Re: [PATCH V1 6/6] Documentation: introduce AMD Pstate Preferrd Core mode kernel command line options

On 8/8/2023 03:10, Meng Li wrote:
> AMD Pstate driver support enable/disable Preferred core.
> Default disabled on platforms supporting AMD Preferred Core.

Why default disabled?

Shouldn't this default enabled and then let users decide they don't want
to use it if it's causing a problem for them?

> Enable AMD Pstate Preferred Core with
> "amd_prefcore=enable" added to the kernel command line.
>
> Signed-off-by: Meng Li <[email protected]>
> ---
> Documentation/admin-guide/kernel-parameters.txt | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
> index 2de235d52fac..bc92e178431b 100644
> --- a/Documentation/admin-guide/kernel-parameters.txt
> +++ b/Documentation/admin-guide/kernel-parameters.txt
> @@ -363,6 +363,11 @@
> selects a performance level in this range and appropriate
> to the current workload.
>
> + amd_prefcore=
> + [X86]
> + enable
> + Enable AMD Pstate Preferred Core.
> +
> amijoy.map= [HW,JOY] Amiga joystick support
> Map of devices attached to JOY0DAT and JOY1DAT
> Format: <a>,<b>