2023-06-04 09:13:04

by Raphael Gallais-Pou

[permalink] [raw]
Subject: [PATCH] serial: st-asc: fix typo in property name

Changes the property name read in the driver according to the YAML.
According to device-tree documentation, property names should not
include underscores.

Signed-off-by: Raphael Gallais-Pou <[email protected]>
---
drivers/tty/serial/st-asc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/serial/st-asc.c b/drivers/tty/serial/st-asc.c
index 5215e6910f68..6ef99a037a9b 100644
--- a/drivers/tty/serial/st-asc.c
+++ b/drivers/tty/serial/st-asc.c
@@ -754,7 +754,7 @@ static struct asc_port *asc_of_get_asc_port(struct platform_device *pdev)

asc_ports[id].hw_flow_control = of_property_read_bool(np,
"uart-has-rtscts");
- asc_ports[id].force_m1 = of_property_read_bool(np, "st,force_m1");
+ asc_ports[id].force_m1 = of_property_read_bool(np, "st,force-m1");
asc_ports[id].port.line = id;
asc_ports[id].rts = NULL;

--
2.40.1



2023-06-05 12:19:19

by Patrice CHOTARD

[permalink] [raw]
Subject: Re: [PATCH] serial: st-asc: fix typo in property name

Hi Raphael

On 6/4/23 10:35, Raphael Gallais-Pou wrote:
> Changes the property name read in the driver according to the YAML.
> According to device-tree documentation, property names should not
> include underscores.
>
> Signed-off-by: Raphael Gallais-Pou <[email protected]>
> ---
> drivers/tty/serial/st-asc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/st-asc.c b/drivers/tty/serial/st-asc.c
> index 5215e6910f68..6ef99a037a9b 100644
> --- a/drivers/tty/serial/st-asc.c
> +++ b/drivers/tty/serial/st-asc.c
> @@ -754,7 +754,7 @@ static struct asc_port *asc_of_get_asc_port(struct platform_device *pdev)
>
> asc_ports[id].hw_flow_control = of_property_read_bool(np,
> "uart-has-rtscts");
> - asc_ports[id].force_m1 = of_property_read_bool(np, "st,force_m1");
> + asc_ports[id].force_m1 = of_property_read_bool(np, "st,force-m1");
> asc_ports[id].port.line = id;
> asc_ports[id].rts = NULL;
>

Reviewed-by: Patrice Chotard <[email protected]>

Thanks
Patrice