2023-03-15 05:49:42

by Greg Thelen

Subject: [PATCH] tools/resolve_btfids: Add libsubcmd to .gitignore

After building the kernel I see:
$ git status -s
?? tools/bpf/resolve_btfids/libbpf/

Commit af03299d8536 ("tools/resolve_btfids: Install subcmd headers")
started copying header files into
tools/bpf/resolve_btfids/libsubcmd/include/subcmd. These *.h files are
not covered by higher level wildcard gitignores.

gitignore the entire libsubcmd directory. It's created as part of build
and removed by clean.

Fixes: af03299d8536 ("tools/resolve_btfids: Install subcmd headers")
Signed-off-by: Greg Thelen <[email protected]>
---
tools/bpf/resolve_btfids/.gitignore | 1 +
1 file changed, 1 insertion(+)

diff --git a/tools/bpf/resolve_btfids/.gitignore b/tools/bpf/resolve_btfids/.gitignore
index 16913fffc985..52d5e9721d92 100644
--- a/tools/bpf/resolve_btfids/.gitignore
+++ b/tools/bpf/resolve_btfids/.gitignore
@@ -1,3 +1,4 @@
/fixdep
/resolve_btfids
/libbpf/
+/libsubcmd/
--
2.40.0.rc1.284.g88254d51c5-goog

2023-03-15 21:21:30

by John Fastabend

Subject: RE: [PATCH] tools/resolve_btfids: Add libsubcmd to .gitignore

Greg Thelen wrote:
> After building the kernel I see:
> $ git status -s
> ?? tools/bpf/resolve_btfids/libbpf/
>
> Commit af03299d8536 ("tools/resolve_btfids: Install subcmd headers")
> started copying header files into
> tools/bpf/resolve_btfids/libsubcmd/include/subcmd. These *.h files are
> not covered by higher level wildcard gitignores.
>
> gitignore the entire libsubcmd directory. It's created as part of build
> and removed by clean.
>
> Fixes: af03299d8536 ("tools/resolve_btfids: Install subcmd headers")
> Signed-off-by: Greg Thelen <[email protected]>
> ---
> tools/bpf/resolve_btfids/.gitignore | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/bpf/resolve_btfids/.gitignore b/tools/bpf/resolve_btfids/.gitignore
> index 16913fffc985..52d5e9721d92 100644
> --- a/tools/bpf/resolve_btfids/.gitignore
> +++ b/tools/bpf/resolve_btfids/.gitignore
> @@ -1,3 +1,4 @@
> /fixdep
> /resolve_btfids
> /libbpf/
> +/libsubcmd/
> --
> 2.40.0.rc1.284.g88254d51c5-goog
>

Thanks.

Acked-by: John Fastabend <[email protected]>

2023-03-15 21:21:50

by Ian Rogers

Subject: Re: [PATCH] tools/resolve_btfids: Add libsubcmd to .gitignore

On Tue, Mar 14, 2023 at 10:49 PM Greg Thelen <[email protected]> wrote:
>
> After building the kernel I see:
> $ git status -s
> ?? tools/bpf/resolve_btfids/libbpf/
>
> Commit af03299d8536 ("tools/resolve_btfids: Install subcmd headers")
> started copying header files into
> tools/bpf/resolve_btfids/libsubcmd/include/subcmd. These *.h files are
> not covered by higher level wildcard gitignores.
>
> gitignore the entire libsubcmd directory. It's created as part of build
> and removed by clean.
>
> Fixes: af03299d8536 ("tools/resolve_btfids: Install subcmd headers")
> Signed-off-by: Greg Thelen <[email protected]>

Acked-by: Ian Rogers <[email protected]>

Thanks!
Ian

> ---
> tools/bpf/resolve_btfids/.gitignore | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/bpf/resolve_btfids/.gitignore b/tools/bpf/resolve_btfids/.gitignore
> index 16913fffc985..52d5e9721d92 100644
> --- a/tools/bpf/resolve_btfids/.gitignore
> +++ b/tools/bpf/resolve_btfids/.gitignore
> @@ -1,3 +1,4 @@
> /fixdep
> /resolve_btfids
> /libbpf/
> +/libsubcmd/
> --
> 2.40.0.rc1.284.g88254d51c5-goog
>

2023-03-16 21:12:17

by Daniel Borkmann

Subject: Re: [PATCH] tools/resolve_btfids: Add libsubcmd to .gitignore

On 3/15/23 6:49 AM, Greg Thelen wrote:
> After building the kernel I see:
> $ git status -s
> ?? tools/bpf/resolve_btfids/libbpf/
>
> Commit af03299d8536 ("tools/resolve_btfids: Install subcmd headers")
> started copying header files into
> tools/bpf/resolve_btfids/libsubcmd/include/subcmd. These *.h files are
> not covered by higher level wildcard gitignores.
>
> gitignore the entire libsubcmd directory. It's created as part of build
> and removed by clean.
>
> Fixes: af03299d8536 ("tools/resolve_btfids: Install subcmd headers")
> Signed-off-by: Greg Thelen <[email protected]>

Already fixed in bpf-next by:

commit fd4cb29f2a3d54ec7b4e012300321601af10bd68
Author: Rong Tao <[email protected]>
Date: Sat Mar 4 23:17:04 2023 +0800

tools/resolve_btfids: Add /libsubcmd to .gitignore

Thanks,
Daniel