2023-03-23 13:17:17

by Khadija Kamran

Subject: [RESEND PATCH] staging: most: fix line ending with '(' in dim2

Splitting function header to multiple lines because of 80 characters per
line limit, results in ending the function call line with '('.
This leads to CHECK reported by checkpatch.pl

Move the function parameters right after the '(' in the function call
line. Align the rest of the parameters to the opening parenthesis.

Signed-off-by: Khadija Kamran <[email protected]>
---
drivers/staging/most/dim2/hal.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/most/dim2/hal.c b/drivers/staging/most/dim2/hal.c
index a5d40b5b138a..6abe3ab2b2cf 100644
--- a/drivers/staging/most/dim2/hal.c
+++ b/drivers/staging/most/dim2/hal.c
@@ -346,9 +346,8 @@ static void dim2_clear_ctram(void)
dim2_clear_ctr(ctr_addr);
}

-static void dim2_configure_channel(
- u8 ch_addr, u8 type, u8 is_tx, u16 dbr_address, u16 hw_buffer_size,
- u16 packet_length)
+static void dim2_configure_channel(u8 ch_addr, u8 type, u8 is_tx, u16 dbr_address,
+ u16 hw_buffer_size, u16 packet_length)
{
dim2_configure_cdt(ch_addr, dbr_address, hw_buffer_size, packet_length);
dim2_configure_cat(MLB_CAT, ch_addr, type, is_tx ? 1 : 0);
--
2.34.1

2023-03-23 15:13:36

by Greg Kroah-Hartman

Subject: Re: [RESEND PATCH] staging: most: fix line ending with '(' in dim2

On Thu, Mar 23, 2023 at 05:51:27PM +0500, Khadija Kamran wrote:
> Splitting function header to multiple lines because of 80 characters per
> line limit, results in ending the function call line with '('.
> This leads to CHECK reported by checkpatch.pl
>
> Move the function parameters right after the '(' in the function call
> line. Align the rest of the parameters to the opening parenthesis.
>
> Signed-off-by: Khadija Kamran <[email protected]>
> ---
> drivers/staging/most/dim2/hal.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)

Why is this a RESEND?

2023-03-24 22:24:45

by Ira Weiny

Subject: Re: [RESEND PATCH] staging: most: fix line ending with '(' in dim2

Khadija Kamran wrote:
> Splitting function header to multiple lines because of 80 characters per
> line limit, results in ending the function call line with '('.
> This leads to CHECK reported by checkpatch.pl
>
> Move the function parameters right after the '(' in the function call
> line. Align the rest of the parameters to the opening parenthesis.
>
> Signed-off-by: Khadija Kamran <[email protected]>
> ---
> drivers/staging/most/dim2/hal.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/most/dim2/hal.c b/drivers/staging/most/dim2/hal.c
> index a5d40b5b138a..6abe3ab2b2cf 100644
> --- a/drivers/staging/most/dim2/hal.c
> +++ b/drivers/staging/most/dim2/hal.c
> @@ -346,9 +346,8 @@ static void dim2_clear_ctram(void)
> dim2_clear_ctr(ctr_addr);
> }
>
> -static void dim2_configure_channel(
> - u8 ch_addr, u8 type, u8 is_tx, u16 dbr_address, u16 hw_buffer_size,
> - u16 packet_length)
> +static void dim2_configure_channel(u8 ch_addr, u8 type, u8 is_tx, u16 dbr_address,

NIT: This introduces a long (> 80 char) line for not a great reason.
Since you are changing it anyway how about?

static void dim2_configure_channel(u8 ch_addr, u8 type, u8 is_tx,
u16 dbr_address, u16 hw_buffer_size,
u16 packet_length)

Ira

> + u16 hw_buffer_size, u16 packet_length)

> {
> dim2_configure_cdt(ch_addr, dbr_address, hw_buffer_size, packet_length);
> dim2_configure_cat(MLB_CAT, ch_addr, type, is_tx ? 1 : 0);
> --
> 2.34.1
>
>