2023-03-23 13:21:20

by Khadija Kamran

Subject: [RESEND PATCH] staging: most: fix line ending with '(' in video

Splitting function header to multiple lines because of 80 characters per
line limit, results in ending the function call line with '('.
This leads to CHECK reported by checkpatch.pl

Move the function parameters right after the '(' in the function call
line.

Signed-off-by: Khadija Kamran <[email protected]>
---
drivers/staging/most/video/video.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/most/video/video.c b/drivers/staging/most/video/video.c
index ffa97ef21ea5..6254a5df2502 100644
--- a/drivers/staging/most/video/video.c
+++ b/drivers/staging/most/video/video.c
@@ -365,8 +365,7 @@ static const struct video_device comp_videodev_template = {

/**************************************************************************/

-static struct most_video_dev *get_comp_dev(
- struct most_interface *iface, int channel_idx)
+static struct most_video_dev *get_comp_dev(struct most_interface *iface, int channel_idx)
{
struct most_video_dev *mdev;
unsigned long flags;
--
2.34.1

2023-03-23 15:13:26

by Greg Kroah-Hartman

Subject: Re: [RESEND PATCH] staging: most: fix line ending with '(' in video

On Thu, Mar 23, 2023 at 05:54:23PM +0500, Khadija Kamran wrote:
> Splitting function header to multiple lines because of 80 characters per
> line limit, results in ending the function call line with '('.
> This leads to CHECK reported by checkpatch.pl
>
> Move the function parameters right after the '(' in the function call
> line.
>
> Signed-off-by: Khadija Kamran <[email protected]>
> ---
> drivers/staging/most/video/video.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)

Why is this a RESEND?

2023-03-24 22:25:25

by Ira Weiny

Subject: Re: [RESEND PATCH] staging: most: fix line ending with '(' in video

Khadija Kamran wrote:
> Splitting function header to multiple lines because of 80 characters per
> line limit, results in ending the function call line with '('.
> This leads to CHECK reported by checkpatch.pl
>
> Move the function parameters right after the '(' in the function call
> line.
>
> Signed-off-by: Khadija Kamran <[email protected]>
> ---
> drivers/staging/most/video/video.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/most/video/video.c b/drivers/staging/most/video/video.c
> index ffa97ef21ea5..6254a5df2502 100644
> --- a/drivers/staging/most/video/video.c
> +++ b/drivers/staging/most/video/video.c
> @@ -365,8 +365,7 @@ static const struct video_device comp_videodev_template = {
>
> /**************************************************************************/
>
> -static struct most_video_dev *get_comp_dev(
> - struct most_interface *iface, int channel_idx)
> +static struct most_video_dev *get_comp_dev(struct most_interface *iface, int channel_idx)

I know the 80 char limit is not strictly enforced anymore but I, and some
other maintainers, like to see it adhered to unless there is a really good
reason to violate it. How about?

static struct most_video_dev *get_comp_dev(struct most_interface *iface,
int channel_idx)

Ira

> {
> struct most_video_dev *mdev;
> unsigned long flags;
> --
> 2.34.1
>
>