2023-06-16 18:07:45

by Ira Weiny

[permalink] [raw]
Subject: Re: [PATCH] nvdimm: make nd_class variable static

Ben Dooks wrote:
> The nd_class is not used outside of drivers/nvdimm/bus.c and thus sparse
> is generating the following warning. Remove this by making it static:
>
> drivers/nvdimm/bus.c:28:14: warning: symbol 'nd_class' was not declared. Should it be static?

Reviewed-by: Ira Weiny <[email protected]>

> Signed-off-by: Ben Dooks <[email protected]>
> ---
> drivers/nvdimm/bus.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/nvdimm/bus.c b/drivers/nvdimm/bus.c
> index 954dbc105fc8..5852fe290523 100644
> --- a/drivers/nvdimm/bus.c
> +++ b/drivers/nvdimm/bus.c
> @@ -25,7 +25,7 @@
>
> int nvdimm_major;
> static int nvdimm_bus_major;
> -struct class *nd_class;
> +static struct class *nd_class;
> static DEFINE_IDA(nd_ida);
>
> static int to_nd_device_type(const struct device *dev)
> --
> 2.39.2
>