2021-05-26 08:03:30

by Randy Dunlap

Subject: [PATCH] MOUSE_ATARI: fix kconfig unmet dependency warning

MOUSE_ATARI should depend on INPUT_KEYBOARD since ATARI_KBD_CORE
depends on INPUT_KEYBOARD. This prevents MOUSE_ATARI from
selecting ATARI_KBD_CORE when INPUT_KEYBOARD is not set/enabled.

WARNING: unmet direct dependencies detected for ATARI_KBD_CORE
Depends on [n]: !UML && INPUT [=y] && INPUT_KEYBOARD [=n]
Selected by [y]:
- MOUSE_ATARI [=y] && !UML && INPUT [=y] && INPUT_MOUSE [=y] && ATARI [=y]

Fixes: c04cb856e20a ("m68k: Atari keyboard and mouse support.")
Signed-off-by: Randy Dunlap <[email protected]>
Cc: Michael Schmitz <[email protected]>
Cc: Roman Zippel <[email protected]>
Cc: Geert Uytterhoeven <[email protected]>
Cc: Dmitry Torokhov <[email protected]>
Cc: [email protected]
---
drivers/input/mouse/Kconfig | 1 +
1 file changed, 1 insertion(+)

--- linux-next-20210525.orig/drivers/input/mouse/Kconfig
+++ linux-next-20210525/drivers/input/mouse/Kconfig
@@ -348,6 +348,7 @@ config MOUSE_AMIGA

config MOUSE_ATARI
tristate "Atari mouse"
+ depends on INPUT_KEYBOARD
depends on ATARI
select ATARI_KBD_CORE
help

2021-05-26 20:30:22

by Michael Schmitz

Subject: Re: [PATCH] MOUSE_ATARI: fix kconfig unmet dependency warning

Randy,

On 26/05/21 7:03 pm, Randy Dunlap wrote:
> MOUSE_ATARI should depend on INPUT_KEYBOARD since ATARI_KBD_CORE
> depends on INPUT_KEYBOARD. This prevents MOUSE_ATARI from
> selecting ATARI_KBD_CORE when INPUT_KEYBOARD is not set/enabled.

Right you are! Thanks for spotting this.

Reviewed-by: Michael Schmitz <[email protected]>

>
> WARNING: unmet direct dependencies detected for ATARI_KBD_CORE
> Depends on [n]: !UML && INPUT [=y] && INPUT_KEYBOARD [=n]
> Selected by [y]:
> - MOUSE_ATARI [=y] && !UML && INPUT [=y] && INPUT_MOUSE [=y] && ATARI [=y]
>
> Fixes: c04cb856e20a ("m68k: Atari keyboard and mouse support.")
> Signed-off-by: Randy Dunlap <[email protected]>
> Cc: Michael Schmitz <[email protected]>
> Cc: Roman Zippel <[email protected]>
> Cc: Geert Uytterhoeven <[email protected]>
> Cc: Dmitry Torokhov <[email protected]>
> Cc: [email protected]
> ---
> drivers/input/mouse/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> --- linux-next-20210525.orig/drivers/input/mouse/Kconfig
> +++ linux-next-20210525/drivers/input/mouse/Kconfig
> @@ -348,6 +348,7 @@ config MOUSE_AMIGA
>
> config MOUSE_ATARI
> tristate "Atari mouse"
> + depends on INPUT_KEYBOARD
> depends on ATARI
> select ATARI_KBD_CORE
> help