2020-12-02 23:45:32

by Bhaumik Bhatt

Subject: [PATCH v3 1/7] bus: mhi: core: Allow receiving a STOP channel command response

Add support to receive the response to a STOP channel command to the
MHI bus. If a client would like to STOP a channel instead of issuing
a RESET to it, this would provide support for it.

Signed-off-by: Bhaumik Bhatt <[email protected]>
---
drivers/bus/mhi/core/main.c | 5 +++++
1 file changed, 5 insertions(+)

diff --git a/drivers/bus/mhi/core/main.c b/drivers/bus/mhi/core/main.c
index 702c31b..a7bb8a7 100644
--- a/drivers/bus/mhi/core/main.c
+++ b/drivers/bus/mhi/core/main.c
@@ -1193,6 +1193,11 @@ int mhi_send_cmd(struct mhi_controller *mhi_cntrl,
cmd_tre->dword[0] = MHI_TRE_CMD_RESET_DWORD0;
cmd_tre->dword[1] = MHI_TRE_CMD_RESET_DWORD1(chan);
break;
+ case MHI_CMD_STOP_CHAN:
+ cmd_tre->ptr = MHI_TRE_CMD_STOP_PTR;
+ cmd_tre->dword[0] = MHI_TRE_CMD_STOP_DWORD0;
+ cmd_tre->dword[1] = MHI_TRE_CMD_STOP_DWORD1(chan);
+ break;
case MHI_CMD_START_CHAN:
cmd_tre->ptr = MHI_TRE_CMD_START_PTR;
cmd_tre->dword[0] = MHI_TRE_CMD_START_DWORD0;
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

2020-12-03 00:20:44

by Hemant Kumar

Subject: Re: [PATCH v3 1/7] bus: mhi: core: Allow receiving a STOP channel command response

Hi Bhaumik,

On 12/2/20 3:40 PM, Bhaumik Bhatt wrote:
> Add support to receive the response to a STOP channel command to the
How about saying "Add support to send the STOP channel command ?
> MHI bus. If a client would like to STOP a channel instead of issuing
> a RESET to it, this would provide support for it.
>
> Signed-off-by: Bhaumik Bhatt <[email protected]>
> ---
> drivers/bus/mhi/core/main.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/bus/mhi/core/main.c b/drivers/bus/mhi/core/main.c
> index 702c31b..a7bb8a7 100644
> --- a/drivers/bus/mhi/core/main.c
> +++ b/drivers/bus/mhi/core/main.c
> @@ -1193,6 +1193,11 @@ int mhi_send_cmd(struct mhi_controller *mhi_cntrl,
> cmd_tre->dword[0] = MHI_TRE_CMD_RESET_DWORD0;
> cmd_tre->dword[1] = MHI_TRE_CMD_RESET_DWORD1(chan);
> break;
> + case MHI_CMD_STOP_CHAN:
> + cmd_tre->ptr = MHI_TRE_CMD_STOP_PTR;
> + cmd_tre->dword[0] = MHI_TRE_CMD_STOP_DWORD0;
> + cmd_tre->dword[1] = MHI_TRE_CMD_STOP_DWORD1(chan);
> + break;
> case MHI_CMD_START_CHAN:
> cmd_tre->ptr = MHI_TRE_CMD_START_PTR;
> cmd_tre->dword[0] = MHI_TRE_CMD_START_DWORD0;
>

Thanks,
Hemant
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

2020-12-04 01:47:45

by Bhaumik Bhatt

Subject: Re: [PATCH v3 1/7] bus: mhi: core: Allow receiving a STOP channel command response

On 2020-12-02 04:15 PM, Hemant Kumar wrote:
> Hi Bhaumik,
>
> On 12/2/20 3:40 PM, Bhaumik Bhatt wrote:
>> Add support to receive the response to a STOP channel command to the
> How about saying "Add support to send the STOP channel command ?
Addressed in v4.
>> MHI bus. If a client would like to STOP a channel instead of issuing
>> a RESET to it, this would provide support for it.
>>
>> Signed-off-by: Bhaumik Bhatt <[email protected]>
>> ---
>> drivers/bus/mhi/core/main.c | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/drivers/bus/mhi/core/main.c b/drivers/bus/mhi/core/main.c
>> index 702c31b..a7bb8a7 100644
>> --- a/drivers/bus/mhi/core/main.c
>> +++ b/drivers/bus/mhi/core/main.c
>> @@ -1193,6 +1193,11 @@ int mhi_send_cmd(struct mhi_controller
>> *mhi_cntrl,
>> cmd_tre->dword[0] = MHI_TRE_CMD_RESET_DWORD0;
>> cmd_tre->dword[1] = MHI_TRE_CMD_RESET_DWORD1(chan);
>> break;
>> + case MHI_CMD_STOP_CHAN:
>> + cmd_tre->ptr = MHI_TRE_CMD_STOP_PTR;
>> + cmd_tre->dword[0] = MHI_TRE_CMD_STOP_DWORD0;
>> + cmd_tre->dword[1] = MHI_TRE_CMD_STOP_DWORD1(chan);
>> + break;
>> case MHI_CMD_START_CHAN:
>> cmd_tre->ptr = MHI_TRE_CMD_START_PTR;
>> cmd_tre->dword[0] = MHI_TRE_CMD_START_DWORD0;
>>
>
> Thanks,
> Hemant

Thanks,
Bhaumik
---
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora
Forum,
a Linux Foundation Collaborative Project