2018-01-16 15:45:43

by Shiju Jose

[permalink] [raw]
Subject: [1/3] arm64: defconfig: enable CONFIG_ACPI_APEI_MEMORY_FAILURE

Enable ACPI APEI MEMORY FAILURE option for ARM64,
so that memory errors will be handled.

Signed-off-by: Shiju Jose <[email protected]>
---
arch/arm64/configs/defconfig | 2 ++
1 file changed, 2 insertions(+)

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index 6356c6d..9144e17 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -86,6 +86,7 @@ CONFIG_SCHED_MC=y
CONFIG_NUMA=y
CONFIG_PREEMPT=y
CONFIG_KSM=y
+CONFIG_MEMORY_FAILURE=y
CONFIG_TRANSPARENT_HUGEPAGE=y
CONFIG_CMA=y
CONFIG_SECCOMP=y
@@ -567,6 +568,7 @@ CONFIG_ACPI=y
CONFIG_ACPI_APEI=y
CONFIG_ACPI_APEI_GHES=y
CONFIG_ACPI_APEI_PCIEAER=y
+CONFIG_ACPI_APEI_MEMORY_FAILURE=y
CONFIG_EXT2_FS=y
CONFIG_EXT3_FS=y
CONFIG_EXT4_FS_POSIX_ACL=y
--
1.9.1



2018-01-16 16:11:05

by Timur Tabi

[permalink] [raw]
Subject: Re: [1/3] arm64: defconfig: enable CONFIG_ACPI_APEI_MEMORY_FAILURE

On 01/16/2018 09:45 AM, [email protected] wrote:
> Enable ACPI APEI MEMORY FAILURE option for ARM64,
> so that memory errors will be handled.
>
> Signed-off-by: Shiju Jose<[email protected]>

All three patches:

Acked-by: Timur Tabi <[email protected]>

QDT definitely would like to see these patches merged into 4.16.

--
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
Technologies, Inc. Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.

2018-01-19 15:07:56

by Arnd Bergmann

[permalink] [raw]
Subject: Re: [1/3] arm64: defconfig: enable CONFIG_ACPI_APEI_MEMORY_FAILURE

On Tue, Jan 16, 2018 at 5:10 PM, Timur Tabi <[email protected]> wrote:
> On 01/16/2018 09:45 AM, [email protected] wrote:
>>
>> Enable ACPI APEI MEMORY FAILURE option for ARM64,
>> so that memory errors will be handled.
>>
>> Signed-off-by: Shiju Jose<[email protected]>
>
>
> All three patches:
>
> Acked-by: Timur Tabi <[email protected]>
>
> QDT definitely would like to see these patches merged into 4.16.

Applied all three to next/soc with your ack, thanks!

Shiju, there was a small problem with the second patch, which did not
apply cleanly, but I fixed it up. It might have been easier to get a pull
request through Wei Xu for this, and it would also help to send things
a lot earlier rather than just before the merge window.

Arnd

2018-01-19 15:12:13

by Shiju Jose

[permalink] [raw]
Subject: RE: [1/3] arm64: defconfig: enable CONFIG_ACPI_APEI_MEMORY_FAILURE

Thanks Arnd.

Regards,
Shiju

> -----Original Message-----
> From: [email protected] [mailto:[email protected]] On Behalf
> Of Arnd Bergmann
> Sent: 19 January 2018 15:07
> To: Timur Tabi
> Cc: Shiju Jose; Linux ARM; Linux Kernel Mailing List; Catalin Marinas;
> Will Deacon; Gregory CLEMENT; xuwei (O); Olof Johansson; Masahiro
> Yamada; Rob Herring; Heiko Stuebner; Krzysztof Kozlowski; Ard
> Biesheuvel; [email protected]; Linuxarm; Zhengqiang (turing)
> Subject: Re: [1/3] arm64: defconfig: enable
> CONFIG_ACPI_APEI_MEMORY_FAILURE
>
> On Tue, Jan 16, 2018 at 5:10 PM, Timur Tabi <[email protected]>
> wrote:
> > On 01/16/2018 09:45 AM, [email protected] wrote:
> >>
> >> Enable ACPI APEI MEMORY FAILURE option for ARM64, so that memory
> >> errors will be handled.
> >>
> >> Signed-off-by: Shiju Jose<[email protected]>
> >
> >
> > All three patches:
> >
> > Acked-by: Timur Tabi <[email protected]>
> >
> > QDT definitely would like to see these patches merged into 4.16.
>
> Applied all three to next/soc with your ack, thanks!
>
> Shiju, there was a small problem with the second patch, which did not
> apply cleanly, but I fixed it up. It might have been easier to get a
> pull request through Wei Xu for this, and it would also help to send
> things a lot earlier rather than just before the merge window.
>
> Arnd

2018-01-19 16:02:56

by Wei Xu

[permalink] [raw]
Subject: Re: [1/3] arm64: defconfig: enable CONFIG_ACPI_APEI_MEMORY_FAILURE

Hi Arnd,

On 2018/1/19 15:06, Arnd Bergmann wrote:
> On Tue, Jan 16, 2018 at 5:10 PM, Timur Tabi <[email protected]> wrote:
>> On 01/16/2018 09:45 AM, [email protected] wrote:
>>>
>>> Enable ACPI APEI MEMORY FAILURE option for ARM64,
>>> so that memory errors will be handled.
>>>
>>> Signed-off-by: Shiju Jose<[email protected]>
>>
>>
>> All three patches:
>>
>> Acked-by: Timur Tabi <[email protected]>
>>
>> QDT definitely would like to see these patches merged into 4.16.
>
> Applied all three to next/soc with your ack, thanks!
>
> Shiju, there was a small problem with the second patch, which did not
> apply cleanly, but I fixed it up. It might have been easier to get a pull
> request through Wei Xu for this, and it would also help to send things
> a lot earlier rather than just before the merge window.

Thank you so much!
I planned to pick up them after 4.16-rc1
since it is too close to the merge window.

Best Regards,
Wei

>
> Arnd
>
> .
>


2018-01-19 16:23:21

by Arnd Bergmann

[permalink] [raw]
Subject: Re: [1/3] arm64: defconfig: enable CONFIG_ACPI_APEI_MEMORY_FAILURE

On Fri, Jan 19, 2018 at 5:01 PM, Wei Xu <[email protected]> wrote:
> Hi Arnd,
>
> On 2018/1/19 15:06, Arnd Bergmann wrote:
>> On Tue, Jan 16, 2018 at 5:10 PM, Timur Tabi <[email protected]> wrote:
>>> On 01/16/2018 09:45 AM, [email protected] wrote:
>>>>
>>>> Enable ACPI APEI MEMORY FAILURE option for ARM64,
>>>> so that memory errors will be handled.
>>>>
>>>> Signed-off-by: Shiju Jose<[email protected]>
>>>
>>>
>>> All three patches:
>>>
>>> Acked-by: Timur Tabi <[email protected]>
>>>
>>> QDT definitely would like to see these patches merged into 4.16.
>>
>> Applied all three to next/soc with your ack, thanks!
>>
>> Shiju, there was a small problem with the second patch, which did not
>> apply cleanly, but I fixed it up. It might have been easier to get a pull
>> request through Wei Xu for this, and it would also help to send things
>> a lot earlier rather than just before the merge window.
>
> Thank you so much!
> I planned to pick up them after 4.16-rc1
> since it is too close to the merge window.

That would have been ok, too, of course. I mainly picked them up as they
look trivial and harmless, and Timur also weighed in here. I don't see
exactly how they ended up in my arm-soc mail folder, I assumed that
they had been addressed to:[email protected], but that doesn't actually
appear to be the case ;-)

Arnd