2024-01-29 08:57:34

by Tian, Kevin

Subject: RE: [PATCH v12 1/5] PCI: make pci_dev_is_disconnected() helper public for other drivers

> From: Ethan Zhao <[email protected]>
> Sent: Monday, January 29, 2024 11:49 AM
>
> Make pci_dev_is_disconnected() public so that it can be called from
> Intel VT-d driver to quickly fix/workaround the surprise removal
> unplug hang issue for those ATS capable devices on PCIe switch downstream
> hotplug capable ports.
>
> Beside pci_device_is_present() function, this one has no config space

s/Beside/Unlike/

> space access, so is light enough to optimize the normal pure surprise
> removal and safe removal flow.

somehow this paragraph belongs to the patch using it. The 1st paragraph
is sufficient for the reason of exposure.

2024-01-30 09:05:55

by Ethan Zhao

Subject: Re: [PATCH v12 1/5] PCI: make pci_dev_is_disconnected() helper public for other drivers

On 1/29/2024 4:50 PM, Tian, Kevin wrote:
>> From: Ethan Zhao <[email protected]>
>> Sent: Monday, January 29, 2024 11:49 AM
>>
>> Make pci_dev_is_disconnected() public so that it can be called from
>> Intel VT-d driver to quickly fix/workaround the surprise removal
>> unplug hang issue for those ATS capable devices on PCIe switch downstream
>> hotplug capable ports.
>>
>> Beside pci_device_is_present() function, this one has no config space
> s/Beside/Unlike/
>
>> space access, so is light enough to optimize the normal pure surprise
>> removal and safe removal flow.
> somehow this paragraph belongs to the patch using it. The 1st paragraph
> is sufficient for the reason of exposure.

pci_device_is_present() is aleardy exported symbol, why not just use it ?

Also try to make it clear, the difference and justification.


Thanks,
Ethan

2024-01-30 10:11:47

by Ethan Zhao

Subject: Re: [PATCH v12 1/5] PCI: make pci_dev_is_disconnected() helper public for other drivers

On 1/29/2024 4:50 PM, Tian, Kevin wrote:
>> From: Ethan Zhao <[email protected]>
>> Sent: Monday, January 29, 2024 11:49 AM
>>
>> Make pci_dev_is_disconnected() public so that it can be called from
>> Intel VT-d driver to quickly fix/workaround the surprise removal
>> unplug hang issue for those ATS capable devices on PCIe switch downstream
>> hotplug capable ports.
>>
>> Beside pci_device_is_present() function, this one has no config space
> s/Beside/Unlike/

Beside means 'comparing with' here, perhaps it is not clear enough

or there is syntax error if used here ?



Thanks,

Ethan

>
>> space access, so is light enough to optimize the normal pure surprise
>> removal and safe removal flow.
> somehow this paragraph belongs to the patch using it. The 1st paragraph
> is sufficient for the reason of exposure.