On Mon, Oct 24, 2022 at 07:48:07PM +0800, Dongliang Mu wrote:
> The commit 1149108e2fbf ("can: mscan: improve clock API use
> ") only adds put_clock in mpc5xxx_can_remove function, forgetting to add
Strange indentation. Why the '")' part can't be on the previous line?
> put_clock in the error handling code.
>
> Fix this bug by adding put_clock in the error handling code.
--
With Best Regards,
Andy Shevchenko
> On Oct 24, 2022, at 20:00, Andy Shevchenko <[email protected]> wrote:
>
> On Mon, Oct 24, 2022 at 07:48:07PM +0800, Dongliang Mu wrote:
>> The commit 1149108e2fbf ("can: mscan: improve clock API use
>> ") only adds put_clock in mpc5xxx_can_remove function, forgetting to add
>
> Strange indentation. Why the '")' part can't be on the previous line?
:/ it is automatically done by vim in `git commit -a -s -e`. I can adjust this part in v2 patch.
>
>> put_clock in the error handling code.
>>
>> Fix this bug by adding put_clock in the error handling code.
>
> --
> With Best Regards,
> Andy Shevchenko
>
On 25.10.2022 10:29:50, Dongliang Mu wrote:
>
>
> > On Oct 24, 2022, at 20:00, Andy Shevchenko <[email protected]> wrote:
> >
> > On Mon, Oct 24, 2022 at 07:48:07PM +0800, Dongliang Mu wrote:
> >> The commit 1149108e2fbf ("can: mscan: improve clock API use
> >> ") only adds put_clock in mpc5xxx_can_remove function, forgetting to add
> >
> > Strange indentation. Why the '")' part can't be on the previous line?
>
> :/ it is automatically done by vim in `git commit -a -s -e`. I can
> adjust this part in v2 patch.
Fixed while applying the patch.
Thanks,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |