2017-06-16 09:55:15

by Arvind Yadav

Subject: [PATCH] block: swim3: make of_device_ids const.

of_device_ids are not supposed to change at runtime. All functions
working with of_device_ids provided by <linux/of.h> work with const
of_device_ids. So mark the non-const structs as const.

File size before:
text data bss dec hex filename
8908 1096 624 10628 2984 drivers/block/swim3.o

File size after constify swim3_match:
text data bss dec hex filename
9708 296 624 10628 2984 drivers/block/swim3.o

Signed-off-by: Arvind Yadav <[email protected]>
---
drivers/block/swim3.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/block/swim3.c b/drivers/block/swim3.c
index ba4809c..7f72f8d 100644
--- a/drivers/block/swim3.c
+++ b/drivers/block/swim3.c
@@ -1245,7 +1245,7 @@ static int swim3_attach(struct macio_dev *mdev,
return 0;
}

-static struct of_device_id swim3_match[] =
+static const struct of_device_id swim3_match[] =
{
{
.name = "swim3",
--
1.9.1

2017-06-16 11:48:32

by Johannes Thumshirn

Subject: Re: [PATCH] block: swim3: make of_device_ids const.

On Fri, Jun 16, 2017 at 03:24:39PM +0530, Arvind Yadav wrote:
> of_device_ids are not supposed to change at runtime. All functions
> working with of_device_ids provided by <linux/of.h> work with const
> of_device_ids. So mark the non-const structs as const.
>
> File size before:
> text data bss dec hex filename
> 8908 1096 624 10628 2984 drivers/block/swim3.o
>
> File size after constify swim3_match:
> text data bss dec hex filename
> 9708 296 624 10628 2984 drivers/block/swim3.o
>
> Signed-off-by: Arvind Yadav <[email protected]>
> ---


Reviewed-by: Johannes Thumshirn <[email protected]>
--
Johannes Thumshirn Storage
[email protected] +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N?rnberg
GF: Felix Imend?rffer, Jane Smithard, Graham Norton
HRB 21284 (AG N?rnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850

2017-06-16 15:49:46

by Jens Axboe

Subject: Re: [PATCH] block: swim3: make of_device_ids const.

On 06/16/2017 03:54 AM, Arvind Yadav wrote:
> of_device_ids are not supposed to change at runtime. All functions
> working with of_device_ids provided by <linux/of.h> work with const
> of_device_ids. So mark the non-const structs as const.
>
> File size before:
> text data bss dec hex filename
> 8908 1096 624 10628 2984 drivers/block/swim3.o
>
> File size after constify swim3_match:
> text data bss dec hex filename
> 9708 296 624 10628 2984 drivers/block/swim3.o

Applied, thanks.

--
Jens Axboe