Hi Mark,
> -----Original Message-----
> From: Mark Brown <[email protected]>
> Sent: Friday, September 11, 2020 6:04 PM
> To: Ashish Kumar <[email protected]>
> Cc: kuldip dwivedi <[email protected]>; Yogesh Gaur
> <[email protected]>; [email protected]; linux-
> [email protected]; Varun Sethi <[email protected]>; Arokia Samy
> <[email protected]>; Ard Biesheuvel <[email protected]>;
> Samer El-Haj-Mahmoud <[email protected]>; Paul Yang
> <[email protected]>
> Subject: Re: [EXT] [PATCH v2] spi: spi-nxp-fspi: Add ACPI support
>
> On Fri, Sep 11, 2020 at 12:28:47PM +0000, Ashish Kumar wrote:
> > > Signed-off-by: kuldip dwivedi <[email protected]>
>
> > Please capture version change summary.
> >
> > Regards
> > Ashish
>
> It's there:
It did not mentioned about removing SWRST, which was present in v1.
v2:Notes Looked very similar to v1.
Regards
Ashish
>
> > >
> > > Notes:
> > > 1. Add ACPI match table, NXP members are added to confirm HID for
> FSPI
> > > 2. Change the DT specific APIs to device property APIs
> > > so that same API can be used in DT and ACPi mode.
> > > 3. Omit clock configuration part - in ACPI world, the firmware
> > > is responsible for clock maintenance.
> > > 4. This patch is tested on LX2160A platform
> -----Original Message-----
> From: Ashish Kumar <[email protected]>
> Sent: Friday, September 11, 2020 7:03 PM
> To: Mark Brown <[email protected]>
> Cc: kuldip dwivedi <[email protected]>; Yogesh Gaur
> <[email protected]>; [email protected]; linux-
> [email protected]; Varun Sethi <[email protected]>; Arokia Samy
> <[email protected]>; Ard Biesheuvel <[email protected]>; Samer
El-
> Haj-Mahmoud <[email protected]>; Paul Yang
> <[email protected]>
> Subject: RE: [EXT] [PATCH v2] spi: spi-nxp-fspi: Add ACPI support
>
> Hi Mark,
>
> > -----Original Message-----
> > From: Mark Brown <[email protected]>
> > Sent: Friday, September 11, 2020 6:04 PM
> > To: Ashish Kumar <[email protected]>
> > Cc: kuldip dwivedi <[email protected]>; Yogesh Gaur
> > <[email protected]>; [email protected]; linux-
> > [email protected]; Varun Sethi <[email protected]>; Arokia Samy
> > <[email protected]>; Ard Biesheuvel <[email protected]>; Samer
> > El-Haj-Mahmoud <[email protected]>; Paul Yang
> > <[email protected]>
> > Subject: Re: [EXT] [PATCH v2] spi: spi-nxp-fspi: Add ACPI support
> >
> > On Fri, Sep 11, 2020 at 12:28:47PM +0000, Ashish Kumar wrote:
> > > > Signed-off-by: kuldip dwivedi <[email protected]>
> >
> > > Please capture version change summary.
> > >
> > > Regards
> > > Ashish
> >
> > It's there:
> It did not mentioned about removing SWRST, which was present in v1.
> v2:Notes Looked very similar to v1.
Removed SWRST changes just to keep functionality same in ACP and DT mode,
I will post that change separately if It will be required. For tracking I
am adding this
point in notes
>
> Regards
> Ashish
> >
> > > >
> > > > Notes:
> > > > 1. Add ACPI match table, NXP members are added to confirm HID
> > > > for
> > FSPI
> > > > 2. Change the DT specific APIs to device property APIs
> > > > so that same API can be used in DT and ACPi mode.
> > > > 3. Omit clock configuration part - in ACPI world, the firmware
> > > > is responsible for clock maintenance.
> > > > 4. This patch is tested on LX2160A platform
5. SWRST reset changes are removed from v1 as to keep functionality
same in ACP and DT mode, I will post that change separately if It will be
required