2017-04-10 02:15:23

by NeilBrown

[permalink] [raw]
Subject: [PATCH] scsi: ibmvfc: don't check for failure from mempool_alloc()


mempool_alloc() cannot fail when passed GFP_NOIO or any
other gfp setting that is permitted to sleep.
So remove this pointless code.

Signed-off-by: NeilBrown <[email protected]>
---
drivers/scsi/ibmvscsi/ibmvfc.c | 6 ------
1 file changed, 6 deletions(-)

diff --git a/drivers/scsi/ibmvscsi/ibmvfc.c b/drivers/scsi/ibmvscsi/ibmvfc.c
index 2c92dabb55f6..26cd3c28186a 100644
--- a/drivers/scsi/ibmvscsi/ibmvfc.c
+++ b/drivers/scsi/ibmvscsi/ibmvfc.c
@@ -3910,12 +3910,6 @@ static int ibmvfc_alloc_target(struct ibmvfc_host *vhost, u64 scsi_id)
spin_unlock_irqrestore(vhost->host->host_lock, flags);

tgt = mempool_alloc(vhost->tgt_pool, GFP_NOIO);
- if (!tgt) {
- dev_err(vhost->dev, "Target allocation failure for scsi id %08llx\n",
- scsi_id);
- return -ENOMEM;
- }
-
memset(tgt, 0, sizeof(*tgt));
tgt->scsi_id = scsi_id;
tgt->new_scsi_id = scsi_id;
--
2.12.2

Attachments:
signature.asc (832.00 B)

2017-04-17 19:03:15

by Tyrel Datwyler

[permalink] [raw]
Subject: Re: [PATCH] scsi: ibmvfc: don't check for failure from mempool_alloc()

On 04/09/2017 07:15 PM, NeilBrown wrote:
>
> mempool_alloc() cannot fail when passed GFP_NOIO or any
> other gfp setting that is permitted to sleep.
> So remove this pointless code.
>
> Signed-off-by: NeilBrown <[email protected]>

Acked-by: Tyrel Datwyler <[email protected]>

> ---
> drivers/scsi/ibmvscsi/ibmvfc.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/scsi/ibmvscsi/ibmvfc.c b/drivers/scsi/ibmvscsi/ibmvfc.c
> index 2c92dabb55f6..26cd3c28186a 100644
> --- a/drivers/scsi/ibmvscsi/ibmvfc.c
> +++ b/drivers/scsi/ibmvscsi/ibmvfc.c
> @@ -3910,12 +3910,6 @@ static int ibmvfc_alloc_target(struct ibmvfc_host *vhost, u64 scsi_id)
> spin_unlock_irqrestore(vhost->host->host_lock, flags);
>
> tgt = mempool_alloc(vhost->tgt_pool, GFP_NOIO);
> - if (!tgt) {
> - dev_err(vhost->dev, "Target allocation failure for scsi id %08llx\n",
> - scsi_id);
> - return -ENOMEM;
> - }
> -
> memset(tgt, 0, sizeof(*tgt));
> tgt->scsi_id = scsi_id;
> tgt->new_scsi_id = scsi_id;
>

2017-04-19 01:51:43

by Martin K. Petersen

[permalink] [raw]
Subject: Re: [PATCH] scsi: ibmvfc: don't check for failure from mempool_alloc()

NeilBrown <[email protected]> writes:

> mempool_alloc() cannot fail when passed GFP_NOIO or any other gfp
> setting that is permitted to sleep. So remove this pointless code.

Applied to 4.12/scsi-queue. Thanks!

--
Martin K. Petersen Oracle Linux Engineering