2024-01-08 14:09:10

by Lukas Bulwahn

Subject: [PATCH] MAINTAINERS: use tabs in CONFIDENTIAL COMPUTING THREAT MODEL section

Commit 1f597b1a6ec2 ("docs: security: Confidential computing intro and
threat model for x86 virtualization") adds new documentation and a
corresponding MAINTAINERS section. It however uses spaces instead of a
single tab for all the entries in that MAINTAINERS section.

Although, the get_maintainer.pl script handles spaces instead of tabs
silently, the MAINTAINERS will quickly get into a messy state with
different indentations throughout the file. So, the checkpatch.pl script
complains when spaces instead of a single tab are used.

Fix this recently added section using tabs instead of spaces.

Fixes: 1f597b1a6ec2 ("docs: security: Confidential computing intro and threat model for x86 virtualization")
Signed-off-by: Lukas Bulwahn <[email protected]>
---
MAINTAINERS | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index fa67e2624723..c76884e40434 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -5296,10 +5296,10 @@ W: http://accessrunner.sourceforge.net/
F: drivers/usb/atm/cxacru.c

CONFIDENTIAL COMPUTING THREAT MODEL FOR X86 VIRTUALIZATION (SNP/TDX)
-M: Elena Reshetova <[email protected]>
-M: Carlos Bilbao <[email protected]>
-S: Maintained
-F: Documentation/security/snp-tdx-threat-model.rst
+M: Elena Reshetova <[email protected]>
+M: Carlos Bilbao <[email protected]>
+S: Maintained
+F: Documentation/security/snp-tdx-threat-model.rst

CONFIGFS
M: Joel Becker <[email protected]>
--
2.17.1

2024-01-08 16:02:07

by Bilbao, Carlos

Subject: Re: [PATCH] MAINTAINERS: use tabs in CONFIDENTIAL COMPUTING THREAT MODEL section

Hello,

On 1/8/24 08:08, Lukas Bulwahn wrote:
> Commit 1f597b1a6ec2 ("docs: security: Confidential computing intro and
> threat model for x86 virtualization") adds new documentation and a
> corresponding MAINTAINERS section. It however uses spaces instead of a
> single tab for all the entries in that MAINTAINERS section.
>
> Although, the get_maintainer.pl script handles spaces instead of tabs
> silently, the MAINTAINERS will quickly get into a messy state with
> different indentations throughout the file. So, the checkpatch.pl script
> complains when spaces instead of a single tab are used.
>
> Fix this recently added section using tabs instead of spaces.
>
> Fixes: 1f597b1a6ec2 ("docs: security: Confidential computing intro and threat model for x86 virtualization")
> Signed-off-by: Lukas Bulwahn <[email protected]>

Jakub has already addressed this issue with the patch "[PATCH docs]
MAINTAINERS: use tabs for indent of CONFIDENTIAL COMPUTING THREAT MODEL"
from 1/3/24. Also, I recommend refraining from using the 'Fixes' tag for
things of this nature. NACK.

> ---
> MAINTAINERS | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index fa67e2624723..c76884e40434 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -5296,10 +5296,10 @@ W: http://accessrunner.sourceforge.net/
> F: drivers/usb/atm/cxacru.c
>
> CONFIDENTIAL COMPUTING THREAT MODEL FOR X86 VIRTUALIZATION (SNP/TDX)
> -M: Elena Reshetova <[email protected]>
> -M: Carlos Bilbao <[email protected]>
> -S: Maintained
> -F: Documentation/security/snp-tdx-threat-model.rst
> +M: Elena Reshetova <[email protected]>
> +M: Carlos Bilbao <[email protected]>
> +S: Maintained
> +F: Documentation/security/snp-tdx-threat-model.rst
>
> CONFIGFS
> M: Joel Becker <[email protected]>

Thanks,
Carlos