2023-10-12 06:12:22

by Abel Vesa

Subject: [PATCH] soc: qcom: llcc: Fix LLCC_TRP_ATTR2_CFGn offset

According to documentation, it has increments of 4, not 8.

Fixes: c72ca343f911 ("soc: qcom: llcc: Add v4.1 HW version support")
Reported-by: Umnathi Chalicheemala <[email protected]>
Signed-off-by: Abel Vesa <[email protected]>
---
drivers/soc/qcom/llcc-qcom.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/soc/qcom/llcc-qcom.c b/drivers/soc/qcom/llcc-qcom.c
index 674abd0d6700..fb4085b7cb19 100644
--- a/drivers/soc/qcom/llcc-qcom.c
+++ b/drivers/soc/qcom/llcc-qcom.c
@@ -47,7 +47,7 @@
#define LLCC_TRP_STATUSn(n) (4 + n * SZ_4K)
#define LLCC_TRP_ATTR0_CFGn(n) (0x21000 + SZ_8 * n)
#define LLCC_TRP_ATTR1_CFGn(n) (0x21004 + SZ_8 * n)
-#define LLCC_TRP_ATTR2_CFGn(n) (0x21100 + SZ_8 * n)
+#define LLCC_TRP_ATTR2_CFGn(n) (0x21100 + SZ_4 * n)

#define LLCC_TRP_SCID_DIS_CAP_ALLOC 0x21f00
#define LLCC_TRP_PCB_ACT 0x21f04
--
2.34.1

2023-10-12 06:36:46

by Satya Durga Srinivasu Prabhala

Subject: Re: [PATCH] soc: qcom: llcc: Fix LLCC_TRP_ATTR2_CFGn offset

On 10/11/2023 11:11 PM, Abel Vesa wrote:
> According to documentation, it has increments of 4, not 8.
>
> Fixes: c72ca343f911 ("soc: qcom: llcc: Add v4.1 HW version support")
> Reported-by: Umnathi Chalicheemala <[email protected]>
> Signed-off-by: Abel Vesa <[email protected]>

Thanks Abel.

Reviewed-by: Satya Durga Srinivasu Prabhala <[email protected]>

> ---
> drivers/soc/qcom/llcc-qcom.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soc/qcom/llcc-qcom.c b/drivers/soc/qcom/llcc-qcom.c
> index 674abd0d6700..fb4085b7cb19 100644
> --- a/drivers/soc/qcom/llcc-qcom.c
> +++ b/drivers/soc/qcom/llcc-qcom.c
> @@ -47,7 +47,7 @@
> #define LLCC_TRP_STATUSn(n) (4 + n * SZ_4K)
> #define LLCC_TRP_ATTR0_CFGn(n) (0x21000 + SZ_8 * n)
> #define LLCC_TRP_ATTR1_CFGn(n) (0x21004 + SZ_8 * n)
> -#define LLCC_TRP_ATTR2_CFGn(n) (0x21100 + SZ_8 * n)
> +#define LLCC_TRP_ATTR2_CFGn(n) (0x21100 + SZ_4 * n)
>
> #define LLCC_TRP_SCID_DIS_CAP_ALLOC 0x21f00
> #define LLCC_TRP_PCB_ACT 0x21f04

2023-10-12 08:23:43

by Konrad Dybcio

Subject: Re: [PATCH] soc: qcom: llcc: Fix LLCC_TRP_ATTR2_CFGn offset

On 10/12/23 08:11, Abel Vesa wrote:
> According to documentation, it has increments of 4, not 8.
>
> Fixes: c72ca343f911 ("soc: qcom: llcc: Add v4.1 HW version support")
> Reported-by: Umnathi Chalicheemala <[email protected]>
> Signed-off-by: Abel Vesa <[email protected]>
> ---
Reviewed-by: Konrad Dybcio <[email protected]>

Konrad