From: Shaoqin Huang <[email protected]>
There are some parameter being removed in function but the parameter
comments still exist, so remove them.
Signed-off-by: Shaoqin Huang <[email protected]>
---
tools/testing/selftests/kvm/lib/kvm_util.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/tools/testing/selftests/kvm/lib/kvm_util.c b/tools/testing/selftests/kvm/lib/kvm_util.c
index 1665a220abcb..58fdc82b20f4 100644
--- a/tools/testing/selftests/kvm/lib/kvm_util.c
+++ b/tools/testing/selftests/kvm/lib/kvm_util.c
@@ -1336,8 +1336,6 @@ static vm_vaddr_t vm_vaddr_unused_gap(struct kvm_vm *vm, size_t sz,
* vm - Virtual Machine
* sz - Size in bytes
* vaddr_min - Minimum starting virtual address
- * data_memslot - Memory region slot for data pages
- * pgd_memslot - Memory region slot for new virtual translation tables
*
* Output Args: None
*
@@ -1423,7 +1421,6 @@ vm_vaddr_t vm_vaddr_alloc_page(struct kvm_vm *vm)
* vaddr - Virtuall address to map
* paddr - VM Physical Address
* npages - The number of pages to map
- * pgd_memslot - Memory region slot for new virtual translation tables
*
* Output Args: None
*
--
2.30.2
Thanks drew's review.
On 6/14/2022 4:28 PM, Andrew Jones wrote:
> On Tue, Jun 14, 2022 at 09:48:35AM +0200, Andrew Jones wrote:
>> On Tue, Jun 14, 2022 at 04:41:19PM -0600, [email protected] wrote:
>>> From: Shaoqin Huang <[email protected]>
>>>
>>> There are some parameter being removed in function but the parameter
>>> comments still exist, so remove them.
>>>
>>> Signed-off-by: Shaoqin Huang <[email protected]>
>>> ---
>>> tools/testing/selftests/kvm/lib/kvm_util.c | 3 ---
>>> 1 file changed, 3 deletions(-)
>>>
>>> diff --git a/tools/testing/selftests/kvm/lib/kvm_util.c b/tools/testing/selftests/kvm/lib/kvm_util.c
>>> index 1665a220abcb..58fdc82b20f4 100644
>>> --- a/tools/testing/selftests/kvm/lib/kvm_util.c
>>> +++ b/tools/testing/selftests/kvm/lib/kvm_util.c
>>> @@ -1336,8 +1336,6 @@ static vm_vaddr_t vm_vaddr_unused_gap(struct kvm_vm *vm, size_t sz,
>>> * vm - Virtual Machine
>>> * sz - Size in bytes
>>> * vaddr_min - Minimum starting virtual address
>>> - * data_memslot - Memory region slot for data pages
>>> - * pgd_memslot - Memory region slot for new virtual translation tables
>>> *
>>> * Output Args: None
>>> *
>>> @@ -1423,7 +1421,6 @@ vm_vaddr_t vm_vaddr_alloc_page(struct kvm_vm *vm)
>>> * vaddr - Virtuall address to map
>>> * paddr - VM Physical Address
>>> * npages - The number of pages to map
>>> - * pgd_memslot - Memory region slot for new virtual translation tables
>>> *
>>> * Output Args: None
>>> *
>>> --
>>> 2.30.2
>>>
>>
>> Hi Shaoqin,
>>
>> Please check kvm/queue, the extra parameter comments have already been
>> removed.
>>
>
> Eh, never mind, I looked at the wrong functions. Your patch does indeed
> apply to kvm/queue and is indeed necessary. Sorry for the noise.
>
> Thanks,
> drew
>
On 6/15/22 00:41, [email protected] wrote:
> From: Shaoqin Huang <[email protected]>
>
> There are some parameter being removed in function but the parameter
> comments still exist, so remove them.
>
> Signed-off-by: Shaoqin Huang <[email protected]>
> ---
> tools/testing/selftests/kvm/lib/kvm_util.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/tools/testing/selftests/kvm/lib/kvm_util.c b/tools/testing/selftests/kvm/lib/kvm_util.c
> index 1665a220abcb..58fdc82b20f4 100644
> --- a/tools/testing/selftests/kvm/lib/kvm_util.c
> +++ b/tools/testing/selftests/kvm/lib/kvm_util.c
> @@ -1336,8 +1336,6 @@ static vm_vaddr_t vm_vaddr_unused_gap(struct kvm_vm *vm, size_t sz,
> * vm - Virtual Machine
> * sz - Size in bytes
> * vaddr_min - Minimum starting virtual address
> - * data_memslot - Memory region slot for data pages
> - * pgd_memslot - Memory region slot for new virtual translation tables
> *
> * Output Args: None
> *
> @@ -1423,7 +1421,6 @@ vm_vaddr_t vm_vaddr_alloc_page(struct kvm_vm *vm)
> * vaddr - Virtuall address to map
> * paddr - VM Physical Address
> * npages - The number of pages to map
> - * pgd_memslot - Memory region slot for new virtual translation tables
> *
> * Output Args: None
> *
Queued, thanks!
Paolo