2017-11-13 11:34:19

by Egil Hjelmeland

[permalink] [raw]
Subject: Re: [PATCH 0/2] net: dsa: lan9303: check error value from devm_gpiod_get_optional()

On 13. nov. 2017 09:07, Phil Reid wrote:
> Replaces Pan Bian <[email protected]> patch
> "net: dsa: lan9303: correctly check return value of devm_gpiod_get_optional"
>
> Errors need to be prograted back from probe.
>
> Note: I have only compile tested the code as I don't have the hardware.
>
> Phil Reid (2):
> net: dsa: lan9303: make lan9303_handle_reset() a void function
> net: dsa: lan9303: check error value from devm_gpiod_get_optional()
>
> drivers/net/dsa/lan9303-core.c | 21 ++++++++++++---------
> 1 file changed, 12 insertions(+), 9 deletions(-)
>

I tried this on our HW lan9303, it did not break anything.

Egil


From 1583937601456856800@xxx Mon Nov 13 08:10:09 +0000 2017
X-GM-THRID: 1583937553417041728
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread