2022-09-10 17:36:27

by Dang Huynh

Subject: [PATCH] clk: qcom: sm6115: Select QCOM_GDSC

While working on the Fxtec Pro1X device, this error shows up with
my own minimal configuration:

gcc-sm6115: probe of 1400000.clock-controller failed with error -38

The clock driver depends on CONFIG_QCOM_GDSC and after enabling
that, the driver probes successfully.

Signed-off-by: Dang Huynh <[email protected]>
---
drivers/clk/qcom/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/clk/qcom/Kconfig b/drivers/clk/qcom/Kconfig
index 1cf1ef70e347..d566fbdebdf9 100644
--- a/drivers/clk/qcom/Kconfig
+++ b/drivers/clk/qcom/Kconfig
@@ -645,6 +645,7 @@ config SM_DISPCC_6350

config SM_GCC_6115
tristate "SM6115 and SM4250 Global Clock Controller"
+ select QCOM_GDSC
help
Support for the global clock controller on SM6115 and SM4250 devices.
Say Y if you want to use peripheral devices such as UART, SPI,
--
2.37.3

2022-09-12 13:40:26

by Caleb Connolly

Subject: Re: [PATCH] clk: qcom: sm6115: Select QCOM_GDSC

On 10/09/2022 18:02, Dang Huynh wrote:
> While working on the Fxtec Pro1X device, this error shows up with
> my own minimal configuration:
>
> gcc-sm6115: probe of 1400000.clock-controller failed with error -38
>
> The clock driver depends on CONFIG_QCOM_GDSC and after enabling
> that, the driver probes successfully.
>
> Signed-off-by: Dang Huynh <[email protected]>
> ---
> drivers/clk/qcom/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clk/qcom/Kconfig b/drivers/clk/qcom/Kconfig
> index 1cf1ef70e347..d566fbdebdf9 100644
> --- a/drivers/clk/qcom/Kconfig
> +++ b/drivers/clk/qcom/Kconfig
> @@ -645,6 +645,7 @@ config SM_DISPCC_6350
>
> config SM_GCC_6115
> tristate "SM6115 and SM4250 Global Clock Controller"
> + select QCOM_GDSC

depends on QCOM_GDSC
> help
> Support for the global clock controller on SM6115 and SM4250 devices.
> Say Y if you want to use peripheral devices such as UART, SPI,
> --
> 2.37.3
>

--
Kind Regards,
Caleb

2022-09-12 13:44:23

by Dmitry Baryshkov

Subject: Re: [PATCH] clk: qcom: sm6115: Select QCOM_GDSC

On Mon, 12 Sept 2022 at 16:17, Caleb Connolly <[email protected]> wrote:
>
>
>
> On 10/09/2022 18:02, Dang Huynh wrote:
> > While working on the Fxtec Pro1X device, this error shows up with
> > my own minimal configuration:
> >
> > gcc-sm6115: probe of 1400000.clock-controller failed with error -38
> >
> > The clock driver depends on CONFIG_QCOM_GDSC and after enabling
> > that, the driver probes successfully.
> >
> > Signed-off-by: Dang Huynh <[email protected]>
> > ---
> > drivers/clk/qcom/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/clk/qcom/Kconfig b/drivers/clk/qcom/Kconfig
> > index 1cf1ef70e347..d566fbdebdf9 100644
> > --- a/drivers/clk/qcom/Kconfig
> > +++ b/drivers/clk/qcom/Kconfig
> > @@ -645,6 +645,7 @@ config SM_DISPCC_6350
> >
> > config SM_GCC_6115
> > tristate "SM6115 and SM4250 Global Clock Controller"
> > + select QCOM_GDSC
>
> depends on QCOM_GDSC

All other Qualcomm clock drivers select the GDSC if required, so I'd
tend to disagree.


--
With best wishes
Dmitry

2022-09-12 13:53:05

by Dmitry Baryshkov

Subject: Re: [PATCH] clk: qcom: sm6115: Select QCOM_GDSC

On Sat, 10 Sept 2022 at 20:02, Dang Huynh <[email protected]> wrote:
>
> While working on the Fxtec Pro1X device, this error shows up with
> my own minimal configuration:
>
> gcc-sm6115: probe of 1400000.clock-controller failed with error -38
>
> The clock driver depends on CONFIG_QCOM_GDSC and after enabling
> that, the driver probes successfully.
>
> Signed-off-by: Dang Huynh <[email protected]>

Fixes: cbe63bfdc54f ("clk: qcom: Add Global Clock controller (GCC)
driver for SM6115")
Reviewed-by: Dmitry Baryshkov <[email protected]>

> ---
> drivers/clk/qcom/Kconfig | 1 +
> 1 file changed, 1 insertion(+)



--
With best wishes
Dmitry

2022-09-12 13:56:32

by Caleb Connolly

Subject: Re: [PATCH] clk: qcom: sm6115: Select QCOM_GDSC

On 12/09/2022 14:32, Dmitry Baryshkov wrote:
> On Mon, 12 Sept 2022 at 16:17, Caleb Connolly <[email protected]> wrote:
>>
>>
>>
>> On 10/09/2022 18:02, Dang Huynh wrote:
>>> While working on the Fxtec Pro1X device, this error shows up with
>>> my own minimal configuration:
>>>
>>> gcc-sm6115: probe of 1400000.clock-controller failed with error -38
>>>
>>> The clock driver depends on CONFIG_QCOM_GDSC and after enabling
>>> that, the driver probes successfully.
>>>
>>> Signed-off-by: Dang Huynh <[email protected]>
>>> ---
>>> drivers/clk/qcom/Kconfig | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/clk/qcom/Kconfig b/drivers/clk/qcom/Kconfig
>>> index 1cf1ef70e347..d566fbdebdf9 100644
>>> --- a/drivers/clk/qcom/Kconfig
>>> +++ b/drivers/clk/qcom/Kconfig
>>> @@ -645,6 +645,7 @@ config SM_DISPCC_6350
>>>
>>> config SM_GCC_6115
>>> tristate "SM6115 and SM4250 Global Clock Controller"
>>> + select QCOM_GDSC
>>
>> depends on QCOM_GDSC
>
> All other Qualcomm clock drivers select the GDSC if required, so I'd
> tend to disagree.

Ah, in that case please disregard, sorry for the noise.
>
>
> --
> With best wishes
> Dmitry

--
Kind Regards,
Caleb

2022-09-13 22:50:48

by Bjorn Andersson

Subject: Re: [PATCH] clk: qcom: sm6115: Select QCOM_GDSC

On Sun, 11 Sep 2022 00:02:07 +0700, Dang Huynh wrote:
> While working on the Fxtec Pro1X device, this error shows up with
> my own minimal configuration:
>
> gcc-sm6115: probe of 1400000.clock-controller failed with error -38
>
> The clock driver depends on CONFIG_QCOM_GDSC and after enabling
> that, the driver probes successfully.
>
> [...]

Applied, thanks!

[1/1] clk: qcom: sm6115: Select QCOM_GDSC
commit: 50ee65dc512b9b5c4de354cf3b4dded34f46c571

Best regards,
--
Bjorn Andersson <[email protected]>