2023-06-06 10:07:25

by Geert Uytterhoeven

[permalink] [raw]
Subject: [PATCH] reset: RESET_NUVOTON_MA35D1 should depend on ARCH_MA35

The Nuvoton MA35D1 reset controller is only present on Nuvoton MA35
SoCs. Hence add a dependency on ARCH_MA35, to prevent asking the user
about this driver when configuring a kernel without MA35 SoC support.
Also, do not enable the driver by default when merely compile-testing.

While at it, fix a misspelling of "Nuvoton".

Fixes: e4bb55d6ccf0f774 ("reset: Add Nuvoton ma35d1 reset driver support")
Signed-off-by: Geert Uytterhoeven <[email protected]>
---
drivers/reset/Kconfig | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig
index 0cdf9d64c2185c89..ccd59ddd76100a51 100644
--- a/drivers/reset/Kconfig
+++ b/drivers/reset/Kconfig
@@ -144,8 +144,9 @@ config RESET_NPCM
BMC SoCs.

config RESET_NUVOTON_MA35D1
- bool "Nuvton MA35D1 Reset Driver"
- default ARCH_MA35 || COMPILE_TEST
+ bool "Nuvoton MA35D1 Reset Driver"
+ depends on ARCH_MA35 || COMPILE_TEST
+ default ARCH_MA35
help
This enables the reset controller driver for Nuvoton MA35D1 SoC.

--
2.34.1



2023-06-06 10:15:28

by Ilpo Järvinen

[permalink] [raw]
Subject: Re: [PATCH] reset: RESET_NUVOTON_MA35D1 should depend on ARCH_MA35

On Tue, 6 Jun 2023, Geert Uytterhoeven wrote:

> The Nuvoton MA35D1 reset controller is only present on Nuvoton MA35
> SoCs. Hence add a dependency on ARCH_MA35, to prevent asking the user
> about this driver when configuring a kernel without MA35 SoC support.
> Also, do not enable the driver by default when merely compile-testing.
>
> While at it, fix a misspelling of "Nuvoton".
>
> Fixes: e4bb55d6ccf0f774 ("reset: Add Nuvoton ma35d1 reset driver support")
> Signed-off-by: Geert Uytterhoeven <[email protected]>
> ---
> drivers/reset/Kconfig | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig
> index 0cdf9d64c2185c89..ccd59ddd76100a51 100644
> --- a/drivers/reset/Kconfig
> +++ b/drivers/reset/Kconfig
> @@ -144,8 +144,9 @@ config RESET_NPCM
> BMC SoCs.
>
> config RESET_NUVOTON_MA35D1
> - bool "Nuvton MA35D1 Reset Driver"
> - default ARCH_MA35 || COMPILE_TEST
> + bool "Nuvoton MA35D1 Reset Driver"
> + depends on ARCH_MA35 || COMPILE_TEST
> + default ARCH_MA35
> help
> This enables the reset controller driver for Nuvoton MA35D1 SoC.

All adjustments make sense.

Reviewed-by: Ilpo J?rvinen <[email protected]>


--
i.

2023-06-06 10:36:03

by Arnd Bergmann

[permalink] [raw]
Subject: Re: [PATCH] reset: RESET_NUVOTON_MA35D1 should depend on ARCH_MA35

On Tue, Jun 6, 2023, at 11:59, Ilpo Järvinen wrote:
> On Tue, 6 Jun 2023, Geert Uytterhoeven wrote:
>
>> The Nuvoton MA35D1 reset controller is only present on Nuvoton MA35
>> SoCs. Hence add a dependency on ARCH_MA35, to prevent asking the user
>> about this driver when configuring a kernel without MA35 SoC support.
>> Also, do not enable the driver by default when merely compile-testing.
>>
>> While at it, fix a misspelling of "Nuvoton".
>>
>> Fixes: e4bb55d6ccf0f774 ("reset: Add Nuvoton ma35d1 reset driver support")
>> Signed-off-by: Geert Uytterhoeven <[email protected]>

> Reviewed-by: Ilpo Järvinen <[email protected]>

Applied on top of the initial patch, thanks!

Arnd