2021-07-20 00:21:44

by Rob Herring (Arm)

[permalink] [raw]
Subject: Re: [PATCH v5 1/2] dt-bindings: Add binding for Renesas 8T49N241

On Mon, 19 Jul 2021 11:20:00 -0700, Alex Helms wrote:
> Renesas 8T49N241 has 4 outputs, 1 integral and 3 fractional dividers.
> The 8T49N241 accepts up to two differential or single-ended input clocks
> and a fundamental-mode crystal input. The internal PLL can lock to either
> of the input reference clocks or to the crystal to behave as a frequency
> synthesizer.
>
> Signed-off-by: Alex Helms <[email protected]>
> ---
> .../bindings/clock/renesas,8t49n241.yaml | 190 ++++++++++++++++++
> MAINTAINERS | 6 +
> 2 files changed, 196 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/clock/renesas,8t49n241.yaml
>


Please add Acked-by/Reviewed-by tags when posting new versions. However,
there's no need to repost patches *only* to add the tags. The upstream
maintainer will do that for acks received on the version they apply.

If a tag was not added on purpose, please state why and what changed.


2021-07-20 17:02:50

by Alex Helms

[permalink] [raw]
Subject: Re: [PATCH v5 1/2] dt-bindings: Add binding for Renesas 8T49N241

On 7/19/2021 3:48 PM, Rob Herring wrote:
> On Mon, 19 Jul 2021 11:20:00 -0700, Alex Helms wrote:
>> Renesas 8T49N241 has 4 outputs, 1 integral and 3 fractional dividers.
>> The 8T49N241 accepts up to two differential or single-ended input clocks
>> and a fundamental-mode crystal input. The internal PLL can lock to either
>> of the input reference clocks or to the crystal to behave as a frequency
>> synthesizer.
>>
>> Signed-off-by: Alex Helms <[email protected]>
>> ---
>> .../bindings/clock/renesas,8t49n241.yaml | 190 ++++++++++++++++++
>> MAINTAINERS | 6 +
>> 2 files changed, 196 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/clock/renesas,8t49n241.yaml
>>
>
>
> Please add Acked-by/Reviewed-by tags when posting new versions. However,
> there's no need to repost patches *only* to add the tags. The upstream
> maintainer will do that for acks received on the version they apply.
>
> If a tag was not added on purpose, please state why and what changed.
>

Thank you for the info. I'm new to the kernel process and appreciate your advice.

I felt uncomfortable adding your Reviewed-By tag but since there were no changes to the dt
portion of the patch, in retrospect I guess I should have added it. I'll keep this in mind
for the future. Is there anything I need to do for this patch?

2021-07-22 14:22:49

by Rob Herring (Arm)

[permalink] [raw]
Subject: Re: [PATCH v5 1/2] dt-bindings: Add binding for Renesas 8T49N241

On Tue, Jul 20, 2021 at 10:58 AM Alex Helms
<[email protected]> wrote:
>
> On 7/19/2021 3:48 PM, Rob Herring wrote:
> > On Mon, 19 Jul 2021 11:20:00 -0700, Alex Helms wrote:
> >> Renesas 8T49N241 has 4 outputs, 1 integral and 3 fractional dividers.
> >> The 8T49N241 accepts up to two differential or single-ended input clocks
> >> and a fundamental-mode crystal input. The internal PLL can lock to either
> >> of the input reference clocks or to the crystal to behave as a frequency
> >> synthesizer.
> >>
> >> Signed-off-by: Alex Helms <[email protected]>
> >> ---
> >> .../bindings/clock/renesas,8t49n241.yaml | 190 ++++++++++++++++++
> >> MAINTAINERS | 6 +
> >> 2 files changed, 196 insertions(+)
> >> create mode 100644 Documentation/devicetree/bindings/clock/renesas,8t49n241.yaml
> >>
> >
> >
> > Please add Acked-by/Reviewed-by tags when posting new versions. However,
> > there's no need to repost patches *only* to add the tags. The upstream
> > maintainer will do that for acks received on the version they apply.
> >
> > If a tag was not added on purpose, please state why and what changed.
> >
>
> Thank you for the info. I'm new to the kernel process and appreciate your advice.
>
> I felt uncomfortable adding your Reviewed-By tag but since there were no changes to the dt
> portion of the patch, in retrospect I guess I should have added it. I'll keep this in mind
> for the future. Is there anything I need to do for this patch?

For v5, no. If there's a v6 posted, then add any tags.

Rob