2022-09-09 07:10:56

by Gaosheng Cui

[permalink] [raw]
Subject: [PATCH] jfs: remove unused declarations for jfs

extRealloc(), xtRelocate(), xtDelete() and extFill() have been
removed since commit e471e5942c00 ("fs/jfs: Remove dead code"),
so remove them.

Signed-off-by: Gaosheng Cui <[email protected]>
---
fs/jfs/jfs_extent.h | 2 --
fs/jfs/jfs_xtree.h | 4 ----
2 files changed, 6 deletions(-)

diff --git a/fs/jfs/jfs_extent.h b/fs/jfs/jfs_extent.h
index 1c984214e95e..a0ee4ccea66e 100644
--- a/fs/jfs/jfs_extent.h
+++ b/fs/jfs/jfs_extent.h
@@ -10,9 +10,7 @@
(addressPXD(&(JFS_IP(ip)->ixpxd)) + lengthPXD(&(JFS_IP(ip)->ixpxd)) - 1)

extern int extAlloc(struct inode *, s64, s64, xad_t *, bool);
-extern int extFill(struct inode *, xad_t *);
extern int extHint(struct inode *, s64, xad_t *);
-extern int extRealloc(struct inode *, s64, xad_t *, bool);
extern int extRecord(struct inode *, xad_t *);

#endif /* _H_JFS_EXTENT */
diff --git a/fs/jfs/jfs_xtree.h b/fs/jfs/jfs_xtree.h
index 142caafc73b1..ad7592191d76 100644
--- a/fs/jfs/jfs_xtree.h
+++ b/fs/jfs/jfs_xtree.h
@@ -96,12 +96,8 @@ extern int xtInsert(tid_t tid, struct inode *ip,
extern int xtExtend(tid_t tid, struct inode *ip, s64 xoff, int xlen,
int flag);
extern int xtUpdate(tid_t tid, struct inode *ip, struct xad *nxad);
-extern int xtDelete(tid_t tid, struct inode *ip, s64 xoff, int xlen,
- int flag);
extern s64 xtTruncate(tid_t tid, struct inode *ip, s64 newsize, int type);
extern s64 xtTruncate_pmap(tid_t tid, struct inode *ip, s64 committed_size);
-extern int xtRelocate(tid_t tid, struct inode *ip,
- xad_t * oxad, s64 nxaddr, int xtype);
extern int xtAppend(tid_t tid,
struct inode *ip, int xflag, s64 xoff, int maxblocks,
int *xlenp, s64 * xaddrp, int flag);
--
2.25.1


2022-10-17 21:21:32

by Dave Kleikamp

[permalink] [raw]
Subject: Re: [PATCH] jfs: remove unused declarations for jfs

Applied.

Thanks,
Shaggy

On 9/9/22 1:50AM, Gaosheng Cui wrote:
> extRealloc(), xtRelocate(), xtDelete() and extFill() have been
> removed since commit e471e5942c00 ("fs/jfs: Remove dead code"),
> so remove them.
>
> Signed-off-by: Gaosheng Cui <[email protected]>
> ---
> fs/jfs/jfs_extent.h | 2 --
> fs/jfs/jfs_xtree.h | 4 ----
> 2 files changed, 6 deletions(-)
>
> diff --git a/fs/jfs/jfs_extent.h b/fs/jfs/jfs_extent.h
> index 1c984214e95e..a0ee4ccea66e 100644
> --- a/fs/jfs/jfs_extent.h
> +++ b/fs/jfs/jfs_extent.h
> @@ -10,9 +10,7 @@
> (addressPXD(&(JFS_IP(ip)->ixpxd)) + lengthPXD(&(JFS_IP(ip)->ixpxd)) - 1)
>
> extern int extAlloc(struct inode *, s64, s64, xad_t *, bool);
> -extern int extFill(struct inode *, xad_t *);
> extern int extHint(struct inode *, s64, xad_t *);
> -extern int extRealloc(struct inode *, s64, xad_t *, bool);
> extern int extRecord(struct inode *, xad_t *);
>
> #endif /* _H_JFS_EXTENT */
> diff --git a/fs/jfs/jfs_xtree.h b/fs/jfs/jfs_xtree.h
> index 142caafc73b1..ad7592191d76 100644
> --- a/fs/jfs/jfs_xtree.h
> +++ b/fs/jfs/jfs_xtree.h
> @@ -96,12 +96,8 @@ extern int xtInsert(tid_t tid, struct inode *ip,
> extern int xtExtend(tid_t tid, struct inode *ip, s64 xoff, int xlen,
> int flag);
> extern int xtUpdate(tid_t tid, struct inode *ip, struct xad *nxad);
> -extern int xtDelete(tid_t tid, struct inode *ip, s64 xoff, int xlen,
> - int flag);
> extern s64 xtTruncate(tid_t tid, struct inode *ip, s64 newsize, int type);
> extern s64 xtTruncate_pmap(tid_t tid, struct inode *ip, s64 committed_size);
> -extern int xtRelocate(tid_t tid, struct inode *ip,
> - xad_t * oxad, s64 nxaddr, int xtype);
> extern int xtAppend(tid_t tid,
> struct inode *ip, int xflag, s64 xoff, int maxblocks,
> int *xlenp, s64 * xaddrp, int flag);