2024-03-24 00:42:24

by pascal.eberhard

Subject: [PATCH] ubifs: xattr: remove unused anonymous enum

From: Pascal Eberhard <[email protected]>

commit 2b88fc21cae9 ("ubifs: Switch to generic xattr handlers") removes
usage of this anonymous enum. Delete the enum as well.

Signed-off-by: Pascal Eberhard <[email protected]>
---
fs/ubifs/xattr.c | 13 -------------
1 file changed, 13 deletions(-)

diff --git a/fs/ubifs/xattr.c b/fs/ubifs/xattr.c
index 0847db521984..f0969519ad05 100644
--- a/fs/ubifs/xattr.c
+++ b/fs/ubifs/xattr.c
@@ -48,19 +48,6 @@
#include <linux/slab.h>
#include <linux/xattr.h>

-/*
- * Extended attribute type constants.
- *
- * USER_XATTR: user extended attribute ("user.*")
- * TRUSTED_XATTR: trusted extended attribute ("trusted.*)
- * SECURITY_XATTR: security extended attribute ("security.*")
- */
-enum {
- USER_XATTR,
- TRUSTED_XATTR,
- SECURITY_XATTR,
-};
-
static const struct inode_operations empty_iops;
static const struct file_operations empty_fops;

--
2.40.1

2024-03-25 10:09:15

by Zhihao Cheng

Subject: Re: [PATCH] ubifs: xattr: remove unused anonymous enum

?? 2024/3/24 8:41, [email protected] д??:
> From: Pascal Eberhard <[email protected]>
>
> commit 2b88fc21cae9 ("ubifs: Switch to generic xattr handlers") removes
> usage of this anonymous enum. Delete the enum as well.
>
> Signed-off-by: Pascal Eberhard <[email protected]>
> ---
> fs/ubifs/xattr.c | 13 -------------
> 1 file changed, 13 deletions(-)

Reviewed-by: Zhihao Cheng <[email protected]>
>
> diff --git a/fs/ubifs/xattr.c b/fs/ubifs/xattr.c
> index 0847db521984..f0969519ad05 100644
> --- a/fs/ubifs/xattr.c
> +++ b/fs/ubifs/xattr.c
> @@ -48,19 +48,6 @@
> #include <linux/slab.h>
> #include <linux/xattr.h>
>
> -/*
> - * Extended attribute type constants.
> - *
> - * USER_XATTR: user extended attribute ("user.*")
> - * TRUSTED_XATTR: trusted extended attribute ("trusted.*)
> - * SECURITY_XATTR: security extended attribute ("security.*")
> - */
> -enum {
> - USER_XATTR,
> - TRUSTED_XATTR,
> - SECURITY_XATTR,
> -};
> -
> static const struct inode_operations empty_iops;
> static const struct file_operations empty_fops;
>
>