2023-07-17 15:35:43

by Benjamin Gaignard

Subject: [PATCH] media: rkvdec: increase max supported height for H.264

After testing it is possible for the hardware to decode H264
bistream with a height up to 2560.

Signed-off-by: Benjamin Gaignard <[email protected]>
---
drivers/staging/media/rkvdec/rkvdec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/media/rkvdec/rkvdec.c b/drivers/staging/media/rkvdec/rkvdec.c
index 134e2b9fa7d9..84a41792cb4b 100644
--- a/drivers/staging/media/rkvdec/rkvdec.c
+++ b/drivers/staging/media/rkvdec/rkvdec.c
@@ -120,7 +120,7 @@ static const struct rkvdec_coded_fmt_desc rkvdec_coded_fmts[] = {
.max_width = 4096,
.step_width = 16,
.min_height = 48,
- .max_height = 2304,
+ .max_height = 2560,
.step_height = 16,
},
.ctrls = &rkvdec_h264_ctrls,
--
2.39.2

2023-07-17 16:31:56

by Nicolas Dufresne

Subject: Re: [PATCH] media: rkvdec: increase max supported height for H.264

Le lundi 17 juillet 2023 à 17:06 +0200, Benjamin Gaignard a écrit :
> After testing it is possible for the hardware to decode H264
> bistream with a height up to 2560.
>
> Signed-off-by: Benjamin Gaignard <[email protected]>

Thanks, this could possibly have a Fixes tag ?
Fixes: cd33c830448ba ("media: rkvdec: Add the rkvdec driver")

With or without the that though:
Reviewed-by: Nicolas Dufresne <[email protected]>

> ---
> drivers/staging/media/rkvdec/rkvdec.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/rkvdec/rkvdec.c b/drivers/staging/media/rkvdec/rkvdec.c
> index 134e2b9fa7d9..84a41792cb4b 100644
> --- a/drivers/staging/media/rkvdec/rkvdec.c
> +++ b/drivers/staging/media/rkvdec/rkvdec.c
> @@ -120,7 +120,7 @@ static const struct rkvdec_coded_fmt_desc rkvdec_coded_fmts[] = {
> .max_width = 4096,
> .step_width = 16,
> .min_height = 48,
> - .max_height = 2304,
> + .max_height = 2560,
> .step_height = 16,
> },
> .ctrls = &rkvdec_h264_ctrls,