2021-10-01 15:41:30

by Jeff Layton

Subject: [PATCH] mount.2: note that mandatory locking is now fully deprecated

This support has been fully removed from the kernel as of v5.15.

Cc: Jan Kara <[email protected]>
Signed-off-by: Jeff Layton <[email protected]>
---
man2/mount.2 | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/man2/mount.2 b/man2/mount.2
index bedd39e68a68..a7ae65fb0142 100644
--- a/man2/mount.2
+++ b/man2/mount.2
@@ -195,7 +195,8 @@ this mount option requires the
.B CAP_SYS_ADMIN
capability and a kernel configured with the
.B CONFIG_MANDATORY_FILE_LOCKING
-option.
+option. Mandatory locking has been fully deprecated in v5.15 kernels, so
+this flag should be considered deprecated.
.TP
.B MS_NOATIME
Do not update access times for (all types of) files on this filesystem.
--
2.31.1

2021-10-02 17:46:50

by Alejandro Colomar

Subject: Re: [PATCH] mount.2: note that mandatory locking is now fully deprecated

Hello Jeff,

On 10/1/21 1:57 PM, Jeff Layton wrote:
> This support has been fully removed from the kernel as of v5.15.
>
> Cc: Jan Kara <[email protected]>
> Signed-off-by: Jeff Layton <[email protected]>
> ---
> man2/mount.2 | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/man2/mount.2 b/man2/mount.2
> index bedd39e68a68..a7ae65fb0142 100644
> --- a/man2/mount.2
> +++ b/man2/mount.2
> @@ -195,7 +195,8 @@ this mount option requires the
> .B CAP_SYS_ADMIN
> capability and a kernel configured with the
> .B CONFIG_MANDATORY_FILE_LOCKING
> -option.
> +option. Mandatory locking has been fully deprecated in v5.15 kernels, so
> +this flag should be considered deprecated.

Please use semantic newlines, as man-pages(7) notes. It is especially
important here, as otherwise you're hardcoding the number of spaces
after the '.' (which if you don't, will typically be 2).

See man-pages(7):

Use semantic newlines
In the source of a manual page, new sentences should be
started on new lines, and long sentences should be split
into lines at clause breaks (commas, semicolons, colons,
and so on). This convention, sometimes known as "semantic
newlines", makes it easier to see the effect of patches,
which often operate at the level of individual sentences or
sentence clauses.


Cheers,

Alex

> .TP
> .B MS_NOATIME
> Do not update access times for (all types of) files on this filesystem.
>


--
Alejandro Colomar
Linux man-pages comaintainer; https://www.kernel.org/doc/man-pages/
http://www.alejandro-colomar.es/