2020-09-22 11:22:46

by Li Heng

Subject: [PATCH -next] clk: qcom: Remove set but not used variable

This addresses the following gcc warning with "make W=1":

drivers/clk/qcom/gcc-sdm660.c:52:32:warning:
‘gcc_parent_map_xo_gpll0’ defined but not used [-Wunused-const-variable=]

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Li Heng <[email protected]>
---
drivers/clk/qcom/gcc-sdm660.c | 5 -----
1 file changed, 5 deletions(-)

diff --git a/drivers/clk/qcom/gcc-sdm660.c b/drivers/clk/qcom/gcc-sdm660.c
index f0b47b7..db0fb7e 100644
--- a/drivers/clk/qcom/gcc-sdm660.c
+++ b/drivers/clk/qcom/gcc-sdm660.c
@@ -49,11 +49,6 @@ static const char * const gcc_parent_names_xo_gpll0_gpll0_early_div[] = {
"gpll0_early_div",
};

-static const struct parent_map gcc_parent_map_xo_gpll0[] = {
- { P_XO, 0 },
- { P_GPLL0, 1 },
-};
-
static const char * const gcc_parent_names_xo_gpll0[] = {
"xo",
"gpll0",
--
2.7.4

2020-09-22 12:38:01

by Konrad Dybcio

Subject: Re: [PATCH -next] clk: qcom: Remove set but not used variable

Hi,

This is not the correct solution. I sent a proper fix here [1].

Please do not modify critical platform drivers without having tested them on real hardware (I don't see any Tested-by's?). Instead, file a bug report so that more people can take a look at this. If this got merged, it would have had to be reverted eventually anyway..

[1] https://patchwork.kernel.org/patch/11792407/

Konrad