2023-07-14 11:40:45

by Amadeusz Sławiński

[permalink] [raw]
Subject: Re: [PATCH v2 07/15] ALSA: hda/i915: Use global PCI match macro

On 7/14/2023 1:20 PM, Andy Shevchenko wrote:
> On Fri, Jul 14, 2023 at 08:56:07PM +0200, Amadeusz Sławiński wrote:
>> Instead of using local macro to match PCI device, use global one.
>
> ...
>
>> @@ -2718,7 +2718,6 @@
>> #define PCI_DEVICE_ID_INTEL_82840_HB 0x1a21
>> #define PCI_DEVICE_ID_INTEL_82845_HB 0x1a30
>> #define PCI_DEVICE_ID_INTEL_IOAT 0x1a38
>> -#define PCI_DEVICE_ID_INTEL_HDA_APL_T 0x1a98
>> #define PCI_DEVICE_ID_INTEL_HDA_CPT 0x1c20
>> #define PCI_DEVICE_ID_INTEL_COUGARPOINT_LPC_MIN 0x1c41
>> #define PCI_DEVICE_ID_INTEL_COUGARPOINT_LPC_MAX 0x1c5f
>
> Looks like it should be a separate change.
>

Oops... must have fixed up wrong patch, and I even looked at all patches
before sending them, to check for something like that :|