2024-05-01 09:21:42

by Christophe JAILLET

Subject: [PATCH] iio: temperature: max30208: Remove an unused field in struct max30208_data

In "struct max30208_data", the 'indio_dev' field is unused.
Remove it.

Found with cppcheck, unusedStructMember.

Signed-off-by: Christophe JAILLET <[email protected]>
---
Compile tested only.

It was added in the initial commit 9ee95ae4cffd ("iio: temperature: Add
driver support for Maxim MAX30208") but was never used.
---
drivers/iio/temperature/max30208.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/iio/temperature/max30208.c b/drivers/iio/temperature/max30208.c
index 48be03852cd8..720469f9dc36 100644
--- a/drivers/iio/temperature/max30208.c
+++ b/drivers/iio/temperature/max30208.c
@@ -34,7 +34,6 @@

struct max30208_data {
struct i2c_client *client;
- struct iio_dev *indio_dev;
struct mutex lock; /* Lock to prevent concurrent reads of temperature readings */
};

--
2.44.0

2024-05-04 11:40:30

by Jonathan Cameron

Subject: Re: [PATCH] iio: temperature: max30208: Remove an unused field in struct max30208_data

On Wed, 1 May 2024 11:19:41 +0200
Christophe JAILLET <[email protected]> wrote:

> In "struct max30208_data", the 'indio_dev' field is unused.
> Remove it.
>
> Found with cppcheck, unusedStructMember.
>
> Signed-off-by: Christophe JAILLET <[email protected]>
Applied,

Thanks,

J
> ---
> Compile tested only.
>
> It was added in the initial commit 9ee95ae4cffd ("iio: temperature: Add
> driver support for Maxim MAX30208") but was never used.
> ---
> drivers/iio/temperature/max30208.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/iio/temperature/max30208.c b/drivers/iio/temperature/max30208.c
> index 48be03852cd8..720469f9dc36 100644
> --- a/drivers/iio/temperature/max30208.c
> +++ b/drivers/iio/temperature/max30208.c
> @@ -34,7 +34,6 @@
>
> struct max30208_data {
> struct i2c_client *client;
> - struct iio_dev *indio_dev;
> struct mutex lock; /* Lock to prevent concurrent reads of temperature readings */
> };
>